Crash when disabling display

[trbjo]

If you disable a display, for example when you connect your laptop to an external display, gtklock will crash, leaving the session unlocked.

How to reproduce:
Run gtklock &!; sleep 2; swaymsg output eDP-1 disable; sleep 2; swaymsg output eDP-1 enable

[jovanlanik]

Can't seem to reproduce... Maybe you could give me more info? What distro are on? Are you using a package or building gtklock yourself? Versions of sway and all libraries (gtk3, gtk-layer-shell, wayland, pam)?

Maybe try logging the crash in gdb and send me the output.

[trbjo]

Arch linux, just built it using make and make install. Will debug later and post the output here.

• local/gtk3 1:3.24.34-1
• sway version 1.8-dev-b20585b2 (Apr 23 2022, branch 'HEAD')
• local/gtk-layer-shell 0.7.0-2
• local/wlroots-git 0.16.0.r5457.640f3b9f-1

[jovanlanik]

Okay, I'll try replicating in my arch vm.

[jovanlanik]

Also check out the AUR package, if you don't want to compile gtklock manually.
https://aur.archlinux.org/packages/gtklock-git

[jovanlanik]

@trbjo Any info on this? I can't reproduce...

[jovanlanik]

My bad, I misunderstood the steps. Managed to replicate the issue. The bug seems to happen when the last window get closed by a wayland event (specifically zwlr_layer_surface_v1::closed). After that the application exits because there aren't any open windows.
It can also happen while an output is initializing (you connect an external display, internal gets disabled, gtklock exits and only after the external is initialized) or after a device resumes from sleep.

[jovanlanik]

I think 20a5b4d fixed this, can you confirm?

[jovanlanik]

I'm confident this issue was fixed, so I'm closing it.