You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Describe the bug
During my work on #292 I've noticed that Next.js is adding a script with the name start which is used for a different purpose. It is not the development server. It's the server to serve the production build locally.
The development server script is called dev.
This issue needs to wait for the mentioned PR.
To Reproduce
Create a new Next.js project and have a look at description for start script
Create a new CRA project. It will have the same description for start script
Expected behavior
We should have a naming that's more specific to each project type.
I think we have two options to solve this:
Create a new reducer project-description.reducer and store the description on the redux state. e.g.
{'create-react-app': {start: 'Run a local development server',build: 'Bundle your project for production',test: 'Run the automated tests',eject: 'Permanently reveal the create-react-app configuration files',format: 'Runs a formatter that tweaks your code to align with industry best-practices'},gatsby: {// same as CRA - duplicate string here},nextjs: {start: 'Starts the application in production mode',build: 'Bundle your project for production'}}
Add the description to a config file
Screenshots
Environment:
OS: all
Version: master
Node version: -
Things to discuss:
Do we need this description on a per project basis? That would be needed if we want to implement custom task descriptions per project.
Is it OK to store the description in state? If we want the description project specific maybe we need to store it in a guppy configuration folder e.g. .guppy and save it in a configuration file. This would also allow us to move the guppy stuff from package.json to a configuration file inside .guppy
The text was updated successfully, but these errors were encountered:
I think the .guppy config file can be added later. I'm adding the project task descriptions to src/config/project-descriptions.js - I think it's not needed as a reducer as it is just an object literal constant.
Describe the bug
During my work on #292 I've noticed that Next.js is adding a script with the name
start
which is used for a different purpose. It is not the development server. It's the server to serve the production build locally.The development server script is called
dev
.This issue needs to wait for the mentioned PR.
To Reproduce
Expected behavior
We should have a naming that's more specific to each project type.
I think we have two options to solve this:
project-description.reducer
and store the description on the redux state. e.g.Screenshots
Environment:
Things to discuss:
.guppy
and save it in a configuration file. This would also allow us to move the guppy stuff frompackage.json
to a configuration file inside.guppy
The text was updated successfully, but these errors were encountered: