Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for fuzzy search? #50

Open
prasoon2211 opened this issue May 21, 2024 · 3 comments
Open

Option for fuzzy search? #50

prasoon2211 opened this issue May 21, 2024 · 3 comments

Comments

@prasoon2211
Copy link

Hi, thanks a lot for this extension! I far prefer it to VSCode's inbuilt project-level search.

One thing that would be extremely helpful is fuzzy search - the type you can do with fzf. I know ripgrep doesn't support fuzzy search natively and I wasn't able to figure out a rgQueryParam that could somehow make fuzzy search work with existing ripgrep options.

One possible option would be to somehow bake in fzf into the tool. In any case, this would be very helpful :)

@joshmu
Copy link
Owner

joshmu commented May 26, 2024

Hey @prasoon2211
I looked in to bringing in fzf when I first developed Periscope and then couldn't get it to behave how I wanted. In the end I found ripgrep far more useful for me.

I'm always open to a PR if you have ideas or feel free to provide references and perhaps myself or someone in the community can take it up.

I don't necessarily fuzzy search but when I am not sure I just add wildcards '.*' within my query.

@Aleksandaar
Copy link

New PR added for the fuzzy search - #65

Otherwise - great plugin! @joshmu

@joshmu
Copy link
Owner

joshmu commented Oct 5, 2024

Moving forward Periscope will primarily scoped to supporting ripgrep features for advanced search.
This is due to vscode now natively supporting both "File Search" and "Quick Search" which both are fuzzy search capable.

Will keep this request open on the off chance an idea comes up on how fuzzy search could be integrated with the pre-existing ripgrep searches which can also include additional rg args passed to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants