Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fresh install immediately crashes due to missing javascript_importmap_shim_tag #39

Open
jmdfm opened this issue Jan 9, 2024 · 7 comments · May be fixed by #40
Open

Fresh install immediately crashes due to missing javascript_importmap_shim_tag #39

jmdfm opened this issue Jan 9, 2024 · 7 comments · May be fixed by #40

Comments

@jmdfm
Copy link

jmdfm commented Jan 9, 2024

Fresh installation, with Rails 7.1.2:

undefined local variable or method `javascript_importmap_shim_tag'

I think this is caused by the dependency you have in the .gemspec liberally accepting any version of importmap-rails >=1, and DHH has removed the shim in > 2.0.
@jmdfm jmdfm linked a pull request Jan 9, 2024 that will close this issue
Open
@johncjensen
Copy link

Having the same exact issue. @joshmn ?

@kieranklaassen
Copy link

Same!

@jmdfm
Copy link
Author

jmdfm commented Jan 30, 2024

I opened a PR for this a few weeks back: #40

@scottcmerritt
Copy link

I experienced this issue as well. This engine appears nice and useful, it would be nice to try it out with rails 7.1.2

@krzysztofkeczkowski
Copy link

Same. @joshmn ?

@tomatkapitalise
Copy link

Can confirm @johnmcdowall has a fix with #40 which can be applied with the gem line of:

gem "ahoy_captain", git: 'https://github.com/johnmcdowall/ahoy_captain.git', branch: 'fix_importmaps'

Would be great to see this merged. Thanks for the work.

@beydogan
Copy link

Can also confirm #40 fixes the issue with me on a Rails 7.1 app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop the shim calls and bump importmaps-rails to min requirement to 2 jmdfm/ahoy_captain
7 participants
@kieranklaassen @jmdfm @beydogan @johncjensen @scottcmerritt @krzysztofkeczkowski @tomatkapitalise