Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for imperative mood in commit messages #1

Closed
jacebrowning opened this issue Aug 7, 2015 · 1 comment
Closed

Check for imperative mood in commit messages #1

jacebrowning opened this issue Aug 7, 2015 · 1 comment
Labels
enhancement

Comments

@jacebrowning
Copy link
Collaborator

https://github.com/joshfriend/hooker/blob/master/examples/commit-msg/validate_commit_text.py seems to cover every rule on http://chris.beams.io/posts/git-commit/ except for the imperative mood check.

A complete check would be nearly impossible without natural language processing, but you could what pep257 does and confirm the first word does not end in a single "s": https://github.com/GreenSteam/pep257/blob/0cb5c2ebc9d8789e655e609413b778d28c02084a/pep257.py#L1146-L1150
@jacebrowning
Copy link
Collaborator Author

You could also wait for a solution to: PyCQA/pydocstyle#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshfriend @jacebrowning