Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is there to do before v1? #46

Open
joshfarrant opened this issue Dec 4, 2018 · 3 comments
Open

What is there to do before v1? #46

joshfarrant opened this issue Dec 4, 2018 · 3 comments
Labels
discussion Discussion of future features
Milestone

Comments

@joshfarrant
Copy link
Owner

joshfarrant commented Dec 4, 2018

There's been a lot going on with Shortcuts JS since launch, the vast majority of which has been thanks to work done by our Contributors, so a massive thank you to @pietropizzi, @Archez, @DanielRuf, @xAlien95, @gcordalis, @JB1905, @bachya, and @ikaikastine. 🎉

With so much going on, I thought it could be useful to try to consolidate all of the tasks that will need to be completed before we can consider the library at v1. We can branch off individual tasks into their own issues as need be, but at the moment it would be nice to get a big picture of everything that's left to do.

In my mind, I'd imagined that a v1 release would essentially expose all of the main functionality found in the official Shortcuts app. That includes:

  • Supporting all 312 built-in actions.
  • Full support for creating and using variables.
  • Ability to choose an icon colour and glyph for the generated Shortcut
  • Import questions

Progress with these items so far is as follows:

I'm probably missing some things here, so please let me know and I'll add it in.

As an aside, I'd also like to come up with a better documentation solution before hitting v1. The current docs are just ok and, while they're better than the previous solution (using jsdoc), they're still not fantastic. I get the feeling we're going to have to roll our own solution, as none of the out-of-the-box options are quite right. Hopefully we'll be able to base this custom solution on the JSON output from typedoc as that won't require any changes to the code, and typedoc is actually pretty good at what it does.

Thanks again to everyone for their contributions! 💙

@joshfarrant joshfarrant added the discussion Discussion of future features label Dec 4, 2018
@joshfarrant joshfarrant added this to the v1 milestone Dec 4, 2018
@xAlien95
Copy link
Contributor

xAlien95 commented Dec 4, 2018

Hopefully we'll be able to base this custom solution on the JSON output from typedoc as that won't require any changes to the code, and typedoc is actually pretty good at what it does.

Few days ago I created a local branch with some customization to the default/minimal theme of TypeDoc (TypeStrong/typedoc-default-themes). I didn't thought to look for an exported/compiled JSON output at all.. that would be more than great: that would be awesome.

There's a problem with the current TypeDoc implementation: it cannot specify what kind of WFSerialization is allowed to be passed to an action parameter. There are parameters that can accept only an askWhenRun global variable, other ones that can only accept strings or withVariable serializations. That's something that should be worked on in the docs.

@gcordalis
Copy link
Contributor

We also need to take a look at Show in Widget and Show in Share Sheet.

At the moment all shortcuts default to Show in Widget = true and having the option to customise these would be great.

@regaw-leinad
Copy link
Contributor

regaw-leinad commented Dec 17, 2018

At the moment all shortcuts default to Show in Widget = true and having the option to customise these would be great.

Just submitted PR #59 for this. Found (what I think to be) a Shortcuts iOS client bug while working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion of future features
Projects
None yet
Development

No branches or pull requests

4 participants