Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't stop everything if hooks are not available #27

Closed
rom1504 opened this issue Dec 9, 2015 · 4 comments · Fixed by #32
Closed

Don't stop everything if hooks are not available #27

rom1504 opened this issue Dec 9, 2015 · 4 comments · Fixed by #32
Labels

Comments

@rom1504
Copy link

rom1504 commented Dec 9, 2015

When you don't have admin access to the repo (for example if you only have contributor access), you don't have the right to see hooks.
Currently that means getting a

Retrieving <user> hooks
API request returned HTTP 404: Not Found

and then the program exits

It should indeed display a warning, but it shouldn't stop there. (you might have the rights to get the hooks in some repo and not others)

@rom1504
Copy link
Author

rom1504 commented Dec 9, 2015

something to do with eht16@534145d

temporary fix : use --starred --watched --issues --issue-comments --issue-events --pulls --pull-comments --pull-commits --repositories --wikis --labels instead of --all

@josegonzalez
Copy link
Owner

Mind adding a PR for this?

@josegonzalez
Copy link
Owner

@rom1504 friendly bump :)

@ribsadmin
Copy link

ribsadmin commented May 28, 2021

Excuse me for the grave-digging, but i seem to have run into this issue once more. (year 2021), as you expect, i starred the token a little:

github-backup UMCU-RIBS --organization -o '/var/backups/github-backup-RIBS' --token 'ghp_************' --lfs --all

fails on the first 404 found, the hooks page again:

2021-05-28T14:39:17.967: Retrieving UMCU-RIBS hooks 2021-05-28T14:39:17.967: Requesting https://api.github.com/repos/UMCU-RIBS/ALICE/hooks?per_page=100&page=1 2021-05-28T14:39:18.122: API request returned HTTP 404: Not Found

Here the script stops. Not using --all would continue to retrieve all other repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants