Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to the latest version #461

Closed
josdem opened this issue Jan 18, 2025 · 4 comments
Closed

Update dependencies to the latest version #461

josdem opened this issue Jan 18, 2025 · 4 comments

Comments

@josdem
Copy link
Owner

josdem commented Jan 18, 2025

As developer, I would like to see latest versions in the project so that I can be up to date

Acceptance Criteria

  • Spring Boot is updated to 3.4.1
  • Spring dependency management to 1.1.7
  • Flyway MySQL is updated to 11.2.0
  • Spotless to version 7.0.2
  • spring-cloud-gcp-dependencies to version 5.10.0
  • mockito core to version 5.15.2
  • All test are passing
@kaminuma
Copy link
Collaborator

Hi @josdem
and this verup issue
please assign me

@kaminuma
Copy link
Collaborator

Hi @josdem

One of the tests in the current main branch,
UserControllerTest > registering an user,
seems to be failing.

However, since the test results are the same as in the main branch, I believe the dependency updates are fine.

Would it be okay to submit a PR with the version-updated dependencies?

@josdem
Copy link
Owner Author

josdem commented Jan 30, 2025

Hi @josdem

One of the tests in the current main branch, UserControllerTest > registering an user, seems to be failing.

However, since the test results are the same as in the main branch, I believe the dependency updates are fine.

Would it be okay to submit a PR with the version-updated dependencies?

Hi @kaminuma , yes please go ahead with the PR, let's GitHub workflow run our tests, if any is failing I can fix it.

@josdem
Copy link
Owner Author

josdem commented Jan 30, 2025

PR merged: #473

@josdem josdem closed this as completed Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants