-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: quantileSeq expands types unnecessarily #3197
Labels
Comments
Thanks for your input, we could indeed improve the TypeScript definitions I think. Help would be welcome. |
Fixed now in |
Hi. This fix https://github.com/josdejong/mathjs/pull/3198/files broke basic usage: Now this basic usage is broken. const quantiles: number[] = math.quantileSeq([1, 2, 3, 4, 5], [0.25, 0.75]) as number[]; This was supported previous to v12.4.3. |
This fix is now published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The types for quantileSeq have an overly wide return type.
To Reproduce
I think value here should always be a number. This is the behaviour of for example
math.mean
andmath.median
.The text was updated successfully, but these errors were encountered: