Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on v6 #1511

Closed
harrysarson opened this issue May 15, 2019 · 3 comments
Closed

Feedback on v6 #1511

harrysarson opened this issue May 15, 2019 · 3 comments

Comments

@harrysarson
Copy link
Collaborator

I haven't had a chance to dig too deep into version 6 yet but:

a) it looks great!
b) There are a couple of points of feedback I do have.

  1. The repo contains quite a lot of things.
    Whilst searching for the correct files to include to take advantage of the modular architecture, I was a bit overwhelmed by the number of files hanging around.
    There are:

    • core.js (depreciated)
    • index.js
    • number.js
    • es5/index.js
    • es5/number.js
    • es6/index.js
    • es6/number.js
    • src/bundleAny.js
    • src/factoriesAny.js
    • src/factoriesBundle.js
    • src/factoriesNumber.js
    • src/index.js
    • src/core/core.js
    • src/plain/bignumber/arithmetic.js
    • src/plain/bignumber/index.js
    • src/plain/number/arithmetic.js
    • src/plain/number/index.js
    • possibly more that I haven't found
  2. It is not very clear where the documentation is.
    This is partly (or mainly?) due to the fact that the website is still at v5 so maybe this is not a problem after all.
    However, I struggled to find explanations of what I needed to do to (for example) get a bundle of only complex number functions.
    The examples are great but there is not so much explanation of what they are examples of (I mainly had to go off the files name).


There may be more I find as a explore the new version :) Hope this helps!

@josdejong
Copy link
Owner

Thanks for your feedback @harrysarson, that really helps.

The docs aren't updated yet, sorry (see "Still to do"). The best starting point is looking at the short explanation in the history, and the examples (see also "How to try the new stuff?"). Does that help?

@harrysarson
Copy link
Collaborator Author

The HISTORY.md explainers are very helpful!

Does that help?

Yes.


My mistake was I intuatively reached for import { something } from 'mathjs/something'; whereas I now see that all imports are from 'mathjs' and treeshaking works it's magic 👍

@josdejong
Copy link
Owner

👯‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants