Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar overlay behaviour #160

Open
syhol opened this issue Jan 29, 2025 · 4 comments
Open

Sidebar overlay behaviour #160

syhol opened this issue Jan 29, 2025 · 4 comments

Comments

@syhol
Copy link

syhol commented Jan 29, 2025

The current behaviour of the (right) sidebar where it overlays the table can be a bit disorienting, especially so when the cell cursor disappears behind it. I can't even see the last column on some tables without hiding it.

Would it be possible to change it to instead behave like the left navigation sidebar? Or at least not overlay the table to the point where I can't see what I'm doing.

Really enjoying lazysql, thank you very much for all the work you put into it.

@eric-hansen
Copy link

I feel like this should be better-documented, so maybe a follow up issue or something @jorgerojas26 ?

But, assuming you don't need/want the sidebar, you can edit the config.toml (e.g. $HOME/.config/lazysql/config.toml) and set DisableSidebar = true under the application section.

I'm not really versed in TOML format, so pardon the possibly-ignorant conventions. But this should clear up the UI a bit more for you.

@jorgerojas26
Copy link
Owner

Hi, thank you for the issue.

After a while using the sidebar, i agree it is a bit disorienting, i'm thinking that maybe hiding it by default would be better. What do you think?

Also, i did make it as an overlay because i didn't want to waste space on the table, but i'm open to suggestions, of course.

@syhol
Copy link
Author

syhol commented Feb 3, 2025

assuming you don't need/want the sidebar

I just disable it per session with S. This won't stop me from using lazysql, it's just a suggestion for how I think it could be improved for all.

I'm thinking that maybe hiding it by default would be better

As it works today (as an overlay), I agree. It's a cool feature but I didn't have a good first impression of it.

i did make it as an overlay because i didn't want to waste space on the table

I don't see a difference in space taken when its an overlay vs offset, but I might be missing something.

Looking at the two images below, the table takes up the same amount of visible space:

Image

And to illustrate my problem, you can't see the cursor when it's behind the sidebar.

Image

If you prefer overlay, thats no problem, I just want to raise as a suggestion.

@jorgerojas26
Copy link
Owner

Interesting. Thanks for your suggestions, they are very welcomed. Also, thanks for the illustrations.

I will try with an offset layout, i definitely agree with your comments.

Of course all help is welcome, i am a bit busy right now but I'm going to spend some time this week to fix this and other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants