From 23778ee3e39494a9b075a1d5e13771a98a93da82 Mon Sep 17 00:00:00 2001 From: Vladimir Kutepov Date: Sat, 31 Mar 2018 09:57:56 +0300 Subject: [PATCH] Boolean attributes --- src/index.js | 10 +++++++++- test/dom.test.js | 27 +++++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index e79410055..ae0e0a895 100644 --- a/src/index.js +++ b/src/index.js @@ -186,7 +186,15 @@ export function app(state, actions, view, container) { } else { element.removeEventListener(name, eventListener) } - } else if (name in element && name !== "list" && name !== "type" && !isSvg) { + } else if ( + name in element && + name !== "list" && + name !== "type" && + name !== "draggable" && + name !== "spellcheck" && + name !== "translate" && + !isSvg + ) { element[name] = value == null ? "" : value } else if (value != null && value !== false) { element.setAttribute(name, value) diff --git a/test/dom.test.js b/test/dom.test.js index 0d75149c1..04c37f87b 100644 --- a/test/dom.test.js +++ b/test/dom.test.js @@ -652,3 +652,30 @@ testVdomToHtml("events", [ html: `` } ]) + +testVdomToHtml("boolean attributes", [ + { + vdom: ( +
+ + +
+ ), + html: ` +
+ + +
+ ` + } +])