-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all charts accessible #24
Comments
I've started working on this in PR #28. As I bring up in the PR, do we think it's worth differentiating between the accessibility of the simple and detail charts in this repo? i.e in a real app - it doesn't make sense to have VoiceOver users traverse all data points when the chart is in a cell. So for this repo the 2 options are :
|
I would say let’s go for the second option there! |
Awesome thanks for the direction- I'm on it!
EDIT 2: This is an iOS 16 issue force rebooting the device fixes it! RPReplay_Final1655235781.mov |
The descriptions in that video are not great yet. We’ll have to figure out how to say the correct thing! 🤔 I’ll look at Apple’s example soon but there they say something like: Monday, Cupertino sales 150, San Jose sales 120 |
Oh I agree - the video is the issue I referred to above and those are the inferred default system labels. If you can reproduce, try restarting the device. However it does seem to recur. I believe the labels we set for each bar does state the city, sales closer to your example 🙂 |
Adding simple accessibility labels and values goes a long way in making it the standard for people when they use these charts as examples.
Please add these to your sample charts:
.accessibilityLabel("(element.ageRange)")
.accessibilityValue("(element.percentage)")
The text was updated successfully, but these errors were encountered: