From 318ceb54ed92828c292808105afe39788fc7e887 Mon Sep 17 00:00:00 2001
From: Tuan Pham Ngoc <github@joomdonation.com>
Date: Sat, 1 Mar 2025 22:40:47 +0700
Subject: [PATCH] Remove un-used variables

---
 .../components/com_config/src/Model/ApplicationModel.php       | 2 --
 .../components/com_messages/src/View/Messages/HtmlView.php     | 1 -
 .../components/com_scheduler/src/View/Logs/HtmlView.php        | 1 -
 .../components/com_templates/src/Model/TemplateModel.php       | 3 ---
 .../components/com_users/src/Controller/CallbackController.php | 2 --
 5 files changed, 9 deletions(-)

diff --git a/administrator/components/com_config/src/Model/ApplicationModel.php b/administrator/components/com_config/src/Model/ApplicationModel.php
index 3b23781eaf303..ee4e6de890bd9 100644
--- a/administrator/components/com_config/src/Model/ApplicationModel.php
+++ b/administrator/components/com_config/src/Model/ApplicationModel.php
@@ -786,8 +786,6 @@ public function save($data)
      */
     public function removeroot()
     {
-        $app = Factory::getApplication();
-
         // Get the previous configuration.
         $prev = new \JConfig();
         $prev = ArrayHelper::fromObject($prev);
diff --git a/administrator/components/com_messages/src/View/Messages/HtmlView.php b/administrator/components/com_messages/src/View/Messages/HtmlView.php
index b6ec48d0692b0..a03cc1fad8e51 100644
--- a/administrator/components/com_messages/src/View/Messages/HtmlView.php
+++ b/administrator/components/com_messages/src/View/Messages/HtmlView.php
@@ -117,7 +117,6 @@ public function display($tpl = null)
      */
     protected function addToolbar()
     {
-        $state = $this->state;
         $canDo = ContentHelper::getActions('com_messages');
         $user  = $this->getCurrentUser();
 
diff --git a/administrator/components/com_scheduler/src/View/Logs/HtmlView.php b/administrator/components/com_scheduler/src/View/Logs/HtmlView.php
index c898b70254f78..b1a23b35d04cc 100644
--- a/administrator/components/com_scheduler/src/View/Logs/HtmlView.php
+++ b/administrator/components/com_scheduler/src/View/Logs/HtmlView.php
@@ -111,7 +111,6 @@ public function display($tpl = null): void
     protected function addToolbar(): void
     {
         $canDo   = ContentHelper::getActions('com_scheduler');
-        $user    = Factory::getApplication()->getIdentity();
         $toolbar = Toolbar::getInstance();
 
         ToolbarHelper::title(Text::_('COM_SCHEDULER_FIELDSET_EXEC_HIST'), 'list');
diff --git a/administrator/components/com_templates/src/Model/TemplateModel.php b/administrator/components/com_templates/src/Model/TemplateModel.php
index 52fafd50b8b27..4f0a1724995e5 100644
--- a/administrator/components/com_templates/src/Model/TemplateModel.php
+++ b/administrator/components/com_templates/src/Model/TemplateModel.php
@@ -238,8 +238,6 @@ public function getCoreList()
         // Initialize the array variable to store core file list.
         $this->coreFileList = [];
 
-        $app = Factory::getApplication();
-
         foreach ($templates as $template) {
             $client  = ApplicationHelper::getClientInfo($template->client_id);
             $element = Path::clean($client->path . '/templates/' . $template->element . '/');
@@ -473,7 +471,6 @@ public function getDirectoryTree($dir)
      */
     public function getCoreFile($file, $client_id)
     {
-        $app          = Factory::getApplication();
         $filePath     = Path::clean($file);
         $explodeArray = explode(DIRECTORY_SEPARATOR, $filePath);
 
diff --git a/administrator/components/com_users/src/Controller/CallbackController.php b/administrator/components/com_users/src/Controller/CallbackController.php
index e58524965240e..f2c5075b10b1f 100644
--- a/administrator/components/com_users/src/Controller/CallbackController.php
+++ b/administrator/components/com_users/src/Controller/CallbackController.php
@@ -58,8 +58,6 @@ public function __construct(array $config = [], ?MVCFactoryInterface $factory =
      */
     public function callback($cachable = false, $urlparams = false): void
     {
-        $app = $this->app;
-
         // Get the Method and make sure it's non-empty
         $method = $this->input->getCmd('method', '');