[5.3] Use Null Coalescing Assignment Operator For Components

[joomdonation]

Pull Request for Issue # .

Summary of Changes

This PR uses NullCoalescingOperatorRector rector rule to improve components code using ??= operator. This is done automatically by rector, no manual change included.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner, easier to read code

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[richard67]

@joomdonation Could you fix the PHPCS issues listed here? https://ci.joomla.org/joomla/joomla-cms/82216/1/7

[joomdonation]

Done, thanks @richard67 . It's strange that our PHPCS has special treatment for ??= operator, not sure why it does not want to be aligned in the same way with = operator

[QuyTon]

I have tested this item ✅ successfully on 7045b5b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44878.}

[viocassel]

I have tested this item ✅ successfully on 7045b5b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44878.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44878.}

[HLeithner]

code style, and the line above is basically exact the same but is not converted?

[joomdonation]

I fixed that code style before, but our PHPCS does not allow it passed, so I had to revert the fix back. We have strange behavior with PHPCS for ??= operator here.

For the line above, if you are talking about the line $menuitem->class = $menuitem->img ?? '';, then it is not the same.

[HLeithner]

ok, then we can't merge this, until cs checker is fixed. (and yes you are right above is not the same)

[HLeithner]

Code style and missing conversations, please the the full pr for missing spaces.

thanks

[HLeithner]

thanks