Skip to content

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Jan 3, 2025

Followup Pull Request for Pull Request #42493 and comment #40788 (review) .

Summary of Changes

Fix assets hierarchy of scheduled tasks for new installations of Joomla

Testing Instructions

Check permissions for component com_scheduler

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

Title present and tasks are inherited from component (level 2)
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

(93, 1, 177, 178, 1, 'com_fields', 'com_fields', '{}'),
(94, 1, 179, 180, 1, 'com_workflow', 'com_workflow', '{}'),
(95, 1, 181, 182, 1, 'com_guidedtours', 'com_guidedtours', '{}'),
(96, 18, 130, 131, 2, 'com_modules.module.109', 'Guided Tours', '{}'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use localization keys here? All other extensions are translated to the default language.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's possible - it takes the title of the task itself when the task is saved

/**
* Method to return the title to use for the asset table.
*
* @return string
*
* @since 5.2.3
*/
protected function _getAssetTitle(): string
{
return $this->title;
}

It should be the same behavior like eg. modules (also not translated)
(67, 18, 76, 77, 2, 'com_modules.module.88', 'Latest Actions', '{}'),
(68, 18, 78, 79, 2, 'com_modules.module.89', 'Privacy Dashboard', '{}'),
(70, 18, 88, 89, 2, 'com_modules.module.103', 'Site', '{}'),
(71, 18, 92, 93, 2, 'com_modules.module.104', 'System', '{}'),
(72, 18, 96, 97, 2, 'com_modules.module.91', 'System Dashboard', '{}'),
(73, 18, 98, 99, 2, 'com_modules.module.92', 'Content Dashboard', '{}'),
(74, 18, 100, 101, 2, 'com_modules.module.93', 'Menus Dashboard', '{}'),
(75, 18, 102, 103, 2, 'com_modules.module.94', 'Components Dashboard', '{}'),
(76, 18, 104, 105, 2, 'com_modules.module.95', 'Users Dashboard', '{}'),
(77, 18, 106, 107, 2, 'com_modules.module.99', 'Frontend Link', '{}'),
(78, 18, 108, 109, 2, 'com_modules.module.100', 'Messages', '{}'),
(79, 18, 110, 111, 2, 'com_modules.module.101', 'Post Install Messages', '{}'),
(80, 18, 112, 113, 2, 'com_modules.module.102', 'User Status', '{}'),
(82, 18, 114, 115, 2, 'com_modules.module.105', '3rd Party', '{}'),
(83, 18, 116, 117, 2, 'com_modules.module.106', 'Help Dashboard', '{}'),
(84, 18, 118, 119, 2, 'com_modules.module.107', 'Privacy Requests', '{}'),
(85, 18, 120, 121, 2, 'com_modules.module.108', 'Privacy Status', '{}'),
(86, 18, 122, 123, 2, 'com_modules.module.96', 'Popular Articles', '{}'),
(87, 18, 124, 125, 2, 'com_modules.module.97', 'Recently Added Articles', '{}'),
(88, 18, 126, 127, 2, 'com_modules.module.98', 'Logged-in Users', '{}'),
(89, 18, 128, 129, 2, 'com_modules.module.90', 'Login Support', '{}'),

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on 413f3c5

works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44684.

@tecpromotion
Copy link
Contributor

tecpromotion commented Jan 4, 2025

Bildschirmfoto 2025-01-04 um 11 16 39

With new installation.

Download full package from: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.2-dev/44684/downloads/81126/


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44684.

@tecpromotion tecpromotion requested a review from Kostelano January 4, 2025 10:20
@ghost
Copy link

ghost commented Jan 4, 2025

I have tested this item ✅ successfully on 413f3c5

Before Pull Request After Pull Request
1 2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44684.

@alikon
Copy link
Contributor

alikon commented Jan 4, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44684.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 4, 2025
@pe7er pe7er self-assigned this Jan 9, 2025
@pe7er pe7er enabled auto-merge (squash) January 12, 2025 18:20
@pe7er pe7er added this to the Joomla! 5.2.4 milestone Jan 12, 2025
@pe7er pe7er merged commit 70b79ce into joomla:5.2-dev Jan 12, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 12, 2025
@pe7er
Copy link
Contributor

pe7er commented Jan 12, 2025

Thanks @heelc29 !

@heelc29 heelc29 deleted the 5.2/com_scheduler/assets branch January 19, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants