From f5b1ae5cdced92e366bf2d8f1adca7a0f816d792 Mon Sep 17 00:00:00 2001 From: Hannes Papenberg Date: Wed, 22 May 2024 13:04:27 +0200 Subject: [PATCH 1/3] Remove Toolbar::getInstance() from views --- .../com_actionlogs/src/View/Actionlogs/HtmlView.php | 2 +- .../components/com_admin/src/View/Sysinfo/HtmlView.php | 2 +- .../com_associations/src/View/Association/HtmlView.php | 2 +- .../com_associations/src/View/Associations/HtmlView.php | 2 +- .../components/com_banners/src/View/Banner/HtmlView.php | 2 +- .../components/com_banners/src/View/Banners/HtmlView.php | 2 +- .../components/com_banners/src/View/Client/HtmlView.php | 2 +- .../components/com_banners/src/View/Clients/HtmlView.php | 2 +- .../components/com_banners/src/View/Tracks/HtmlView.php | 2 +- .../components/com_cache/src/View/Cache/HtmlView.php | 2 +- .../com_categories/src/View/Categories/HtmlView.php | 2 +- .../components/com_categories/src/View/Category/HtmlView.php | 4 ++-- .../components/com_checkin/src/View/Checkin/HtmlView.php | 2 +- .../components/com_config/src/View/Application/HtmlView.php | 2 +- .../components/com_config/src/View/Component/HtmlView.php | 2 +- .../components/com_contact/src/View/Contact/HtmlView.php | 4 ++-- .../components/com_contact/src/View/Contacts/HtmlView.php | 2 +- .../components/com_content/src/View/Article/HtmlView.php | 4 ++-- .../components/com_content/src/View/Articles/HtmlView.php | 2 +- .../components/com_content/src/View/Featured/HtmlView.php | 2 +- .../components/com_cpanel/src/View/Cpanel/HtmlView.php | 2 +- .../components/com_fields/src/View/Field/HtmlView.php | 2 +- .../components/com_fields/src/View/Fields/HtmlView.php | 2 +- .../components/com_fields/src/View/Group/HtmlView.php | 2 +- .../components/com_fields/src/View/Groups/HtmlView.php | 2 +- .../components/com_finder/src/View/Filter/HtmlView.php | 2 +- .../components/com_finder/src/View/Filters/HtmlView.php | 2 +- .../components/com_finder/src/View/Index/HtmlView.php | 2 +- .../components/com_finder/src/View/Maps/HtmlView.php | 2 +- .../components/com_finder/src/View/Searches/HtmlView.php | 2 +- .../components/com_guidedtours/src/View/Steps/HtmlView.php | 2 +- .../components/com_guidedtours/src/View/Tours/HtmlView.php | 2 +- .../components/com_installer/src/View/Database/HtmlView.php | 2 +- .../components/com_installer/src/View/Discover/HtmlView.php | 2 +- .../components/com_installer/src/View/Install/HtmlView.php | 2 +- .../components/com_installer/src/View/Installer/HtmlView.php | 2 +- .../components/com_installer/src/View/Languages/HtmlView.php | 2 +- .../components/com_installer/src/View/Manage/HtmlView.php | 2 +- .../components/com_installer/src/View/Update/HtmlView.php | 2 +- .../components/com_installer/src/View/Updatesite/HtmlView.php | 2 +- .../com_installer/src/View/Updatesites/HtmlView.php | 2 +- .../components/com_installer/src/View/Warnings/HtmlView.php | 2 +- .../components/com_languages/src/View/Installed/HtmlView.php | 2 +- .../components/com_languages/src/View/Language/HtmlView.php | 2 +- .../components/com_languages/src/View/Languages/HtmlView.php | 2 +- .../components/com_languages/src/View/Override/HtmlView.php | 2 +- .../components/com_languages/src/View/Overrides/HtmlView.php | 2 +- .../components/com_mails/src/View/Template/HtmlView.php | 2 +- .../components/com_mails/src/View/Templates/HtmlView.php | 2 +- administrator/components/com_media/src/View/File/HtmlView.php | 2 +- .../components/com_media/src/View/Media/HtmlView.php | 2 +- administrator/components/com_menus/src/View/Item/HtmlView.php | 4 ++-- .../components/com_menus/src/View/Items/HtmlView.php | 2 +- administrator/components/com_menus/src/View/Menu/HtmlView.php | 2 +- .../components/com_menus/src/View/Menus/HtmlView.php | 2 +- .../components/com_menus/src/View/Menutypes/HtmlView.php | 2 +- .../components/com_messages/src/View/Config/HtmlView.php | 2 +- .../components/com_messages/src/View/Message/HtmlView.php | 2 +- .../components/com_messages/src/View/Messages/HtmlView.php | 2 +- .../components/com_modules/src/View/Module/HtmlView.php | 4 ++-- .../components/com_modules/src/View/Modules/HtmlView.php | 2 +- .../components/com_modules/src/View/Select/HtmlView.php | 2 +- .../components/com_newsfeeds/src/View/Newsfeed/HtmlView.php | 4 ++-- .../components/com_newsfeeds/src/View/Newsfeeds/HtmlView.php | 2 +- .../components/com_plugins/src/View/Plugin/HtmlView.php | 4 ++-- .../components/com_plugins/src/View/Plugins/HtmlView.php | 2 +- .../components/com_postinstall/src/View/Messages/HtmlView.php | 2 +- .../components/com_privacy/src/View/Capabilities/HtmlView.php | 2 +- .../components/com_privacy/src/View/Consents/HtmlView.php | 2 +- .../components/com_privacy/src/View/Request/HtmlView.php | 2 +- .../components/com_privacy/src/View/Requests/HtmlView.php | 2 +- .../components/com_redirect/src/View/Link/HtmlView.php | 2 +- .../components/com_redirect/src/View/Links/HtmlView.php | 2 +- .../components/com_scheduler/src/View/Select/HtmlView.php | 2 +- .../components/com_scheduler/src/View/Task/HtmlView.php | 2 +- .../components/com_scheduler/src/View/Tasks/HtmlView.php | 2 +- administrator/components/com_tags/src/View/Tag/HtmlView.php | 2 +- administrator/components/com_tags/src/View/Tags/HtmlView.php | 2 +- .../components/com_templates/src/View/Style/HtmlView.php | 2 +- .../components/com_templates/src/View/Styles/HtmlView.php | 2 +- .../components/com_templates/src/View/Template/HtmlView.php | 2 +- .../components/com_templates/src/View/Templates/HtmlView.php | 2 +- .../components/com_users/src/View/Captive/HtmlView.php | 2 +- .../components/com_users/src/View/Debuggroup/HtmlView.php | 2 +- .../components/com_users/src/View/Debuguser/HtmlView.php | 2 +- .../components/com_users/src/View/Group/HtmlView.php | 2 +- .../components/com_users/src/View/Groups/HtmlView.php | 2 +- .../components/com_users/src/View/Level/HtmlView.php | 2 +- .../components/com_users/src/View/Levels/HtmlView.php | 2 +- administrator/components/com_users/src/View/Mail/HtmlView.php | 2 +- .../components/com_users/src/View/Method/HtmlView.php | 2 +- .../components/com_users/src/View/Methods/HtmlView.php | 2 +- administrator/components/com_users/src/View/Note/HtmlView.php | 2 +- .../components/com_users/src/View/Notes/HtmlView.php | 2 +- administrator/components/com_users/src/View/User/HtmlView.php | 2 +- .../components/com_users/src/View/Users/HtmlView.php | 2 +- .../components/com_workflow/src/View/Stage/HtmlView.php | 2 +- .../components/com_workflow/src/View/Stages/HtmlView.php | 2 +- .../components/com_workflow/src/View/Transition/HtmlView.php | 2 +- .../components/com_workflow/src/View/Transitions/HtmlView.php | 2 +- .../components/com_workflow/src/View/Workflow/HtmlView.php | 2 +- .../components/com_workflow/src/View/Workflows/HtmlView.php | 2 +- libraries/src/MVC/View/ListView.php | 2 +- 103 files changed, 110 insertions(+), 110 deletions(-) diff --git a/administrator/components/com_actionlogs/src/View/Actionlogs/HtmlView.php b/administrator/components/com_actionlogs/src/View/Actionlogs/HtmlView.php index 9084f4eab2005..5990911d16532 100644 --- a/administrator/components/com_actionlogs/src/View/Actionlogs/HtmlView.php +++ b/administrator/components/com_actionlogs/src/View/Actionlogs/HtmlView.php @@ -134,7 +134,7 @@ public function display($tpl = null) protected function addToolbar() { ToolbarHelper::title(Text::_('COM_ACTIONLOGS_MANAGER_USERLOGS'), 'icon-list-2'); - $toolbar = Toolbar::getInstance(); + $toolbar = $this->getDocument()->getToolbar(); $toolbar->standardButton('download', 'COM_ACTIONLOGS_EXPORT_CSV', 'actionlogs.exportSelectedLogs') ->icon('icon-download') diff --git a/administrator/components/com_admin/src/View/Sysinfo/HtmlView.php b/administrator/components/com_admin/src/View/Sysinfo/HtmlView.php index 3ef5b7c049c95..15dcc6d8fa25f 100644 --- a/administrator/components/com_admin/src/View/Sysinfo/HtmlView.php +++ b/administrator/components/com_admin/src/View/Sysinfo/HtmlView.php @@ -111,7 +111,7 @@ public function display($tpl = null): void protected function addToolbar(): void { ToolbarHelper::title(Text::_('COM_ADMIN_SYSTEM_INFORMATION'), 'info-circle systeminfo'); - $toolbar = Toolbar::getInstance(); + $toolbar = $this->getDocument()->getToolbar(); $toolbar->linkButton('download', 'COM_ADMIN_DOWNLOAD_SYSTEM_INFORMATION_TEXT') ->url(Route::_('index.php?option=com_admin&view=sysinfo&format=text&' . Session::getFormToken() . '=1')); diff --git a/administrator/components/com_associations/src/View/Association/HtmlView.php b/administrator/components/com_associations/src/View/Association/HtmlView.php index 7692b18599956..1787aa4eee37b 100644 --- a/administrator/components/com_associations/src/View/Association/HtmlView.php +++ b/administrator/components/com_associations/src/View/Association/HtmlView.php @@ -358,7 +358,7 @@ protected function addToolbar(): void 'language assoc' ); - $toolbar = Toolbar::getInstance(); + $toolbar = $this->getDocument()->getToolbar(); $toolbar->customButton('reference') ->html('