[5.0] Update deleted files list in script.php for 5.0.0-beta3 #41928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
sorry for the errors |
Member
Author
@brianteeman No need for sorry. Can happen to anyone. |
Contributor
|
Still good practice to acknowledge it |
Member
Author
Yes, of course good to know you noticed. |
richard67
changed the title
Member
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Add deleted files from recent changes to the list of files to be deleted on update in script.php.
I don't see any other PRs in the pipeline in 4.4-dev and 5.0-dev which could cause deleted files and folders, so I think this is ready to go.
Testing Instructions
Code review.
Or update from a current 4.4-dev branch or latest 4.4.0-beta3-dev nightly or a 4.4.0-beta2 to the latest 5.0.0-beta3-dev nightly for the actual result and to the patched update package or custom update URL created by Drone for this PR for the expected result.
Actual result BEFORE applying this Pull Request
Gzipped media files mentioned in the description above have not been deleted with the update.
File "administrator/components/com_admin/script.php" contains a typo "/media/system/css/mootree_rtl,min.css" (with comma), so the "/media/system/css/mootree_rtl.min.css" (with dot) has also not been deleted.
Expected result AFTER applying this Pull Request
Gzipped media files mentioned in the description above have been deleted with the update.
File "/media/system/css/mootree_rtl.min.css" has also been deleted.
File "administrator/components/com_admin/script.php" doesn't contain typo "/media/system/css/mootree_rtl,min.css".
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed