-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.0] Update composer dependencies. Especially Webauthn-lib #41862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
More information can be found at PHP-CS-Fixer/PHP-CS-Fixer#7179
|
PR seems to break webauthn/passkeys |
|
Try to change version to 4.5, as on their documentation it is latest https://webauthn-doc.spomky-labs.com/the-project/the-project |
|
ok, downgraded to 4.5.2 |
* remove track_errors * cs * Revert $fileName and weird stringified key access
* Fix user group deletion events compatibility * Fix user group deletion events compatibility * Fix user group deletion events compatibility * Fix user group deletion events compatibility --------- Co-authored-by: Harald Leithner <[email protected]>
* Fix ShowOnRule failing for "not empty" rule * Fix wrong split criteria for "and" and "or" * Allow comma-separated value list * Add missing brackets around "|" expression * Add missing begin and end of string anchors * Remove useless "i" modifier as it is not needed * add unit test * Fix line ending - should be Unix not Windows * A few more unit test cases * Allow dashes in field names * Allow any kind of character in field values --------- Co-authored-by: Christian Heel <[email protected]>
Co-authored-by: Quy <[email protected]>
# Conflicts: # composer.lock
|
I have tested this item ✅ successfully on 26a418c I've successfully tested that this method works for both the primary login and the MFA on a new installation made with the branch of this PR, and I have also tested that primary login and MFA with this method set up on a 4.4-dev still work after updating to the patched package for this PR. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41862. |
|
I have tested this item ✅ successfully on 26a418c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41862. |
Summary of Changes
Updating weak dependencies and Webauthn-lib from 4.3.0 to 4.5.2
Testing Instructions
Test all Variant of Webauthn/Passkeys
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Additional
Webauthn plugin needs to be updated because of many new deprecation in the upstream library