Skip to content

Conversation

@HLeithner
Copy link
Member

@HLeithner HLeithner commented Sep 22, 2023

Summary of Changes

Updating weak dependencies and Webauthn-lib from 4.3.0 to 4.5.2

Testing Instructions

Test all Variant of Webauthn/Passkeys

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Additional

Webauthn plugin needs to be updated because of many new deprecation in the upstream library

@HLeithner HLeithner marked this pull request as draft September 23, 2023 19:13
@HLeithner
Copy link
Member Author

PR seems to break webauthn/passkeys

@Fedik
Copy link
Member

Fedik commented Sep 25, 2023

Try to change version to 4.5, as on their documentation it is latest https://webauthn-doc.spomky-labs.com/the-project/the-project
4.7 probably some transition stuff on the way to 5.0, there no docs about it.

@HLeithner
Copy link
Member Author

ok, downgraded to 4.5.2

HLeithner and others added 12 commits September 25, 2023 11:14
* remove track_errors

* cs

* Revert $fileName and weird stringified key access
* Fix user group deletion events compatibility

* Fix user group deletion events compatibility

* Fix user group deletion events compatibility

* Fix user group deletion events compatibility

---------

Co-authored-by: Harald Leithner <[email protected]>
* Fix ShowOnRule failing for "not empty" rule

* Fix wrong split criteria for "and" and "or"

* Allow comma-separated value list

* Add missing brackets around "|" expression

* Add missing begin and end of string anchors

* Remove useless "i" modifier as it is not needed

* add unit test

* Fix line ending - should be Unix not Windows

* A few more unit test cases

* Allow dashes in field names

* Allow any kind of character in field values

---------

Co-authored-by: Christian Heel <[email protected]>
@HLeithner HLeithner marked this pull request as ready for review September 26, 2023 10:57
@richard67
Copy link
Member

I have tested this item ✅ successfully on 26a418c

Unfortunately I have only one Webauthn method available, the Windows Hello PIN.

I've successfully tested that this method works for both the primary login and the MFA on a new installation made with the branch of this PR, and I have also tested that primary login and MFA with this method set up on a 4.4-dev still work after updating to the patched package for this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41862.

@HLeithner
Copy link
Member Author

I have tested this item ✅ successfully on 26a418c

tested both 2FA and Passkeys with hardware key on linux with vivaldi.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41862.

@HLeithner HLeithner merged commit 3af3fff into joomla:5.0-dev Sep 26, 2023
@HLeithner HLeithner deleted the 5.0/depupdate/230922 branch September 26, 2023 11:24
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
HLeithner pushed a commit that referenced this pull request Sep 26, 2023
* Add missing section comment

* Add gzipped media files forgotten with PR #41870

* Remove wrong file from PR #41870

* Add deleted files and folders from PR #41862

* Descending order for folders! Silly me.
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants