[5.0] %s for strings/floats in sprintf #41740
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #41710 .
Summary of Changes
revert parts from #41710
@brianteeman @HLeithner
com_finder: uses
number_formatjoomla-cms/administrator/components/com_finder/tmpl/statistics/default.php
Line 18 in d3589c9
plg_content_vote: is float
joomla-cms/plugins/content/vote/tmpl/rating.php
Lines 53 to 58 in d3589c9
finderindex: uses round
joomla-cms/libraries/src/Console/FinderIndexCommand.php
Line 403 in d3589c9
Testing Instructions
com_finder/statistics: values above 1000
plg_content_vote: two votes (5+4)/2=4.5
finderindex: run cli/joomla.php findex:index
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select: