Skip to content

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Apr 13, 2023

Pull Request for Issue #40271 .
@obuisard Issue is a Release Blocker

Summary of Changes

run build/helpTOC.php

New entries:

Renamed (because they are redirects):

Old New
Articles: New or Edit Category Articles: Edit Category
Component: Field Groups Field Groups
Component: Fields Fields
Component: New or Edit Field Fields: Edit
Component: New or Edit Field Group Field Groups: Edit
Contacts: New or Edit Contacts: Edit
Contacts: New or Edit Category Contacts: Edit Category
News Feeds: New or Edit News Feeds: Edit
News Feeds: New or Edit Category News Feeds: Edit Category

Testing Instructions

Check entries are present (administrator/index.php?option=com_admin&view=help)

Note: help links are still failing at the moment (see #39818)

Actual result BEFORE applying this Pull Request

No links for Guided Tours in help site

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

Restored old entries (because they are redirects and new language strings are needed to replace them):

Could you explain this please

@heelc29
Copy link
Contributor Author

heelc29 commented Apr 13, 2023

Could you explain this please

Sure, the docs sites for these keys are redirections (to still valid help pages) and so will be not found by the build tool.
If the target of the reditection should be find by the build tool we have to replace the language strings in com_admin (but not 1 week before release). So I manually copy these keys back in the json file.

@brianteeman
Copy link
Contributor

I thought that is what you might mean :(

Up to the release leads but I would not be in favour of this approach. The script should build the json file correctly. If that means changes then so be it. We shouldn't use such hacky approaches as this just because of the date.

@bembelimen
Copy link
Contributor

Thanks for this PR, this is something we neclected for the past releases.
As we're too close to the release to get this into 4.3.0 we have now 5 weeks to get it in the clean way for 4.3.1.

@heelc29
Copy link
Contributor Author

heelc29 commented Apr 14, 2023

Ok, I will update this PR

@heelc29
Copy link
Contributor Author

heelc29 commented Apr 14, 2023

One question: is there a reason why the json file is not pretty formatted, this would help at code review?

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Apr 19, 2023
@obuisard
Copy link
Contributor

obuisard commented May 6, 2023

@heelc29 any update on this PR (it was suggested, that a script should build toc.json, but not be done manually)? Do you need any help with that?

@heelc29
Copy link
Contributor Author

heelc29 commented May 6, 2023

@obuisard I've added the language keys (for the moved doc pages) and the toc.json is generated now by the script (and not adjusted afterwards). So the PR should be ready to test.

@obuisard
Copy link
Contributor

obuisard commented May 6, 2023

@obuisard I've added the language keys (for the moved doc pages) and the toc.json is generated now by the script (and not adjusted afterwards). So the PR should be ready to test.

Wonderful, thanks! I will ask for help with testing.

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on b34dc36


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40377.

@brianteeman
Copy link
Contributor

Almost but not quite

image

@heelc29
Copy link
Contributor Author

heelc29 commented May 7, 2023

Almost but not quite

Seems @ceford moved page Help4.x:Guided Tours: Tours to Help4.x:Guided Tours 😉

@heelc29
Copy link
Contributor Author

heelc29 commented May 7, 2023

PR updated 👍

@obuisard obuisard added this to the Joomla! 4.3.2 milestone May 8, 2023
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 40ded6a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40377.

@richard67
Copy link
Member

I have tested this item ✅ successfully on c8e3550


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40377.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 4.3.2 milestone May 14, 2023
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40377.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 14, 2023
@richard67 richard67 added this to the Joomla! 4.3.2 milestone May 14, 2023
@obuisard obuisard merged commit e744f23 into joomla:4.3-dev May 14, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 14, 2023
@obuisard
Copy link
Contributor

Thank you @heelc29 for the PR!

@heelc29 heelc29 deleted the 4.3/help-toc branch May 20, 2023 18:01
Kostelano added a commit to JPathRu/localisation that referenced this pull request Jun 1, 2023
В Joomla 4.3.1 не было изменений в локализации.

Новое в Joomla 4.3.2 Stable
joomla/joomla-cms#40258 +
joomla/joomla-cms#40266 - (только для en-GB)
joomla/joomla-cms#40471 - (только для en-GB)
joomla/joomla-cms#40304 +
joomla/joomla-cms#40401 - (только для en-GB)
joomla/joomla-cms#40299 - (только для en-GB)
joomla/joomla-cms#40539 +
joomla/joomla-cms#40377 +
joomla/joomla-cms@0b162d3 + (коммит без PR)
+ другие мелкие исправления
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants