-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.3] update help toc #40377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] update help toc #40377
Conversation
Could you explain this please |
Sure, the docs sites for these keys are redirections (to still valid help pages) and so will be not found by the build tool. |
|
I thought that is what you might mean :( Up to the release leads but I would not be in favour of this approach. The script should build the json file correctly. If that means changes then so be it. We shouldn't use such hacky approaches as this just because of the date. |
|
Thanks for this PR, this is something we neclected for the past releases. |
|
Ok, I will update this PR |
|
One question: is there a reason why the json file is not pretty formatted, this would help at code review? |
|
@heelc29 any update on this PR (it was suggested, that a script should build toc.json, but not be done manually)? Do you need any help with that? |
|
@obuisard I've added the language keys (for the moved doc pages) and the toc.json is generated now by the script (and not adjusted afterwards). So the PR should be ready to test. |
Wonderful, thanks! I will ask for help with testing. |
|
I have tested this item 🔴 unsuccessfully on b34dc36 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40377. |
Seems @ceford moved page |
|
PR updated 👍 |
|
I have tested this item ✅ successfully on 40ded6a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40377. |
|
I have tested this item ✅ successfully on c8e3550 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40377. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40377. |
|
Thank you @heelc29 for the PR! |
В Joomla 4.3.1 не было изменений в локализации. Новое в Joomla 4.3.2 Stable joomla/joomla-cms#40258 + joomla/joomla-cms#40266 - (только для en-GB) joomla/joomla-cms#40471 - (только для en-GB) joomla/joomla-cms#40304 + joomla/joomla-cms#40401 - (только для en-GB) joomla/joomla-cms#40299 - (только для en-GB) joomla/joomla-cms#40539 + joomla/joomla-cms#40377 + joomla/joomla-cms@0b162d3 + (коммит без PR) + другие мелкие исправления

Pull Request for Issue #40271 .
@obuisard Issue is a Release Blocker
Summary of Changes
run
build/helpTOC.phpNew entries:
Renamed (because they are redirects):
Testing Instructions
Check entries are present (administrator/index.php?option=com_admin&view=help)
Note: help links are still failing at the moment (see #39818)Actual result BEFORE applying this Pull Request
No links for
Guided Toursin help siteExpected result AFTER applying this Pull Request
Link to documentations
Please select: