Skip to content

Conversation

@charvimehradu
Copy link
Contributor

Pull Request for adding cypress test for banners.

@rajputanuj31 @laoneo helped a lot thankyou!

@charvimehradu charvimehradu changed the base branch from 4.3-dev to 4.4-dev March 23, 2023 19:43
@laoneo
Copy link
Member

laoneo commented Mar 23, 2023

There are still some cs issues and can you rename the file to Default.cy.js.

@charvimehradu charvimehradu requested a review from laoneo March 23, 2023 22:14
@Quy Quy removed the PR-4.3-dev label Mar 24, 2023
@laoneo laoneo merged commit a9c3775 into joomla:4.4-dev Mar 24, 2023
@laoneo
Copy link
Member

laoneo commented Mar 24, 2023

Thanks a lot!

@laoneo laoneo added this to the Joomla! 4.4.0 milestone Mar 24, 2023
@charvimehradu
Copy link
Contributor Author

Glad I could help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants