[5.0] Migrating from Joomla\CMS\Filesystem\Path to Joomla\Filesystem\Path #40127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hackwar
requested review from
HLeithner,
bembelimen,
rdeutz and
zero-24
as code owners
4 tasks
laoneo
approved these changes
Apr 6, 2023
Member
|
I reviewed some of the files and only functions are used which are basically the same like |
Hackwar
changed the title
….4-filesystem-path # Conflicts: # libraries/src/Form/Field/ComponentlayoutField.php # libraries/src/Form/Field/ModulelayoutField.php # libraries/src/MVC/Model/BaseModel.php # plugins/system/languagefilter/src/Extension/LanguageFilter.php
Member
|
can you resolve the conflict please, then I can merge this |
Member
Author
|
done |
Member
|
I did a full review on all usages and it looks ok, thanks |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In the process of deprecating the CMS Filesystem package (see #40111), this PR changes all usages of
Joomla\CMS\Filesystem\PathtoJoomla\Filesystem\Path. These 2 classes are almost completely identical, except for one case:Path::clean()in the CMS class usesUnexpectedValueExceptionwhen the input is not a string, while the Filesystem Path class usesInvalidArgumentException. All other cases where an exception is thrown, the exception in the framework class inherits from the genericExceptionwhich we use in the CMS class. So this is 100% compatible.While this PR migrates away from the CMS class, #40104 removes most of the old code.
Testing Instructions
Codereview
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed