From adcbd0a28f728ae4c13ca685644df704eee6ed7c Mon Sep 17 00:00:00 2001 From: Allon Moritz Date: Mon, 13 Mar 2023 16:47:07 +0100 Subject: [PATCH 1/3] Do not log to console in tours js --- build/media_source/plg_system_guidedtours/js/guidedtours.es6.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/media_source/plg_system_guidedtours/js/guidedtours.es6.js b/build/media_source/plg_system_guidedtours/js/guidedtours.es6.js index 04dd5e328f662..aa5135ae5aedb 100644 --- a/build/media_source/plg_system_guidedtours/js/guidedtours.es6.js +++ b/build/media_source/plg_system_guidedtours/js/guidedtours.es6.js @@ -98,7 +98,7 @@ function addStepToTourButton(tour, stepObj, buttons) { resolve(); } }).catch((error) => { - console.log(`Exception error - ${error.message} - Bypass Shepherd target`); + throw new Error(`Exception error - ${error.message} - Bypass Shepherd target`); }); }, when: { From 9d3e58e46c724a4572eb320b36c9ea545dbdda1f Mon Sep 17 00:00:00 2001 From: Allon Moritz Date: Sat, 18 Mar 2023 10:57:29 +0100 Subject: [PATCH 2/3] resolve promise --- .../media_source/plg_system_guidedtours/js/guidedtours.es6.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build/media_source/plg_system_guidedtours/js/guidedtours.es6.js b/build/media_source/plg_system_guidedtours/js/guidedtours.es6.js index aa5135ae5aedb..9c90eb1527f74 100644 --- a/build/media_source/plg_system_guidedtours/js/guidedtours.es6.js +++ b/build/media_source/plg_system_guidedtours/js/guidedtours.es6.js @@ -97,8 +97,8 @@ function addStepToTourButton(tour, stepObj, buttons) { } else { resolve(); } - }).catch((error) => { - throw new Error(`Exception error - ${error.message} - Bypass Shepherd target`); + }).catch(() => { + resolve(); }); }, when: { From eb5eb580cb4046a0cbed318360b907e6e77a440c Mon Sep 17 00:00:00 2001 From: Allon Moritz Date: Sat, 18 Mar 2023 11:08:40 +0100 Subject: [PATCH 3/3] ignore --- build/media_source/plg_system_guidedtours/js/guidedtours.es6.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/media_source/plg_system_guidedtours/js/guidedtours.es6.js b/build/media_source/plg_system_guidedtours/js/guidedtours.es6.js index 9c90eb1527f74..5e094883d6651 100644 --- a/build/media_source/plg_system_guidedtours/js/guidedtours.es6.js +++ b/build/media_source/plg_system_guidedtours/js/guidedtours.es6.js @@ -98,7 +98,7 @@ function addStepToTourButton(tour, stepObj, buttons) { resolve(); } }).catch(() => { - resolve(); + // Ignore }); }, when: {