[4.2] module position string #39924
Merged
[4.2] module position string #39924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong string was being used in the dropdown to select a module position
Contributor
|
Also @todo on other places:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39924. |
Contributor
Author
|
unrelated to module position. will be addressed in a dedicated pr |
Contributor
|
I have tested this item ✅ successfully on 5448539 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39924. |
2 similar comments
Contributor
|
I have tested this item ✅ successfully on 5448539 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39924. |
Contributor
|
I have tested this item ✅ successfully on 5448539 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39924. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39924. |
Contributor
|
Way better. Thanks! |
Contributor
Author
|
thx |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Mar 11, 2023
joomla/joomla-cms#39907 + joomla/joomla-cms#39705 + joomla/joomla-cms#39924 - (только для en-GB) joomla/joomla-cms#39930 - (только для en-GB) joomla/joomla-cms#39923 - (только для en-GB) joomla/joomla-cms#39205 +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong string was being used in the dropdown to select a module position
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed