Skip to content

Conversation

@astridx
Copy link
Contributor

@astridx astridx commented Feb 11, 2023

cypress.config.js was removed from package in #39478
Then the file was renamed in #39722

@wilsonge
Copy link
Contributor

If this is in the beta release then we’ll need to add it to the delete files script too

@richard67
Copy link
Member

If this is in the beta release then we’ll need to add it to the delete files script too

@wilsonge Yes, even before beta we did that. But we do not bother authors of pull requests with that. Instead, I regularly do that before each release since alpha 1 :-)

@richard67
Copy link
Member

richard67 commented Feb 12, 2023

@wilsonge P.S.: Or did you mean the cleanup step in build.php so it does not go into packages? silly me, that’s what this PR does.

@richard67
Copy link
Member

richard67 commented Feb 12, 2023

It seems the preparation step for the system tests is failing in drone because cypress wants to use the file which with this PR is removed from the build. @Hackwar could you have a look on that? Does it need to change something in drone.xml, too?
Update: False alarm. Branch update has fixed it.

@richard67
Copy link
Member

Will update the branch, maybe this helps with drone.

@laoneo laoneo merged commit 8a1a181 into joomla:4.3-dev Feb 13, 2023
@laoneo
Copy link
Member

laoneo commented Feb 13, 2023

Thanks!

@laoneo laoneo added this to the Joomla! 4.3.0 milestone Feb 13, 2023
@astridx astridx deleted the cypress.config branch April 26, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants