-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fix PluginHelper::getLayoutPath to work in non Web context, like Cli, Api #39550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think |
|
@Fedik Have you mixed up actual and expected result in the description? Or is it just me not understanding why expected result is error and actual result is it works? |
Yeap, that was me 😄 |
|
I have tested this item ✅ successfully on a4a0338 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39550. |
1 similar comment
|
I have tested this item ✅ successfully on a4a0338 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39550. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39550. |
|
This pull request has been automatically rebased to 4.3-dev. |
Added spaces
|
Thanks Fedir @Fedik for this PR :-) |
Fix for stuff like #38222 and #38214 .
Summary of Changes
Prevent crashing of plugin renderers in non Web context
Testing Instructions
Have to apply all PR, this one, then #38585 then #38650
Then run test from #38650
Actual result BEFORE applying this Pull Request
Error
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed