Skip to content

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Jan 3, 2023

Fix for stuff like #38222 and #38214 .

Summary of Changes

Prevent crashing of plugin renderers in non Web context

Testing Instructions

Have to apply all PR, this one, then #38585 then #38650
Then run test from #38650

Actual result BEFORE applying this Pull Request

Error

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Fedik
Copy link
Member Author

Fedik commented Jan 3, 2023

I think PluginHelper::getLayoutPath we should deprecate to remove in 6.x, in favor of use layout

@richard67
Copy link
Member

@Fedik Have you mixed up actual and expected result in the description? Or is it just me not understanding why expected result is error and actual result is it works?

@Fedik
Copy link
Member Author

Fedik commented Jan 3, 2023

Have you mixed up actual and expected result in the description?

Yeap, that was me 😄

@Hackwar Hackwar added the Small A PR which only has a small change label Feb 26, 2023
@carlitorweb
Copy link
Member

For next tester, to reproduce the error go to the terminal and type: php cli/joomla.php finder:index

As result you will get:
Captura

I not sure if through the administrator the mass indexer in the smart search component need throw an error, was not my case.

@carlitorweb
Copy link
Member

I have tested this item ✅ successfully on a4a0338


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39550.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on a4a0338


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39550.

@richard67 richard67 removed the Small A PR which only has a small change label Mar 21, 2023
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39550.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 21, 2023
@Hackwar Hackwar added the bug label Apr 7, 2023
@HLeithner HLeithner changed the base branch from 4.2-dev to 4.3-dev May 2, 2023 16:29
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 4.3-dev.

@obuisard obuisard added this to the Joomla! 4.3.2 milestone May 5, 2023
@obuisard obuisard merged commit 35d330c into joomla:4.3-dev May 5, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 5, 2023
@obuisard
Copy link
Contributor

obuisard commented May 5, 2023

Thanks Fedir @Fedik for this PR :-)

@Fedik Fedik deleted the fix-plg-layout-cli branch May 5, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants