Skip to content

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Dec 22, 2022

Summary of Changes

It is not necessary that cypress.config.js is included in the package

Testing Instructions

Check if prebuilt packages contain the mentioned file

Actual result BEFORE applying this Pull Request

Joomla! 4.3 Nightly Builds
image

Expected result AFTER applying this Pull Request

Prebuilt package of this Pull Request
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@richard67 Is it necessary to add this file to com_admin/script.php since alpha1 has already been released?

@richard67
Copy link
Member

@richard67 Is it necessary to add this file to com_admin/script.php since alpha1 has already been released?

@heelc29 Yes, but not with this pull request. I care for that, and I regularly do that after the relevant pull requests have been merged and before the release after that with use of a tool.

@brianteeman
Copy link
Contributor

@richard67 not this time. the pull request is correct

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 253e343


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39478.

@richard67
Copy link
Member

@richard67 not this time. the pull request is correct

@brianteeman I haven’t said the pull request is not correct. I have only said there is no need to care about deleted files in script.php because I will do that. My tool will show me if there is something to be done or not.

@brianteeman
Copy link
Contributor

sorry @richard67 missed that part

@ReLater
Copy link
Contributor

ReLater commented Dec 24, 2022

I have tested this item ✅ successfully on 253e343


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39478.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39478.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 24, 2022
@wilsonge wilsonge merged commit e973f45 into joomla:4.3-dev Dec 24, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 24, 2022
@wilsonge wilsonge added this to the Joomla! 4.3.0 milestone Dec 24, 2022
@heelc29 heelc29 deleted the 4.3/package branch December 26, 2022 19:58
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 30, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants