-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.3] Remove cypress.config.js from package #39478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@heelc29 Yes, but not with this pull request. I care for that, and I regularly do that after the relevant pull requests have been merged and before the release after that with use of a tool. |
|
@richard67 not this time. the pull request is correct |
|
I have tested this item ✅ successfully on 253e343 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39478. |
@brianteeman I haven’t said the pull request is not correct. I have only said there is no need to care about deleted files in script.php because I will do that. My tool will show me if there is something to be done or not. |
|
sorry @richard67 missed that part |
|
I have tested this item ✅ successfully on 253e343 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39478. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39478. |
Summary of Changes
It is not necessary that
cypress.config.jsis included in the packageTesting Instructions
Check if prebuilt packages contain the mentioned file
Actual result BEFORE applying this Pull Request
Joomla! 4.3 Nightly Builds

Expected result AFTER applying this Pull Request
Prebuilt package of this Pull Request

Link to documentations
Please select:
@richard67 Is it necessary to add this file to
com_admin/script.phpsince alpha1 has already been released?