From 4808c6b0000a0a17be538b4b5282106b65d329a3 Mon Sep 17 00:00:00 2001 From: Allon Moritz Date: Sat, 22 Oct 2022 16:17:08 +0200 Subject: [PATCH 1/3] Change application input access to getInput --- .../com_admin/src/Model/HelpModel.php | 4 +- .../layouts/joomla/searchtools/default.php | 4 +- .../src/Field/ItemlanguageField.php | 2 +- .../src/Field/Modal/AssociationField.php | 2 +- .../src/Model/AssociationsModel.php | 6 +-- .../src/View/Association/HtmlView.php | 4 +- .../src/View/Associations/HtmlView.php | 2 +- .../tmpl/association/edit.php | 2 +- .../tmpl/associations/modal.php | 6 +-- .../com_banners/src/Model/BannerModel.php | 4 +- .../com_banners/src/Model/DownloadModel.php | 2 +- .../com_banners/src/View/Banner/HtmlView.php | 2 +- .../com_banners/src/View/Client/HtmlView.php | 2 +- .../src/Dispatcher/Dispatcher.php | 2 +- .../src/Field/CategoryeditField.php | 2 +- .../src/Field/Modal/CategoryField.php | 2 +- .../src/Model/CategoriesModel.php | 4 +- .../src/Model/CategoryModel.php | 30 +++++++------- .../src/View/Categories/HtmlView.php | 2 +- .../src/View/Category/HtmlView.php | 6 +-- .../com_categories/tmpl/categories/modal.php | 4 +- .../com_categories/tmpl/category/edit.php | 2 +- .../com_config/src/Model/ApplicationModel.php | 12 +++--- .../com_config/src/Model/ComponentModel.php | 2 +- .../src/View/Component/HtmlView.php | 4 +- .../com_contact/src/Model/ContactModel.php | 4 +- .../com_contact/src/Model/ContactsModel.php | 4 +- .../com_contact/src/View/Contact/HtmlView.php | 4 +- .../src/View/Contacts/HtmlView.php | 2 +- .../com_contact/tmpl/contact/edit.php | 2 +- .../com_contact/tmpl/contacts/modal.php | 6 +-- .../com_content/src/Model/ArticleModel.php | 14 +++---- .../com_content/src/Model/ArticlesModel.php | 14 +++---- .../com_content/src/View/Article/HtmlView.php | 4 +- .../src/View/Articles/HtmlView.php | 2 +- .../com_content/tmpl/article/edit.php | 2 +- .../com_content/tmpl/article/pagebreak.php | 2 +- .../com_content/tmpl/articles/modal.php | 6 +-- .../src/Model/CompareModel.php | 2 +- .../src/Model/HistoryModel.php | 4 +- .../src/Model/PreviewModel.php | 2 +- .../com_cpanel/src/View/Cpanel/HtmlView.php | 2 +- .../com_fields/src/Helper/FieldsHelper.php | 4 +- .../com_fields/src/Model/FieldModel.php | 24 +++++------ .../com_fields/src/Model/FieldsModel.php | 4 +- .../com_fields/src/Model/GroupModel.php | 12 +++--- .../com_fields/src/View/Field/HtmlView.php | 2 +- .../com_fields/src/View/Group/HtmlView.php | 2 +- .../components/com_fields/tmpl/field/edit.php | 2 +- .../com_fields/tmpl/fields/modal.php | 2 +- .../components/com_fields/tmpl/group/edit.php | 2 +- .../com_finder/src/Indexer/Query.php | 2 +- .../com_finder/src/Service/HTML/Filter.php | 2 +- .../com_finder/src/Service/HTML/Query.php | 2 +- .../com_finder/src/View/Filter/HtmlView.php | 2 +- .../com_finder/tmpl/filter/edit.php | 2 +- .../com_installer/src/Model/DiscoverModel.php | 2 +- .../com_installer/src/Model/InstallModel.php | 10 ++--- .../src/View/Updatesite/HtmlView.php | 2 +- .../src/Model/UpdateModel.php | 2 +- .../src/View/Update/HtmlView.php | 2 +- .../com_languages/src/Model/LanguageModel.php | 2 +- .../com_languages/src/Model/OverrideModel.php | 2 +- .../com_languages/src/Model/StringsModel.php | 2 +- .../src/View/Language/HtmlView.php | 2 +- .../src/View/Override/HtmlView.php | 2 +- .../com_login/src/Model/LoginModel.php | 2 +- .../com_mails/src/Model/TemplateModel.php | 4 +- .../com_mails/src/View/Template/HtmlView.php | 2 +- .../com_mails/tmpl/template/edit.php | 2 +- .../com_media/src/Model/ApiModel.php | 2 +- .../com_media/src/View/File/HtmlView.php | 2 +- .../com_media/src/View/Media/HtmlView.php | 4 +- .../com_media/tmpl/file/default.php | 2 +- .../com_media/tmpl/media/default.php | 2 +- .../layouts/joomla/menu/edit_modules.php | 2 +- .../src/Field/MenuItemByTypeField.php | 2 +- .../com_menus/src/Model/ItemModel.php | 18 ++++----- .../com_menus/src/Model/ItemsModel.php | 22 +++++----- .../com_menus/src/Model/MenuModel.php | 2 +- .../com_menus/src/Model/MenutypesModel.php | 2 +- .../com_menus/src/View/Item/HtmlView.php | 4 +- .../com_menus/src/View/Items/HtmlView.php | 2 +- .../com_menus/src/View/Menu/HtmlView.php | 2 +- .../com_menus/src/View/Menu/XmlView.php | 2 +- .../com_menus/src/View/Menutypes/HtmlView.php | 2 +- .../components/com_menus/tmpl/item/edit.php | 2 +- .../components/com_menus/tmpl/items/modal.php | 6 +-- .../com_menus/tmpl/menutypes/default.php | 2 +- .../com_messages/src/Model/MessageModel.php | 2 +- .../com_messages/src/View/Config/HtmlView.php | 2 +- .../src/View/Message/HtmlView.php | 2 +- .../com_modules/src/Model/ModuleModel.php | 14 +++---- .../com_modules/src/Model/ModulesModel.php | 4 +- .../com_modules/src/View/Module/HtmlView.php | 2 +- .../com_modules/tmpl/module/edit.php | 2 +- .../com_modules/tmpl/modules/modal.php | 2 +- .../com_modules/tmpl/select/default.php | 2 +- .../com_newsfeeds/src/Model/NewsfeedModel.php | 4 +- .../src/Model/NewsfeedsModel.php | 4 +- .../src/View/Newsfeed/HtmlView.php | 4 +- .../src/View/Newsfeeds/HtmlView.php | 2 +- .../com_newsfeeds/tmpl/newsfeed/edit.php | 2 +- .../com_newsfeeds/tmpl/newsfeeds/modal.php | 4 +- .../com_plugins/src/Model/PluginModel.php | 2 +- .../com_plugins/src/View/Plugin/HtmlView.php | 2 +- .../com_plugins/tmpl/plugin/edit.php | 2 +- .../src/Model/MessagesModel.php | 2 +- .../com_privacy/src/Model/ExportModel.php | 2 +- .../com_privacy/src/Model/RemoveModel.php | 2 +- .../com_privacy/src/View/Request/HtmlView.php | 2 +- .../com_redirect/src/View/Link/HtmlView.php | 2 +- .../com_tags/src/Model/TagModel.php | 8 ++-- .../com_tags/src/View/Tag/HtmlView.php | 2 +- .../com_templates/src/Model/StyleModel.php | 4 +- .../com_templates/src/Model/TemplateModel.php | 18 ++++----- .../com_templates/src/View/Style/HtmlView.php | 2 +- .../src/View/Template/HtmlView.php | 4 +- .../com_templates/tmpl/template/default.php | 2 +- .../template/default_modal_delete_footer.php | 2 +- .../tmpl/template/default_modal_file_body.php | 2 +- .../template/default_modal_folder_body.php | 2 +- .../template/default_modal_folder_footer.php | 2 +- .../tmpl/template/default_updated_files.php | 2 +- .../com_templates/tmpl/template/readonly.php | 2 +- .../src/Controller/MethodController.php | 2 +- .../com_users/src/Field/GroupparentField.php | 2 +- .../components/com_users/src/Helper/Mfa.php | 2 +- .../com_users/src/Model/DebuggroupModel.php | 2 +- .../com_users/src/Model/DebuguserModel.php | 2 +- .../com_users/src/Model/GroupModel.php | 2 +- .../com_users/src/Model/MailModel.php | 2 +- .../com_users/src/Model/NoteModel.php | 6 +-- .../com_users/src/Model/NotesModel.php | 2 +- .../com_users/src/Model/UsersModel.php | 6 +-- .../com_users/src/View/Group/HtmlView.php | 2 +- .../com_users/src/View/Level/HtmlView.php | 2 +- .../com_users/src/View/Mail/HtmlView.php | 2 +- .../com_users/src/View/Note/HtmlView.php | 2 +- .../com_users/src/View/SiteTemplateTrait.php | 4 +- .../com_users/src/View/User/HtmlView.php | 2 +- .../components/com_users/tmpl/user/edit.php | 2 +- .../components/com_users/tmpl/users/modal.php | 2 +- .../src/Dispatcher/Dispatcher.php | 2 +- .../com_workflow/src/Model/StageModel.php | 4 +- .../src/Model/TransitionModel.php | 4 +- .../com_workflow/src/Model/WorkflowModel.php | 4 +- .../com_workflow/src/View/Stage/HtmlView.php | 2 +- .../com_workflow/src/View/Stages/HtmlView.php | 2 +- .../src/View/Transition/HtmlView.php | 4 +- .../src/View/Workflow/HtmlView.php | 2 +- .../com_workflow/tmpl/stage/edit.php | 2 +- .../com_workflow/tmpl/workflow/edit.php | 2 +- administrator/modules/mod_menu/mod_menu.php | 2 +- .../modules/mod_messages/tmpl/default.php | 2 +- .../mod_multilangstatus/tmpl/default.php | 2 +- .../tmpl/default.php | 2 +- .../modules/mod_user/tmpl/default.php | 2 +- administrator/templates/atum/error_full.php | 4 +- administrator/templates/atum/error_login.php | 2 +- administrator/templates/atum/index.php | 4 +- administrator/templates/atum/login.php | 2 +- .../src/Controller/StringsController.php | 6 +-- components/com_ajax/ajax.php | 2 +- .../src/Controller/ConfigController.php | 2 +- .../src/Controller/TemplatesController.php | 2 +- .../com_config/src/Model/ModulesModel.php | 2 +- .../com_config/src/View/Modules/HtmlView.php | 2 +- .../src/View/Templates/HtmlView.php | 2 +- .../com_config/tmpl/modules/default.php | 2 +- .../src/Controller/DisplayController.php | 2 +- .../src/Helper/AssociationHelper.php | 2 +- .../com_contact/src/Model/CategoriesModel.php | 2 +- .../com_contact/src/Model/CategoryModel.php | 14 +++---- .../com_contact/src/Model/ContactModel.php | 6 +-- .../com_contact/src/Model/FeaturedModel.php | 8 ++-- .../com_contact/src/Model/FormModel.php | 8 ++-- .../src/Controller/ArticleController.php | 2 +- .../src/Controller/DisplayController.php | 2 +- .../src/Helper/AssociationHelper.php | 2 +- .../com_content/src/Model/ArchiveModel.php | 14 +++---- .../com_content/src/Model/ArticleModel.php | 6 +-- .../com_content/src/Model/ArticlesModel.php | 14 +++---- .../com_content/src/Model/CategoriesModel.php | 2 +- .../com_content/src/Model/CategoryModel.php | 14 +++---- .../com_content/src/Model/FeaturedModel.php | 2 +- .../com_content/src/Model/FormModel.php | 10 ++--- .../com_content/src/View/Article/HtmlView.php | 2 +- .../src/View/Featured/FeedView.php | 2 +- .../src/Controller/DisplayController.php | 2 +- .../src/Controller/SuggestionsController.php | 2 +- .../com_finder/src/Model/SearchModel.php | 2 +- .../com_finder/src/Model/SuggestionsModel.php | 2 +- .../com_finder/src/View/Search/FeedView.php | 2 +- .../src/Controller/DisplayController.php | 2 +- .../src/Helper/AssociationHelper.php | 2 +- .../src/Model/CategoriesModel.php | 2 +- .../com_newsfeeds/src/Model/CategoryModel.php | 12 +++--- .../com_newsfeeds/src/Model/NewsfeedModel.php | 6 +-- .../src/View/Newsfeed/HtmlView.php | 2 +- .../com_privacy/src/Model/ConfirmModel.php | 2 +- .../com_privacy/src/Model/RemindModel.php | 2 +- components/com_tags/src/Model/TagModel.php | 14 +++---- components/com_tags/src/Model/TagsModel.php | 12 +++--- components/com_tags/src/View/Tag/FeedView.php | 4 +- .../com_tags/src/View/Tags/FeedView.php | 2 +- .../src/Controller/ProfileController.php | 2 +- .../src/Controller/UserController.php | 4 +- components/com_users/src/Model/LoginModel.php | 2 +- components/com_users/src/Model/ResetModel.php | 2 +- installation/src/Model/ChecksModel.php | 2 +- installation/src/Model/LanguagesModel.php | 2 +- installation/src/Model/SetupModel.php | 4 +- layouts/joomla/content/emptystate.php | 4 +- layouts/joomla/edit/admin_modules.php | 2 +- layouts/joomla/edit/frontediting_modules.php | 2 +- layouts/joomla/edit/global.php | 2 +- layouts/joomla/edit/params.php | 2 +- .../Application/AdministratorApplication.php | 4 +- .../src/Application/ApplicationHelper.php | 2 +- libraries/src/Cache/Cache.php | 2 +- libraries/src/Client/ClientHelper.php | 2 +- .../Component/Router/Rules/NomenuRules.php | 6 +-- libraries/src/Document/FeedDocument.php | 2 +- libraries/src/Document/HtmlDocument.php | 2 +- libraries/src/Document/ImageDocument.php | 2 +- libraries/src/Exception/ExceptionHandler.php | 2 +- libraries/src/Form/Field/ListField.php | 4 +- libraries/src/Form/Field/MediaField.php | 2 +- libraries/src/Form/Field/NumberField.php | 4 +- libraries/src/Form/Field/TextField.php | 4 +- libraries/src/Form/Field/TransitionField.php | 4 +- .../src/Form/Field/WorkflowconditionField.php | 2 +- .../src/Form/Field/WorkflowstageField.php | 2 +- libraries/src/HTML/Helpers/Dropdown.php | 2 +- libraries/src/HTML/Helpers/Sidebar.php | 2 +- libraries/src/Helper/CMSHelper.php | 2 +- libraries/src/Helper/ContentHelper.php | 2 +- libraries/src/Helper/ModuleHelper.php | 12 +++--- libraries/src/Helper/RouteHelper.php | 6 +-- .../src/MVC/Controller/BaseController.php | 4 +- .../src/MVC/Controller/FormController.php | 2 +- libraries/src/MVC/Model/AdminModel.php | 8 ++-- libraries/src/MVC/Model/BaseDatabaseModel.php | 2 +- libraries/src/MVC/Model/ListModel.php | 8 ++-- libraries/src/MVC/View/CategoryFeedView.php | 6 +-- libraries/src/MVC/View/FormView.php | 2 +- libraries/src/Service/Provider/Session.php | 8 ++-- libraries/src/Session/Session.php | 4 +- libraries/src/UCM/UCMBase.php | 2 +- libraries/src/UCM/UCMType.php | 2 +- .../src/Workflow/WorkflowPluginTrait.php | 2 +- .../tmpl/default_items.php | 2 +- .../mod_articles_category.php | 2 +- .../src/Helper/ArticlesCategoryHelper.php | 2 +- .../src/Helper/ArticlesNewsHelper.php | 6 +-- .../mod_finder/src/Helper/FinderHelper.php | 2 +- modules/mod_finder/tmpl/default.php | 2 +- .../src/Helper/LanguagesHelper.php | 2 +- .../src/Helper/RelatedItemsHelper.php | 2 +- .../src/Helper/TagsSimilarHelper.php | 6 +-- .../mod_wrapper/src/Helper/WrapperHelper.php | 2 +- .../actionlog/joomla/src/Extension/Joomla.php | 40 +++++++++---------- .../basic/src/Extension/Basic.php | 4 +- .../token/src/Extension/Token.php | 4 +- plugins/authentication/cookie/cookie.php | 22 +++++----- .../versionable/src/Extension/Versionable.php | 2 +- plugins/captcha/recaptcha/recaptcha.php | 2 +- .../recaptcha_invisible.php | 2 +- plugins/content/joomla/joomla.php | 2 +- plugins/content/pagebreak/pagebreak.php | 4 +- .../content/pagenavigation/pagenavigation.php | 4 +- plugins/content/vote/vote.php | 2 +- plugins/editors-xtd/fields/fields.php | 2 +- plugins/editors-xtd/image/image.php | 4 +- .../folderinstaller/tmpl/default.php | 2 +- .../packageinstaller/tmpl/default.php | 2 +- .../installer/webinstaller/webinstaller.php | 2 +- .../webauthn/src/Extension/Webauthn.php | 2 +- .../phpversioncheck/phpversioncheck.php | 4 +- plugins/sampledata/blog/blog.php | 8 ++-- plugins/sampledata/multilang/multilang.php | 16 ++++---- plugins/sampledata/testing/testing.php | 16 ++++---- .../system/accessibility/accessibility.php | 2 +- plugins/system/actionlogs/actionlogs.php | 2 +- plugins/system/cache/src/Extension/Cache.php | 4 +- plugins/system/debug/debug.php | 8 ++-- plugins/system/fields/fields.php | 6 +-- plugins/system/highlight/highlight.php | 2 +- plugins/system/jooa11y/jooa11y.php | 2 +- .../system/languagefilter/languagefilter.php | 16 ++++---- plugins/system/logout/logout.php | 6 +-- .../system/privacyconsent/privacyconsent.php | 26 ++++++------ plugins/system/redirect/redirect.php | 2 +- plugins/system/remember/remember.php | 4 +- .../system/schedulerunner/schedulerunner.php | 10 ++--- .../shortcut/src/Extension/Shortcut.php | 2 +- plugins/system/skipto/skipto.php | 2 +- plugins/system/stats/stats.php | 2 +- .../webauthn/src/PluginTraits/AjaxHandler.php | 2 +- .../src/PluginTraits/AjaxHandlerChallenge.php | 2 +- .../src/PluginTraits/AjaxHandlerCreate.php | 2 +- .../src/PluginTraits/AjaxHandlerDelete.php | 2 +- .../src/PluginTraits/AjaxHandlerLogin.php | 2 +- .../src/PluginTraits/AjaxHandlerSaveLabel.php | 2 +- plugins/user/joomla/joomla.php | 6 +-- plugins/user/profile/profile.php | 4 +- plugins/user/terms/terms.php | 6 +-- plugins/user/token/token.php | 6 +-- templates/cassiopeia/error.php | 10 ++--- templates/cassiopeia/index.php | 10 ++--- 311 files changed, 636 insertions(+), 636 deletions(-) diff --git a/administrator/components/com_admin/src/Model/HelpModel.php b/administrator/components/com_admin/src/Model/HelpModel.php index f3b8b7d862110..27701373b00a3 100644 --- a/administrator/components/com_admin/src/Model/HelpModel.php +++ b/administrator/components/com_admin/src/Model/HelpModel.php @@ -78,7 +78,7 @@ class HelpModel extends BaseDatabaseModel public function &getHelpSearch() { if (\is_null($this->help_search)) { - $this->help_search = Factory::getApplication()->input->getString('helpsearch'); + $this->help_search = Factory::getApplication()->getInput()->getString('helpsearch'); } return $this->help_search; @@ -94,7 +94,7 @@ public function &getHelpSearch() public function &getPage() { if (\is_null($this->page)) { - $this->page = Help::createUrl(Factory::getApplication()->input->get('page', 'Start_Here')); + $this->page = Help::createUrl(Factory::getApplication()->getInput()->get('page', 'Start_Here')); } return $this->page; diff --git a/administrator/components/com_associations/layouts/joomla/searchtools/default.php b/administrator/components/com_associations/layouts/joomla/searchtools/default.php index 91ee344814ea9..2152ec4c3ae79 100644 --- a/administrator/components/com_associations/layouts/joomla/searchtools/default.php +++ b/administrator/components/com_associations/layouts/joomla/searchtools/default.php @@ -83,7 +83,7 @@