From 41a53ed1bb10f69660225b60301e73076fb06058 Mon Sep 17 00:00:00 2001 From: RickR2H Date: Tue, 18 Oct 2022 23:35:09 +0200 Subject: [PATCH 1/2] Fix error --- .../editors/codemirror/layouts/editors/codemirror/element.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/editors/codemirror/layouts/editors/codemirror/element.php b/plugins/editors/codemirror/layouts/editors/codemirror/element.php index 831582ba72f7c..c5802fa90b000 100644 --- a/plugins/editors/codemirror/layouts/editors/codemirror/element.php +++ b/plugins/editors/codemirror/layouts/editors/codemirror/element.php @@ -38,7 +38,7 @@ $addons = 'addons="' . ltrim(HTMLHelper::_('script', $basePath . 'lib/addons' . $extJS, ['version' => 'auto', 'pathOnly' => true]), '/') . '?' . $mediaVersion . '"'; // Remove the fullscreen message and option if readonly not null. -if ($options->readOnly !== null) { +if (isset($options->readOnly) && $options->readOnly !== null) { $fsCombo = ''; } From c07eb448c6047bce1dd03ed02e5d77b4d55ecacf Mon Sep 17 00:00:00 2001 From: RickR2H Date: Wed, 19 Oct 2022 09:14:35 +0200 Subject: [PATCH 2/2] Remove obsolete check --- .../editors/codemirror/layouts/editors/codemirror/element.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/editors/codemirror/layouts/editors/codemirror/element.php b/plugins/editors/codemirror/layouts/editors/codemirror/element.php index c5802fa90b000..deba67387c109 100644 --- a/plugins/editors/codemirror/layouts/editors/codemirror/element.php +++ b/plugins/editors/codemirror/layouts/editors/codemirror/element.php @@ -38,7 +38,7 @@ $addons = 'addons="' . ltrim(HTMLHelper::_('script', $basePath . 'lib/addons' . $extJS, ['version' => 'auto', 'pathOnly' => true]), '/') . '?' . $mediaVersion . '"'; // Remove the fullscreen message and option if readonly not null. -if (isset($options->readOnly) && $options->readOnly !== null) { +if (isset($options->readOnly)) { $fsCombo = ''; }