Skip to content

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Follow #37445 , this PR convert mod_articles_archive to new structure

Testing Instructions

  1. Use Joomla 4.2
  2. Create an instance of Archived Articles module. Note how it works
  3. Apply patch
  4. Delete administrator/cache/autoload_psr4.php
  5. Refresh the page, make sure the module still displays the same as before.

@laoneo laoneo added the Maintainers Checked Used if the PR is conceptional useful label May 31, 2022
@joomla-bot
Copy link
Contributor

This pull requests has been automatically converted to the PSR-12 coding standard.

@richard67
Copy link
Member

It seems the PR has been messed by the PSR-12 conversion. @HLeithner Any idea? Maybe it would be easiest if @joomdonation does it again with a new PR?

@joomdonation
Copy link
Contributor Author

@richard67 It is not easy to resolve the conflicts, so Yes, I will close the PR and redo it at a later time.

@HLeithner
Copy link
Member

@joomdonation sorry for the inconvenience and thanks for redoing it.

@joomdonation
Copy link
Contributor Author

@HLeithner No problem. Thanks for your hard work on PSR-12 conversion.

@joomdonation joomdonation deleted the covert_mod_articles_archive branch March 10, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainers Checked Used if the PR is conceptional useful Unit/System Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants