Skip to content

Conversation

@cyrez
Copy link
Contributor

@cyrez cyrez commented May 28, 2022

Pull Request to add inlinehelp toggle button (PR #35610) in edit view.

Since PR #37158 already integrates inlinehelp button in com_content config, if it's ok with this PR, i will be able to integrate toggle button for inlinehelp in each core components.

Summary of Changes

  • Add inlinehelp button in com_content > Article > edit

Testing Instructions

  • Edit an article and play with inlinehelp toggle button.

Actual result BEFORE applying this Pull Request

  • no inlinehelp button
  • description shown

Expected result AFTER applying this Pull Request

  • Inlinehelp toggle button in toolbar next to help button.
  • Descriptions hidden by default

@conseilgouz
Copy link
Contributor

conseilgouz commented May 30, 2022

inlinehelp button added in modules/plugins : see #37915

@conseilgouz
Copy link
Contributor

for information, #37915 hides inlinehelp toogle button if no description has been defined in extension xml file.

@conseilgouz
Copy link
Contributor

I have tested this item ✅ successfully on 580ceb5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37917.

@cyrez
Copy link
Contributor Author

cyrez commented Jun 2, 2022

for information, #37915 hides inlinehelp toogle button if no description has been defined in extension xml file.

Good addition! I was thinking about it too...
I will try to test your PR tomorrow ;-)

@Quy
Copy link
Contributor

Quy commented Jun 2, 2022

I have tested this item ✅ successfully on 580ceb5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37917.

@Quy
Copy link
Contributor

Quy commented Jun 2, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37917.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 2, 2022
@bembelimen bembelimen merged commit ad991c7 into joomla:4.1-dev Jun 5, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 5, 2022
@bembelimen
Copy link
Contributor

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants