From 12d907661e2d27bb6618c9d910b41332a00b28d8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cyril=20Rez=C3=A9?= <cyril.reze@joomlic.com>
Date: Sat, 21 May 2022 19:33:09 +0200
Subject: [PATCH] Remove inlineHelp as form field attribute

---
 libraries/src/Form/FormField.php | 24 +++---------------------
 1 file changed, 3 insertions(+), 21 deletions(-)

diff --git a/libraries/src/Form/FormField.php b/libraries/src/Form/FormField.php
index ba1f12084d8b6..51f1868412c03 100644
--- a/libraries/src/Form/FormField.php
+++ b/libraries/src/Form/FormField.php
@@ -119,14 +119,6 @@ abstract class FormField
 	 */
 	protected $hiddenDescription = false;
 
-	/**
-	 * Should the description be hidden/shown with toggle button when rendering the form field?
-	 *
-	 * @var    boolean
-	 * @since  4.1.4
-	 */
-	protected $inlineHelp = false;
-
 	/**
 	 * True to translate the field label string.
 	 *
@@ -1075,19 +1067,9 @@ public function renderField($options = array())
 			}
 		}
 
-		if (empty($options['inlineHelp']))
-		{
-			if ($this->getAttribute('inlineHelp'))
-			{
-				$options['inlineHelp'] = $this->getAttribute('inlineHelp') == 'true';
-			}
-			else
-			{
-				$options['inlineHelp'] = isset($this->form->getXml()->config->inlinehelp['button'])
-					? ((string) $this->form->getXml()->config->inlinehelp['button'] == 'show' ?: false)
-					: $this->inlineHelp;
-			}
-		}
+		$options['inlineHelp'] = isset($this->form->getXml()->config->inlinehelp['button'])
+			? ((string) $this->form->getXml()->config->inlinehelp['button'] == 'show' ?: false)
+			: false;
 
 		if ($this->showon)
 		{