-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.2] Action Logs Enabled #37571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] Action Logs Enabled #37571
Conversation
This PR adds a check to the action logs component to determine if the plugin is enabled and if not theen it providees a modal link to enable thee modal. Exactly the same as in com_redirects
administrator/components/com_actionlogs/src/Controller/DisplayController.php
Outdated
Show resolved
Hide resolved
administrator/components/com_actionlogs/src/Controller/DisplayController.php
Show resolved
Hide resolved
|
I have tested this item 🔴 unsuccessfully on 72abefb An error has occurred. Function Location1 () JROOT\libraries\src\WebAsset\WebAssetRegistry.php:132 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37571. |
|
Sorry, wrong dev version! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37571. |
|
@toivo I've altered your test result to "Not tested" in the issue tracker due to your last comment. When you want to correct a previous test result you can do that also yourself just by using again the "Test this" button in the issue tracker and then selecting the new test result, in this case "I've not tested this item" (or so). |
administrator/components/com_actionlogs/src/Controller/DisplayController.php
Show resolved
Hide resolved
|
@richard67 thank you. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37571. |
|
I have tested this item ✅ successfully on 72abefb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37571. |
| * | ||
| * @since __DEPLOY_VERSION__ | ||
| */ | ||
| public static function getActionlogPluginId() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method needs to be moved to the model as there you have the database object available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix the exact same code used in multiple places in core then.
Really frustrating to copy paste code from one component to another and be told its wrong.
As you know core is wrong I now expect that you will fix it
|
Really frustrating to copy paste code from one component to another and be told its wrong. As you know core is wrong I now expect that you will fix it. |
|
I'm on it #37097, but stuff needs to be tested. |
This PR adds a check to the action logs component to determine if the plugin is enabled and if not theen it providees a modal link to enable thee modal. Exactly the same as in com_redirects
Testing Instructions
Disable the plugin "Action Logs - Joomla"
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none