Skip to content

Conversation

@toroworx
Copy link
Contributor

@toroworx toroworx commented Mar 15, 2022

Pull Request for Issue #
#37277

Summary of Changes

When using the modal preview for images with large images, images gets cut off.

Testing Instructions

  • Upload a width-wise large image to your Joomla images folder.
  • Go to Joomla media manager and select said image.
  • Preview the image; it's cut off.

Actual result BEFORE applying this Pull Request

Images only partly visible.

Expected result AFTER applying this Pull Request

Images fully visible, because of proper width.

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels Mar 15, 2022
@RickR2H
Copy link
Member

RickR2H commented Mar 15, 2022

@richard67 do you haven an idea why the build is failing?

@richard67
Copy link
Member

@richard67 do you haven an idea why the build is failing?

Because it can? 😄

@chmst
Copy link
Contributor

chmst commented Mar 16, 2022

The change was made here #34634.
@dgrammatiko could you have a look?

@dgrammatiko
Copy link
Contributor

It's fine, I have no clue why it was changed to 200%

@Quy
Copy link
Contributor

Quy commented Mar 16, 2022

I have tested this item ✅ successfully on cf75216


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37276.

1 similar comment
@chmst
Copy link
Contributor

chmst commented Mar 16, 2022

I have tested this item ✅ successfully on cf75216


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37276.

@chmst chmst removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels Mar 16, 2022
@chmst
Copy link
Contributor

chmst commented Mar 16, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37276.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 16, 2022
@richard67 richard67 added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels Mar 16, 2022
@bembelimen bembelimen merged commit 37937be into joomla:4.1-dev Mar 17, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 17, 2022
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1.1 milestone Mar 17, 2022
@toroworx toroworx deleted the fix/mediapreviewsize branch March 20, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants