[4.1] Correct return value type #36805
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct return value type for function getListQuery in ListModel
Quy
reviewed
Jan 23, 2022
Co-authored-by: Quy <[email protected]>
Contributor
|
I have tested this item ✅ successfully on e13be75 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36805. |
Member
|
This pull request has automatically rebased to 4.2-dev. |
Member
|
Can you fix the conflicts here? |
Member
|
This pull request has been automatically rebased to 4.3-dev. |
Contributor
Author
|
All done in #39990 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Correct return value type for function getListQuery in ListModel
string→\Joomla\Database\DatabaseQueryAdjust spaces in docblock
Testing Instructions
Code review
Documentation Changes Required
None