Skip to content

[3.10] [PHP 8.1] Fix Editor Passing null to $string line 258 #36777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2022
Merged

[3.10] [PHP 8.1] Fix Editor Passing null to $string line 258 #36777

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a1f786
[3.10] [PHP 8.1] Fix Editor Passing null to $string line 258
beat Jan 21, 2022
9c89911
[PHP 8.1] Editor in backend: Better fix for #36777
beat Jan 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/src/Editor/Editor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ public function initialise()

foreach ($results as $result)
{
if (trim($result))
if (trim((string) $result))
{
// @todo remove code: $return .= $result;
$return = $result;
Expand Down