Skip to content

Conversation

@PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Dec 29, 2021

#36482 introduces our first Unit test for Joomla 4 extensions methods

Previously the only tests are for the libraries/src/* classes in the /test/Unit/Libraries/CMS folder which makes no sense

The Unit testing folder structure should reflect the path structure of the code its testing (Best Practice)

This PR renames the folders - the tests still run perfectly fine.

This will eventually conflict with #36482 potentially depending on which is merged first, but I'll fix that myself when I see that happen.

@PhilETaylor

This comment was marked as abuse.

@wilsonge wilsonge merged commit fda621d into joomla:4.0-dev Dec 30, 2021
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0.6 milestone Dec 30, 2021
wilsonge added a commit that referenced this pull request Dec 30, 2021
wilsonge added a commit that referenced this pull request Dec 30, 2021
@wilsonge wilsonge removed this from the Joomla 4.0.6 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants