From 0e63726b11534c62e59ebf982ad34534e0f01d2c Mon Sep 17 00:00:00 2001 From: pdkpavankumar Date: Tue, 8 Sep 2020 13:13:34 +0530 Subject: [PATCH 1/2] adding additional check to avoid js script error --- build/media_source/plg_media-action_rotate/js/rotate.es6.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/build/media_source/plg_media-action_rotate/js/rotate.es6.js b/build/media_source/plg_media-action_rotate/js/rotate.es6.js index ee3dcad0d9fc6..eecedd90451cb 100644 --- a/build/media_source/plg_media-action_rotate/js/rotate.es6.js +++ b/build/media_source/plg_media-action_rotate/js/rotate.es6.js @@ -74,7 +74,8 @@ Joomla.MediaManager.Edit = Joomla.MediaManager.Edit || {}; const elements = [].slice.call(document.querySelectorAll('#jform_rotate_distinct label')); elements.forEach((element) => { element.addEventListener('click', ({ target }) => { - rotate(parseInt(target.querySelector('input').value, 10)); + const inputElement = target.querySelector('input'); + inputElement && rotate(parseInt(inputElement.value, 10)); }); }); }; From 6e8dd5cff913992d242cc33561307981555163ba Mon Sep 17 00:00:00 2001 From: pdkpavankumar Date: Tue, 8 Sep 2020 13:26:05 +0530 Subject: [PATCH 2/2] fixing js lint error --- build/media_source/plg_media-action_rotate/js/rotate.es6.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/build/media_source/plg_media-action_rotate/js/rotate.es6.js b/build/media_source/plg_media-action_rotate/js/rotate.es6.js index eecedd90451cb..98da0369d2e8c 100644 --- a/build/media_source/plg_media-action_rotate/js/rotate.es6.js +++ b/build/media_source/plg_media-action_rotate/js/rotate.es6.js @@ -75,7 +75,9 @@ Joomla.MediaManager.Edit = Joomla.MediaManager.Edit || {}; elements.forEach((element) => { element.addEventListener('click', ({ target }) => { const inputElement = target.querySelector('input'); - inputElement && rotate(parseInt(inputElement.value, 10)); + if (inputElement) { + rotate(parseInt(inputElement.value, 10)); + } }); }); };