From d8c2d3087aa228222562db4eacab0ef82df12b89 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Sun, 12 Apr 2020 13:18:39 +0200
Subject: [PATCH 01/32] CheckJoomlaUpdatesCommand

---
 .../src/Console/CheckJoomlaUpdatesCommand.php | 148 ++++++++++++++++++
 1 file changed, 148 insertions(+)
 create mode 100644 libraries/src/Console/CheckJoomlaUpdatesCommand.php

diff --git a/libraries/src/Console/CheckJoomlaUpdatesCommand.php b/libraries/src/Console/CheckJoomlaUpdatesCommand.php
new file mode 100644
index 0000000000000..1131d5d866ae6
--- /dev/null
+++ b/libraries/src/Console/CheckJoomlaUpdatesCommand.php
@@ -0,0 +1,148 @@
+<?php
+/**
+ * Joomla! Content Management System
+ *
+ * @copyright  Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved.
+ * @license    GNU General Public License version 2 or later; see LICENSE.txt
+ */
+
+namespace Joomla\CMS\Console;
+
+defined('JPATH_PLATFORM') or die;
+
+use Joomla\Component\Joomlaupdate\Administrator\Model\UpdateModel;
+use Joomla\Console\Command\AbstractCommand;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Style\SymfonyStyle;
+
+/**
+ * Console command for checking if there are pending extension updates
+ *
+ * @since  4.0.0
+ */
+class CheckJoomlaUpdatesCommand extends AbstractCommand
+{
+	/**
+	 * The default command name
+	 *
+	 * @var    string
+	 * @since  4.0
+	 */
+	protected static $defaultName = 'check-updates';
+
+	/**
+	 * Stores the Update Information
+	 * @var UpdateModel
+	 * @since 4.0
+	 */
+	private $updateInfo;
+
+	/**
+	 * Initialise the command.
+	 *
+	 * @return  void
+	 *
+	 * @since   4.0.0
+	 */
+	protected function configure(): void
+	{
+		$help = <<<'EOF'
+The <info>%command.name%</info> Checks for Joomla updates.
+
+  <info>php %command.full_name%</info>
+EOF;
+		$this->setDescription('Checks for Joomla updates');
+		$this->setHelp($help);
+	}
+
+	/**
+	 * Retrieves Update Information
+	 *
+	 * @return mixed
+	 *
+	 * @since 4.0
+	 */
+	private function getUpdateInformationFromModel()
+	{
+		$app = $this->getApplication();
+		$updatemodel = $app->bootComponent('com_joomlaupdate')->getMVCFactory($app)->createModel('Update', 'Administrator');
+		$updatemodel->purge();
+		$updatemodel->refreshUpdates(true);
+
+		return $updatemodel;
+	}
+
+	/**
+	 * Gets the Update Information
+	 *
+	 * @return mixed
+	 *
+	 * @since 4.0
+	 */
+	public function getUpdateInfo()
+	{
+		if (!$this->updateInfo)
+		{
+			$this->setUpdateInfo();
+		}
+
+		return $this->updateInfo;
+	}
+
+	/**
+	 * Sets the Update Information
+	 *
+	 * @param   null  $info  stores update Information
+	 *
+	 * @return void
+	 *
+	 * @since 4.0
+	 */
+	public function setUpdateInfo($info = null)
+	{
+		if (!$info)
+		{
+			$this->updateInfo = $this->getUpdateInformationFromModel();
+		}
+		else
+		{
+			$this->updateInfo = $info;
+		}
+	}
+
+	/**
+	 * Internal function to execute the command.
+	 *
+	 * @param   InputInterface   $input   The input to inject into the command.
+	 * @param   OutputInterface  $output  The output to inject into the command.
+	 *
+	 * @return  integer  The command exit code
+	 *
+	 * @since   __DEPLOY_VERSION__
+	 */
+	protected function doExecute(InputInterface $input, OutputInterface $output): int
+	{
+		$symfonyStyle = new SymfonyStyle($input, $output);
+
+		$model = $this->getUpdateInfo();
+		$data  = $model->getUpdateInformation();
+		$symfonyStyle->title('Joomla! Updates');
+
+		if (!$data['hasUpdate'])
+		{
+			$symfonyStyle->success('You already have the latest Joomla version ' . $data['latest']);
+
+			return 0;
+		}
+
+		$symfonyStyle->note('New Joomla Version ' . $data['latest'] . ' is available.');
+
+		if (!isset($data['object']->downloadurl->_data))
+		{
+			$symfonyStyle->warning('We cannot find an update URL');
+		}
+
+		return 0;
+	}
+}

From 91d47ef061c257a1a28fdf86d9e013c18df4cf77 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Sun, 12 Apr 2020 13:21:14 +0200
Subject: [PATCH 02/32] SetConfigurationCommand

---
 .../src/Console/SetConfigurationCommand.php   | 503 ++++++++++++++++++
 1 file changed, 503 insertions(+)
 create mode 100644 libraries/src/Console/SetConfigurationCommand.php

diff --git a/libraries/src/Console/SetConfigurationCommand.php b/libraries/src/Console/SetConfigurationCommand.php
new file mode 100644
index 0000000000000..db0b7543d1aec
--- /dev/null
+++ b/libraries/src/Console/SetConfigurationCommand.php
@@ -0,0 +1,503 @@
+<?php
+/**
+ * Joomla! Content Management System
+ *
+ * @copyright  Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved.
+ * @license    GNU General Public License version 2 or later; see LICENSE.txt
+ */
+
+namespace Joomla\CMS\Console;
+
+defined('JPATH_PLATFORM') or die;
+
+use Joomla\CMS\Factory;
+use Joomla\CMS\Filesystem\File;
+use Joomla\CMS\Language\LanguageHelper;
+use Joomla\CMS\Language\Text;
+use Joomla\Console\Command\AbstractCommand;
+use Joomla\Database\DatabaseDriver;
+use Joomla\Registry\Registry;
+use Joomla\Utilities\ArrayHelper;
+use Symfony\Component\Console\Input\Input;
+use Symfony\Component\Console\Input\InputArgument;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Style\SymfonyStyle;
+
+/**
+ * Console command Setting Configuration options
+ *
+ * @since  4.0.0
+ */
+class SetConfigurationCommand extends AbstractCommand
+{
+	/**
+	 * The default command name
+	 *
+	 * @var    string
+	 * @since  4.0
+	 */
+	protected static $defaultName = 'config:set';
+
+	/**
+	 * Stores the Input Object
+	 * @var Input
+	 * @since 4.0
+	 */
+	private $cliInput;
+
+	/**
+	 * SymfonyStyle Object
+	 * @var SymfonyStyle
+	 * @since 4.0
+	 */
+	private $ioStyle;
+
+	/**
+	 * Options Array
+	 * @var array
+	 * @since 4.0
+	 */
+	private $options;
+
+
+	/**
+	 * Return code if configuration is set successfully
+	 * @since 4.0
+	 */
+	const CONFIG_SET_SUCCESSFUL = 0;
+
+	/**
+	 * Return code if configuration set failed
+	 * @since 4.0
+	 */
+	const CONFIG_SET_FAILED = 3;
+
+	/**
+	 * Return code if database validation failed
+	 * @since 4.0
+	 */
+	const DB_VALIDATION_FAILED = 1;
+
+	/**
+	 * Return code if config validation failed
+	 * @since 4.0
+	 */
+	const CONFIG_VALIDATION_FAILED = 2;
+
+	/**
+	 * Configures the IO
+	 *
+	 * @param   InputInterface   $input   Console Input
+	 * @param   OutputInterface  $output  Console Output
+	 *
+	 * @return void
+	 *
+	 * @since 4.0
+	 *
+	 */
+	private function configureIO(InputInterface $input, OutputInterface $output)
+	{
+		$language = Factory::getLanguage();
+		$language->load('', JPATH_INSTALLATION, null, false, false) ||
+		$language->load('', JPATH_INSTALLATION, null, true);
+		$this->cliInput = $input;
+		$this->ioStyle = new SymfonyStyle($input, $output);
+	}
+
+
+	/**
+	 * Collects options from user input
+	 *
+	 * @param   array  $options  Options inputed by users
+	 *
+	 * @return array
+	 *
+	 * @since 4.0
+	 */
+	public function retrieveOptionsFromInput($options)
+	{
+		$collected = [];
+
+		foreach ($options as $option)
+		{
+			if (strpos($option, '=') === false)
+			{
+				$this->ioStyle
+					->error('Options and values should be separated by "="');
+				exit;
+			}
+
+			list($option, $value) = explode('=', $option);
+
+			$collected[$option] = $value;
+		}
+
+		return $collected;
+	}
+
+
+	/**
+	 * Validates the options provided
+	 *
+	 * @param   array  $options  Options Array
+	 *
+	 * @return mixed
+	 *
+	 * @since 4.0
+	 */
+	public function validateOptions($options)
+	{
+		$config = $this->getInitialConfigurationOptions();
+
+		$configs = $config->toArray();
+
+		$valid = true;
+		array_walk(
+			$options, function ($value, $key) use ($configs, &$valid) {
+				if (!array_key_exists($key, $configs))
+				{
+					$this->getApplication()
+						->enqueueMessage(
+							"Can't find option *$key* in configuration list",
+							'error'
+						);
+
+					$valid = false;
+				}
+			}
+		);
+
+		return $valid;
+	}
+
+	/**
+	 * Sets the options array
+	 *
+	 * @param   string  $options  Options string
+	 *
+	 * @since 4.0
+	 *
+	 * @return void
+	 */
+	public function setOptions($options)
+	{
+		$this->options = explode(' ', $options);
+	}
+
+	/**
+	 * Collects the options array
+	 *
+	 * @return array|mixed
+	 *
+	 * @since 4.0
+	 */
+	public function getOptions()
+	{
+		if ($this->options)
+		{
+			return $this->options;
+		}
+
+		return $this->cliInput->getArgument('options');
+	}
+
+	/**
+	 * Returns Default configuration Object
+	 *
+	 * @return Registry
+	 *
+	 * @since 4.0
+	 */
+	public function getInitialConfigurationOptions(): Registry
+	{
+		return (new Registry(new \JConfig));
+	}
+
+
+	/**
+	 * Save the configuration file
+	 *
+	 * @param   array  $options  Collected options
+	 *
+	 * @return boolean
+	 *
+	 * @since 4.0
+	 */
+	public function saveConfiguration($options)
+	{
+		$config = $this->getInitialConfigurationOptions();
+
+		foreach ($options as $key => $value)
+		{
+			$value = $value === 'false' ? false : $value;
+			$value = $value === 'true' ? true : $value;
+
+			$config->set($key, $value);
+		}
+
+		$config->remove('cwd');
+		$config->remove('execution');
+		$buffer = $config->toString(
+			'PHP',
+			array('class' => 'JConfig', 'closingtag' => false)
+		);
+
+		$path = JPATH_CONFIGURATION . '/configuration.php';
+
+		if ($this->writeFile($buffer, $path))
+		{
+			return true;
+		}
+
+		return false;
+	}
+
+	/**
+	 * Initialise the command.
+	 *
+	 * @return void
+	 *
+	 * @since 4.0
+	 */
+	protected function configure(): void
+	{
+		$this->setDescription('Sets a value for a configuration option');
+
+		$this->addArgument(
+			'options',
+			InputArgument::REQUIRED | InputArgument::IS_ARRAY,
+			'All options you want to set'
+		);
+
+		$help = "The <info>%command.name%</info> 
+				Sets a value for a configuration option
+				\nUsage: <info>php %command.full_name%</info> <option> <value>";
+
+		$this->setHelp($help);
+	}
+
+	/**
+	 * Writes a string to a given file path
+	 *
+	 * @param   string  $buffer  The string that will be written to the file
+	 * @param   string  $path    The path to write the file
+	 *
+	 * @return boolean
+	 *
+	 * @since 4.0
+	 */
+	public function writeFile($buffer, $path)
+	{
+		$options = $this->getApplication()->getConfig();
+
+		// Determine if the configuration file path is writable.
+		if (file_exists($path))
+		{
+			$canWrite = is_writable($path);
+		}
+		else
+		{
+			$canWrite = is_writable(JPATH_CONFIGURATION . '/');
+		}
+
+		/*
+		* If the file exists but isn't writable OR if the file doesn't exist and the parent directory
+		* is not writable we need to use FTP.
+		*/
+		$useFTP = false;
+
+		if ((file_exists($path) && !is_writable($path)) || (!file_exists($path) && !is_writable(dirname($path) . '/')))
+		{
+			return false;
+		}
+
+		// Check for safe mode.
+		if (ini_get('safe_mode'))
+		{
+			$useFTP = true;
+		}
+
+		// Enable/Disable override.
+		if (!isset($options->ftpEnable) || ($options->ftpEnable != 1))
+		{
+			$useFTP = false;
+		}
+
+		return $canWrite ? File::write($path, $buffer) : false;
+	}
+
+
+	/**
+	 * Verifies database connection
+	 *
+	 * @param   array  $options  Options array
+	 *
+	 * @return bool|\Joomla\Database\DatabaseInterface
+	 *
+	 * @since 4.0
+	 * @throws \Exception
+	 */
+	public function checkDb($options)
+	{
+		$options = [
+			'db_type' => $options['dbtype'],
+			'db_host' => $options['host'],
+			'db_prefix' => $options['dbprefix'],
+			'db_name' => $options['db'],
+			'db_pass' => $options['password'],
+			'db_user' => $options['user'],
+		];
+
+
+		// Get the options as an object for easier handling.
+		$options = ArrayHelper::toObject($options);
+
+		// Load the backend language files so that the DB error messages work.
+		$lang = Factory::getLanguage();
+		$currentLang = $lang->getTag();
+
+		// Load the selected language
+		if (LanguageHelper::exists($currentLang, JPATH_ADMINISTRATOR))
+		{
+			$lang->load('joomla', JPATH_ADMINISTRATOR, $currentLang, true);
+		}
+		// Pre-load en-GB in case the chosen language files do not exist.
+		else
+		{
+			$lang->load('joomla', JPATH_ADMINISTRATOR, 'en-GB', true);
+		}
+
+		// Ensure a database type was selected.
+		if (empty($options->db_type))
+		{
+			$this->getApplication()->enqueueMessage(Text::_('INSTL_DATABASE_INVALID_TYPE'), 'warning');
+
+			return false;
+		}
+
+		// Ensure that a hostname and user name were input.
+		if (empty($options->db_host) || empty($options->db_user))
+		{
+			$this->getApplication()->enqueueMessage(Text::_('INSTL_DATABASE_INVALID_DB_DETAILS'), 'warning');
+
+			return false;
+		}
+
+		// Ensure that a database name was input.
+		if (empty($options->db_name))
+		{
+			$this->getApplication()->enqueueMessage(Text::_('INSTL_DATABASE_EMPTY_NAME'), 'warning');
+
+			return false;
+		}
+
+		// Validate database table prefix.
+		if (isset($options->db_prefix) && !preg_match('#^[a-zA-Z]+[a-zA-Z0-9_]*$#', $options->db_prefix))
+		{
+			$this->getApplication()->enqueueMessage(Text::_('INSTL_DATABASE_PREFIX_MSG'), 'warning');
+
+			return false;
+		}
+
+		// Validate length of database table prefix.
+		if (isset($options->db_prefix) && strlen($options->db_prefix) > 15)
+		{
+			$this->getApplication()->enqueueMessage(Text::_('INSTL_DATABASE_FIX_TOO_LONG'), 'warning');
+
+			return false;
+		}
+
+		// Validate length of database name.
+		if (strlen($options->db_name) > 64)
+		{
+			$this->getApplication()->enqueueMessage(Text::_('INSTL_DATABASE_NAME_TOO_LONG'), 'warning');
+
+			return false;
+		}
+
+		// Workaround for UPPERCASE table prefix for PostgreSQL
+		if (in_array($options->db_type, ['pgsql', 'postgresql']))
+		{
+			if (isset($options->db_prefix) && strtolower($options->db_prefix) !== $options->db_prefix)
+			{
+				$this->getApplication()->enqueueMessage(Text::_('INSTL_DATABASE_FIX_LOWERCASE'), 'warning');
+
+				return false;
+			}
+		}
+
+		// Build the connection options array.
+		$settings = [
+			'driver'   => $options->db_type,
+			'host'     => $options->db_host,
+			'user'     => $options->db_user,
+			'password' => $options->db_pass,
+			'database' => $options->db_name,
+			'prefix'   => $options->db_prefix,
+			'select'   => isset($options->db_select) ? $options->db_select : false
+		];
+
+		// Get a database object.
+		try
+		{
+			return DatabaseDriver::getInstance($settings)->connect();
+		}
+		catch (\RuntimeException $e)
+		{
+			$this->getApplication()->enqueueMessage(
+				Text::sprintf('Cannot connect to database, verify that you specified the correct database details', null),
+				'error'
+			);
+
+			return false;
+		}
+	}
+
+	/**
+	 * Internal function to execute the command.
+	 *
+	 * @param   InputInterface   $input   The input to inject into the command.
+	 * @param   OutputInterface  $output  The output to inject into the command.
+	 *
+	 * @return  integer  The command exit code
+	 *
+	 * @since   __DEPLOY_VERSION__
+	 * @throws \Exception
+	 */
+	protected function doExecute(InputInterface $input, OutputInterface $output): int
+	{
+		$this->configureIO($input, $output);
+
+		$options = $this->getOptions();
+
+		$options = $this->retrieveOptionsFromInput($options);
+
+		$valid = $this->validateOptions($options);
+
+		if (!$valid)
+		{
+			return self::CONFIG_VALIDATION_FAILED;
+		}
+
+		$initialOptions = $this->getInitialConfigurationOptions()->toArray();
+
+		$combinedOptions = array_merge($initialOptions, $options);
+
+		$db = $this->checkDb($combinedOptions);
+
+		if ($db === false)
+		{
+			return self::DB_VALIDATION_FAILED;
+		}
+
+		if ($this->saveConfiguration($options))
+		{
+			$this->options ?: $this->ioStyle->success('Configuration set');
+
+			return self::CONFIG_SET_SUCCESSFUL;
+		}
+
+		return self::CONFIG_SET_FAILED;
+	}
+}

From 4bc89af0f24147dffe8951e13eaf25b780a3b1f1 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Sun, 12 Apr 2020 13:22:17 +0200
Subject: [PATCH 03/32] GetConfigurationCommand

---
 .../src/Console/GetConfigurationCommand.php   | 317 ++++++++++++++++++
 1 file changed, 317 insertions(+)
 create mode 100644 libraries/src/Console/GetConfigurationCommand.php

diff --git a/libraries/src/Console/GetConfigurationCommand.php b/libraries/src/Console/GetConfigurationCommand.php
new file mode 100644
index 0000000000000..2ff200b882c03
--- /dev/null
+++ b/libraries/src/Console/GetConfigurationCommand.php
@@ -0,0 +1,317 @@
+<?php
+/**
+ * Joomla! Content Management System
+ *
+ * @copyright  Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved.
+ * @license    GNU General Public License version 2 or later; see LICENSE.txt
+ */
+
+namespace Joomla\CMS\Console;
+
+defined('JPATH_PLATFORM') or die;
+
+use Joomla\Console\Command\AbstractCommand;
+use Symfony\Component\Console\Input\Input;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Input\InputOption;
+use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Style\SymfonyStyle;
+
+/**
+ * Console command for displaying configuration options
+ *
+ * @since  4.0.0
+ */
+class GetConfigurationCommand extends AbstractCommand
+{
+	/**
+	 * The default command name
+	 *
+	 * @var    string
+	 * @since  4.0
+	 */
+	protected static $defaultName = 'config:get';
+
+	/**
+	 * Stores the Input Object
+	 * @var Input
+	 * @since 4.0
+	 */
+	private $cliInput;
+
+	/**
+	 * SymfonyStyle Object
+	 * @var SymfonyStyle
+	 * @since 4.0
+	 */
+	private $ioStyle;
+
+	/**
+	 * Constant defining the Database option group
+	 * @var array
+	 * @since 4.0
+	 */
+	const DB_GROUP = ['name' => 'db', 'options' => ['dbtype', 'host', 'user', 'password', 'dbprefix', 'db']];
+
+	/**
+	 * Constant defining the Session option group
+	 * @var array
+	 * @since 4.0
+	 */
+	const SESSION_GROUP = ['name' => 'session', 'options' => ['session_handler', 'shared_session', 'session_metadata']];
+
+	/**
+	 * Constant defining the Mail option group
+	 * @var array
+	 * @since 4.0
+	 */
+	const MAIL_GROUP = [
+		'name' => 'mail',
+		'options' => [
+			'mailonline', 'mailer', 'mailfrom',
+			'fromname', 'sendmail', 'smtpauth',
+			'smtpuser', 'smtppass', 'smtphost',
+			'smtpsecure', 'smtpport'
+		]
+	];
+
+	/**
+	 * Configures the IO
+	 *
+	 * @param   InputInterface   $input   Console Input
+	 * @param   OutputInterface  $output  Console Output
+	 *
+	 * @return void
+	 *
+	 * @since 4.0
+	 *
+	 */
+	private function configureIO(InputInterface $input, OutputInterface $output)
+	{
+		$this->cliInput = $input;
+		$this->ioStyle = new SymfonyStyle($input, $output);
+	}
+
+
+	/**
+	 * Displays logically grouped options
+	 *
+	 * @param   string  $group  The group to be processed
+	 *
+	 * @return integer
+	 *
+	 * @since 4.0
+	 */
+	public function processGroupOptions($group)
+	{
+		$configs = $this->getApplication()->getConfig()->toArray();
+		$configs = $this->formatConfig($configs);
+
+		$groups = $this->getGroups();
+
+		$foundGroup = false;
+
+		foreach ($groups as $key => $value)
+		{
+			if ($value['name'] === $group)
+			{
+				$foundGroup = true;
+				$options = [];
+
+				foreach ($value['options'] as $key => $option)
+				{
+					$options[] = [$option, $configs[$option]];
+				}
+
+				$this->ioStyle->table(['Option', 'Value'], $options);
+			}
+		}
+
+		if (!$foundGroup)
+		{
+			$this->ioStyle->error("Group *$group* not found");
+			exit;
+		}
+
+		return 0;
+	}
+
+	/**
+	 * Gets the defined option groups
+	 *
+	 * @return array
+	 *
+	 * @since 4.0
+	 */
+	public function getGroups()
+	{
+		return [
+			self::DB_GROUP,
+			self::MAIL_GROUP,
+			self::SESSION_GROUP
+		];
+	}
+
+	/**
+	 * Formats the configuration array into desired format
+	 *
+	 * @param   array  $configs  Array of the configurations
+	 *
+	 * @return array
+	 *
+	 * @since 4.0
+	 */
+	public function formatConfig($configs)
+	{
+		$newConfig = [];
+
+		foreach ($configs as $key => $config)
+		{
+			$config = $config === false ? "false" : $config;
+			$config = $config === true ? "true" : $config;
+
+			if (!in_array($key, ['cwd', 'execution']))
+			{
+				$newConfig[$key] = $config;
+			}
+		}
+
+		return $newConfig;
+	}
+
+	/**
+	 * Handles the command when a single option is requested
+	 *
+	 * @param   string  $option  The option we want to get its value
+	 *
+	 * @return integer
+	 *
+	 * @since 4.0
+	 */
+	public function processSingleOption($option)
+	{
+		$configs = $this->getApplication()->getConfig()->toArray();
+
+		if (!array_key_exists($option, $configs))
+		{
+			$this->ioStyle->error("Can't find option *$option* in configuration list");
+
+			return 1;
+		}
+
+		$value = $this->formatConfigValue($this->getApplication()->get($option));
+
+		$this->ioStyle->table(['Option', 'Value'], [[$option, $value]]);
+
+		return 0;
+	}
+
+	/**
+	 * Formats the Configuration value
+	 *
+	 * @param   mixed  $value  Value to be formatted
+	 *
+	 * @return string
+	 *
+	 * @since version
+	 */
+	protected function formatConfigValue($value)
+	{
+		if ($value === false)
+		{
+			return 'false';
+		}
+		elseif ($value === true)
+		{
+			return 'true';
+		}
+		elseif ($value === null)
+		{
+			return 'Not Set';
+		}
+		else
+		{
+			return $value;
+		}
+	}
+
+	/**
+	 * Initialise the command.
+	 *
+	 * @return  void
+	 *
+	 * @since   4.0.0
+	 */
+	protected function configure(): void
+	{
+		$groups = $this->getGroups();
+
+		foreach ($groups as $key => $group)
+		{
+			$groupNames[] = $group['name'];
+		}
+
+		$groupNames = implode(', ', $groupNames);
+
+		$this->setDescription('Displays the current value of a configuration option');
+
+		$this->addArgument('option', null, 'Name of the option');
+		$this->addOption('group', 'g', InputOption::VALUE_REQUIRED, 'Name of the option');
+
+		$help = "The <info>%command.name%</info> Displays the current value of a configuration option
+				\nUsage: <info>php %command.full_name%</info> <option>
+				\nGroup usage: <info>php %command.full_name%</info> --group=<groupname>
+				\nAvailable group names: $groupNames";
+
+		$this->setHelp($help);
+	}
+
+	/**
+	 * Internal function to execute the command.
+	 *
+	 * @param   InputInterface   $input   The input to inject into the command.
+	 * @param   OutputInterface  $output  The output to inject into the command.
+	 *
+	 * @return  integer  The command exit code
+	 *
+	 * @since   __DEPLOY_VERSION__
+	 */
+	protected function doExecute(InputInterface $input, OutputInterface $output): int
+	{
+		$this->configureIO($input, $output);
+
+		$configs = $this->formatConfig($this->getApplication()->getConfig()->toArray());
+
+		$option = $this->cliInput->getArgument('option');
+		$group = $this->cliInput->getOption('group');
+
+		if ($group)
+		{
+			return $this->processGroupOptions($group);
+		}
+
+		if ($option)
+		{
+			return $this->processSingleOption($option);
+		}
+
+		if (!$option && !$group)
+		{
+			$options = [];
+
+			array_walk(
+				$configs,
+				function ($value, $key) use (&$options) {
+					$options[] = [$key, $value];
+				}
+			);
+
+			$this->ioStyle->title("Current options in Configuration");
+			$this->ioStyle->table(['Option', 'Value'], $options);
+
+			return 0;
+		}
+
+		return 1;
+	}
+}

From 31134b583e811be857bbb9d1b38e9fb703b83a1f Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Sun, 12 Apr 2020 13:24:24 +0200
Subject: [PATCH 04/32] ExtensionsListCommand

---
 .../src/Console/ExtensionsListCommand.php     | 264 ++++++++++++++++++
 1 file changed, 264 insertions(+)
 create mode 100644 libraries/src/Console/ExtensionsListCommand.php

diff --git a/libraries/src/Console/ExtensionsListCommand.php b/libraries/src/Console/ExtensionsListCommand.php
new file mode 100644
index 0000000000000..6dc47d5eca68c
--- /dev/null
+++ b/libraries/src/Console/ExtensionsListCommand.php
@@ -0,0 +1,264 @@
+<?php
+/**
+ * Joomla! Content Management System
+ *
+ * @copyright  Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved.
+ * @license    GNU General Public License version 2 or later; see LICENSE.txt
+ */
+
+namespace Joomla\CMS\Console;
+
+defined('JPATH_PLATFORM') or die;
+
+use Joomla\CMS\Factory;
+use Joomla\Console\Command\AbstractCommand;
+use Joomla\Database\DatabaseInterface;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Style\SymfonyStyle;
+use Symfony\Component\Console\Input\InputOption;
+
+/**
+ * Console command for listing installed extensions
+ *
+ * @since  4.0.0
+ */
+class ExtensionsListCommand extends AbstractCommand
+{
+	/**
+	 * The default command name
+	 *
+	 * @var    string
+	 * @since  4.0
+	 */
+	protected static $defaultName = 'extension:list';
+
+	/**
+	 * Stores the installed Extensions
+	 * @var array
+	 * @since 4.0
+	 */
+	private $extensions;
+
+	/**
+	 * Stores the Input Object
+	 * @var InputInterface
+	 * @since 4.0
+	 */
+	private $cliInput;
+
+	/**
+	 * SymfonyStyle Object
+	 * @var   SymfonyStyle
+	 * @since 4.0
+	 */
+	private $ioStyle;
+
+	/**
+	 * Database connector
+	 *
+	 * @var    DatabaseInterface
+	 * @since  __DEPLOY_VERSION__
+	 */
+	private $db;
+
+	/**
+	 * Instantiate the command.
+	 *
+	 * @param   DatabaseInterface  $db  Database connector
+	 *
+	 * @since   __DEPLOY_VERSION__
+	 */
+	public function __construct(DatabaseInterface $db)
+	{
+		$this->db = $db;
+		parent::__construct();
+	}
+
+	/**
+	 * Configures the IO
+	 *
+	 * @param   InputInterface   $input   Console Input
+	 * @param   OutputInterface  $output  Console Output
+	 *
+	 * @return void
+	 *
+	 * @since 4.0
+	 *
+	 */
+	private function configureIO(InputInterface $input, OutputInterface $output)
+	{
+		$this->cliInput = $input;
+		$this->ioStyle = new SymfonyStyle($input, $output);
+	}
+
+	/**
+	 * Initialise the command.
+	 *
+	 * @return  void
+	 *
+	 * @since   4.0.0
+	 */
+	protected function configure(): void
+	{
+		$this->setDescription('List installed extensions');
+
+		$this->addOption('type', null, InputOption::VALUE_REQUIRED, 'Type of the extension');
+
+		$help = <<<'EOF'
+The <info>%command.name%</info> is used to list all extensions installed on your site.
+
+  <info>php %command.full_name% <extension_id></info>
+
+You may filter on the type of extension (component, module, plugin, etc.) using the <info>--type</info> option:
+
+  <info>php %command.full_name% --type=<type></info>
+EOF;
+		$this->setHelp($help);
+	}
+
+	/**
+	 * Retrieves all extensions
+	 *
+	 * @return mixed
+	 *
+	 * @since 4.0
+	 */
+	public function getExtensions()
+	{
+		if (!$this->extensions)
+		{
+			$this->setExtensions();
+		}
+
+		return $this->extensions;
+	}
+
+	/**
+	 * Retrieves the extension from the model and sets the class variable
+	 *
+	 * @param   null  $extensions  Array of extensions
+	 *
+	 * @return void
+	 *
+	 * @since 4.0
+	 */
+	public function setExtensions($extensions = null)
+	{
+		if (!$extensions)
+		{
+			$this->extensions = $this->getAllExtensionsFromDB();
+		}
+		else
+		{
+			$this->extensions = $extensions;
+		}
+	}
+
+	/**
+	 * Retrieves extension list from DB
+	 *
+	 * @return array
+	 *
+	 * @since 4.0
+	 */
+	private function getAllExtensionsFromDB()
+	{
+		$db    = $this->db;
+		$query = $db->getQuery(true);
+		$query->select('*')
+			->from('#__extensions');
+		$db->setQuery($query);
+		$extensions = $db->loadAssocList('extension_id');
+
+		return $extensions;
+	}
+
+	/**
+	 * Transforms extension arrays into required form
+	 *
+	 * @param   array  $extensions  Array of extensions
+	 *
+	 * @return array
+	 *
+	 * @since 4.0
+	 */
+	private function getExtensionsNameAndId($extensions)
+	{
+		$extInfo = [];
+
+		foreach ($extensions as $key => $extension)
+		{
+			$manifest = json_decode($extension['manifest_cache']);
+			$extInfo[] = [
+				$extension['name'],
+				$extension['extension_id'],
+				$manifest ? $manifest->version : '--',
+				$extension['type'],
+				$extension['enabled'] == 1 ? 'Yes' : 'No',
+			];
+		}
+
+		return $extInfo;
+	}
+
+	/**
+	 * Filters the extension type
+	 *
+	 * @param   string  $type  Extension type
+	 *
+	 * @return array
+	 *
+	 * @since 4.0
+	 */
+	private function filterExtensionsBasedOn($type)
+	{
+		$extensions = [];
+
+		foreach ($this->extensions as $key => $extension)
+		{
+			if ($extension['type'] == $type)
+			{
+				$extensions[] = $extension;
+			}
+		}
+
+		return $extensions;
+	}
+
+	/**
+	 * Internal function to execute the command.
+	 *
+	 * @param   InputInterface   $input   The input to inject into the command.
+	 * @param   OutputInterface  $output  The output to inject into the command.
+	 *
+	 * @return  integer  The command exit code
+	 *
+	 * @since   __DEPLOY_VERSION__
+	 */
+	protected function doExecute(InputInterface $input, OutputInterface $output): int
+	{
+		$this->configureIO($input, $output);
+		$extensions = $this->getExtensions();
+		$type = $this->cliInput->getOption('type');
+
+		if ($type)
+		{
+			$extensions = $this->filterExtensionsBasedOn($type);
+		}
+
+		if (empty($extensions))
+		{
+			$this->ioStyle->error("Cannot find extensions of the type '$type' specified.");
+
+			return 0;
+		}
+
+		$extensions = $this->getExtensionsNameAndId($extensions);
+
+		$this->ioStyle->title('Installed extensions.');
+		$this->ioStyle->table(['Name', 'Extension ID', 'Version', 'Type', 'Active'], $extensions);
+
+		return 0;
+	}
+}

From ff7e5d03412a04635d34781e476aad8463e658d5 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Sun, 12 Apr 2020 13:25:59 +0200
Subject: [PATCH 05/32] SiteUpCommand

---
 libraries/src/Console/SiteUpCommand.php | 113 ++++++++++++++++++++++++
 1 file changed, 113 insertions(+)
 create mode 100644 libraries/src/Console/SiteUpCommand.php

diff --git a/libraries/src/Console/SiteUpCommand.php b/libraries/src/Console/SiteUpCommand.php
new file mode 100644
index 0000000000000..367cfd29f33a6
--- /dev/null
+++ b/libraries/src/Console/SiteUpCommand.php
@@ -0,0 +1,113 @@
+<?php
+/**
+ * Joomla! Content Management System
+ *
+ * @copyright  Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved.
+ * @license    GNU General Public License version 2 or later; see LICENSE.txt
+ */
+
+namespace Joomla\CMS\Console;
+
+defined('JPATH_PLATFORM') or die;
+
+use Joomla\Console\Command\AbstractCommand;
+use Symfony\Component\Console\Input\ArrayInput;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Style\SymfonyStyle;
+
+/**
+ * Console command wrapper for getting the site into offline mode
+ *
+ * @since  4.0.0
+ */
+class SiteUpCommand extends AbstractCommand
+{
+	/**
+	 * The default command name
+	 *
+	 * @var    string
+	 * @since  4.0
+	 */
+	protected static $defaultName = 'site:up';
+
+	/**
+	 * SymfonyStyle Object
+	 * @var SymfonyStyle
+	 * @since 4.0
+	 */
+	private $ioStyle;
+
+	/**
+	 * Return code if site:up failed
+	 * @since 4.0
+	 */
+	const SITE_UP_FAILED = 1;
+
+	/**
+	 * Return code if site:up was successful
+	 * @since 4.0
+	 */
+	const SITE_UP_SUCCESSFUL = 0;
+
+	/**
+	 * Configures the IO
+	 *
+	 * @param   InputInterface   $input   Console Input
+	 * @param   OutputInterface  $output  Console Output
+	 *
+	 * @return void
+	 *
+	 * @since 4.0
+	 *
+	 */
+	private function configureIO(InputInterface $input, OutputInterface $output)
+	{
+		$this->ioStyle = new SymfonyStyle($input, $output);
+	}
+
+	/**
+	 * Initialise the command.
+	 *
+	 * @return  void
+	 *
+	 * @since   4.0.0
+	 */
+	protected function configure(): void
+	{
+		$this->setDescription('Puts the site into online mode');
+
+		$help = "The <info>%command.name%</info> Puts the site into online mode
+				\nUsage: <info>php %command.full_name%</info>";
+
+		$this->setHelp($help);
+	}
+
+	/**
+	 * Internal function to execute the command.
+	 *
+	 * @param   InputInterface   $input   The input to inject into the command.
+	 * @param   OutputInterface  $output  The output to inject into the command.
+	 *
+	 * @return  integer  The command exit code
+	 *
+	 * @since   __DEPLOY_VERSION__
+	 */
+	protected function doExecute(InputInterface $input, OutputInterface $output): int
+	{
+		$this->configureIO($input, $output);
+
+		$returnCode = $this->getApplication()->getCommand(SetConfigurationCommand::getDefaultName())->execute(
+			new ArrayInput(['options' => ['offline=false']]), $output
+		);
+
+		if ($returnCode === 0)
+		{
+			$this->ioStyle->success("Website is now online");
+
+			return self::SITE_UP_SUCCESSFUL;
+		}
+
+		return self::SITE_UP_FAILED;
+	}
+}

From 890b85fe2de021cbf64bedff5782212485deaa60 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Sun, 12 Apr 2020 13:27:11 +0200
Subject: [PATCH 06/32] SiteDownCommand

---
 libraries/src/Console/SiteDownCommand.php | 115 ++++++++++++++++++++++
 1 file changed, 115 insertions(+)
 create mode 100644 libraries/src/Console/SiteDownCommand.php

diff --git a/libraries/src/Console/SiteDownCommand.php b/libraries/src/Console/SiteDownCommand.php
new file mode 100644
index 0000000000000..ef96d41d733ca
--- /dev/null
+++ b/libraries/src/Console/SiteDownCommand.php
@@ -0,0 +1,115 @@
+<?php
+/**
+ * Joomla! Content Management System
+ *
+ * @copyright  Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved.
+ * @license    GNU General Public License version 2 or later; see LICENSE.txt
+ */
+
+namespace Joomla\CMS\Console;
+
+defined('JPATH_PLATFORM') or die;
+
+use Joomla\Console\Command\AbstractCommand;
+use Symfony\Component\Console\Input\ArrayInput;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Style\SymfonyStyle;
+
+/**
+ * Console command wrapper for getting the site into offline mode
+ *
+ * @since  4.0.0
+ */
+class SiteDownCommand extends AbstractCommand
+{
+	/**
+	 * The default command name
+	 *
+	 * @var    string
+	 * @since  4.0
+	 */
+	protected static $defaultName = 'site:down';
+
+	/**
+	 * SymfonyStyle Object
+	 * @var SymfonyStyle
+	 * @since 4.0
+	 */
+	private $ioStyle;
+
+	/**
+	 * Return code if site:down failed
+	 * @since 4.0
+	 */
+	const SITE_DOWN_FAILED = 1;
+
+	/**
+	 * Return code if site:down was successful
+	 * @since 4.0
+	 */
+	const SITE_DOWN_SUCCESSFUL = 0;
+
+	/**
+	 * Configures the IO
+	 *
+	 * @param   InputInterface   $input   Console Input
+	 * @param   OutputInterface  $output  Console Output
+	 *
+	 * @return void
+	 *
+	 * @since 4.0
+	 *
+	 */
+	private function configureIO(InputInterface $input, OutputInterface $output)
+	{
+		$this->ioStyle = new SymfonyStyle($input, $output);
+	}
+
+	/**
+	 * Initialise the command.
+	 *
+	 * @return  void
+	 *
+	 * @since   4.0.0
+	 */
+	protected function configure(): void
+	{
+		$this->setDescription('Puts the site into offline mode');
+
+		$help = <<<'EOF'
+The <info>%command.name%</info> is used to place the site offline.
+
+  <info>php %command.full_name%</info>
+EOF;
+		$this->setHelp($help);
+	}
+
+	/**
+	 * Internal function to execute the command.
+	 *
+	 * @param   InputInterface   $input   The input to inject into the command.
+	 * @param   OutputInterface  $output  The output to inject into the command.
+	 *
+	 * @return  integer  The command exit code
+	 *
+	 * @since   __DEPLOY_VERSION__
+	 */
+	protected function doExecute(InputInterface $input, OutputInterface $output): int
+	{
+		$this->configureIO($input, $output);
+
+		$returnCode = $this->getApplication()->getCommand(SetConfigurationCommand::getDefaultName())->execute(
+			new ArrayInput(['options' => ['offline=true']]), $output
+		);
+
+		if ($returnCode === 0)
+		{
+			$this->ioStyle->success("Successfully set site to offline");
+
+			return self::SITE_DOWN_SUCCESSFUL;
+		}
+
+		return self::SITE_DOWN_FAILED;
+	}
+}

From d57330f0ccd98a258619c2b504f2dcd581e60536 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Sun, 12 Apr 2020 13:29:07 +0200
Subject: [PATCH 07/32] add commands

---
 .../src/Service/Provider/Application.php      | 20 +++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/libraries/src/Service/Provider/Application.php b/libraries/src/Service/Provider/Application.php
index d4df0d2c93910..fd6c05dbd6525 100644
--- a/libraries/src/Service/Provider/Application.php
+++ b/libraries/src/Service/Provider/Application.php
@@ -17,8 +17,14 @@
 use Joomla\CMS\Application\SiteApplication;
 use Joomla\CMS\Console\Loader\WritableContainerLoader;
 use Joomla\CMS\Console\Loader\WritableLoaderInterface;
+use Joomla\CMS\Console\CheckJoomlaUpdatesCommand;
+use Joomla\CMS\Console\ExtensionsListCommand;
+use Joomla\CMS\Console\GetConfigurationCommand;
 use Joomla\CMS\Console\SessionGcCommand;
 use Joomla\CMS\Console\SessionMetadataGcCommand;
+use Joomla\CMS\Console\SetConfigurationCommand;
+use Joomla\CMS\Console\SiteDownCommand;
+use Joomla\CMS\Console\SiteUpCommand;
 use Joomla\CMS\Factory;
 use Joomla\CMS\Language\LanguageFactoryInterface;
 use Joomla\CMS\User\UserFactoryInterface;
@@ -135,10 +141,16 @@ function (Container $container)
 				function (Container $container)
 				{
 					$mapping = [
-						SessionGcCommand::getDefaultName()         => SessionGcCommand::class,
-						SessionMetadataGcCommand::getDefaultName() => SessionMetadataGcCommand::class,
-						ExportCommand::getDefaultName()            => ExportCommand::class,
-						ImportCommand::getDefaultName()            => ImportCommand::class,
+						SessionGcCommand::getDefaultName()          => SessionGcCommand::class,
+						SessionMetadataGcCommand::getDefaultName()  => SessionMetadataGcCommand::class,
+						ExportCommand::getDefaultName()             => ExportCommand::class,
+						ImportCommand::getDefaultName()             => ImportCommand::class,
+						SiteDownCommand::getDefaultName()           => SiteDownCommand::class,
+						SiteUpCommand::getDefaultName()             => SiteUpCommand::class,
+						SetConfigurationCommand::getDefaultName()   => SetConfigurationCommand::class,
+						GetConfigurationCommand::getDefaultName()   => GetConfigurationCommand::class,
+						ExtensionsListCommand::getDefaultName()     => ExtensionsListCommand::class,
+						CheckJoomlaUpdatesCommand::getDefaultName() => CheckJoomlaUpdatesCommand::class,
 					];
 
 					return new WritableContainerLoader($container, $mapping);

From 8d8c4de9afc3979a8275e17a7d3aa355c4b05a42 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Sun, 12 Apr 2020 13:31:14 +0200
Subject: [PATCH 08/32] add commands

---
 libraries/src/Service/Provider/Console.php | 61 +++++++++++++++++++++-
 1 file changed, 60 insertions(+), 1 deletion(-)

diff --git a/libraries/src/Service/Provider/Console.php b/libraries/src/Service/Provider/Console.php
index 41ad729f01e73..0ab2e58909a0b 100644
--- a/libraries/src/Service/Provider/Console.php
+++ b/libraries/src/Service/Provider/Console.php
@@ -10,9 +10,14 @@
 namespace Joomla\CMS\Service\Provider;
 
 \defined('JPATH_PLATFORM') or die;
-
+use Joomla\CMS\Console\CheckJoomlaUpdatesCommand;
+use Joomla\CMS\Console\ExtensionsListCommand;
+use Joomla\CMS\Console\GetConfigurationCommand;
 use Joomla\CMS\Console\SessionGcCommand;
 use Joomla\CMS\Console\SessionMetadataGcCommand;
+use Joomla\CMS\Console\SetConfigurationCommand;
+use Joomla\CMS\Console\SiteDownCommand;
+use Joomla\CMS\Console\SiteUpCommand;
 use Joomla\CMS\Session\MetadataManager;
 use Joomla\Database\Command\ExportCommand;
 use Joomla\Database\Command\ImportCommand;
@@ -79,5 +84,59 @@ function (Container $container)
 			},
 			true
 		);
+
+		$container->share(
+			SiteDownCommand::class,
+			function (Container $container)
+			{
+				return new SiteDownCommand;
+			},
+			true
+		);
+
+		$container->share(
+			SiteUpCommand::class,
+			function (Container $container)
+			{
+				return new SiteUpCommand;
+			},
+			true
+		);
+
+		$container->share(
+			SetConfigurationCommand::class,
+			function (Container $container)
+			{
+				return new SetConfigurationCommand;
+			},
+			true
+		);
+
+		$container->share(
+			GetConfigurationCommand::class,
+			function (Container $container)
+			{
+				return new GetConfigurationCommand;
+			},
+			true
+		);
+
+		$container->share(
+			ExtensionsListCommand::class,
+			function (Container $container)
+			{
+				return new ExtensionsListCommand($container->get('db'));
+			},
+			true
+		);
+
+		$container->share(
+			CheckJoomlaUpdatesCommand::class,
+			function (Container $container)
+			{
+				return new CheckJoomlaUpdatesCommand;
+			},
+			true
+		);
 	}
 }

From 66afb107c6d74aa2657c08fe0d58e03d245f31b8 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Sun, 12 Apr 2020 14:25:17 +0200
Subject: [PATCH 09/32]  database group connection encryption options

---
 .../src/Console/GetConfigurationCommand.php    | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/libraries/src/Console/GetConfigurationCommand.php b/libraries/src/Console/GetConfigurationCommand.php
index 2ff200b882c03..c6e99edc88fda 100644
--- a/libraries/src/Console/GetConfigurationCommand.php
+++ b/libraries/src/Console/GetConfigurationCommand.php
@@ -51,7 +51,23 @@ class GetConfigurationCommand extends AbstractCommand
 	 * @var array
 	 * @since 4.0
 	 */
-	const DB_GROUP = ['name' => 'db', 'options' => ['dbtype', 'host', 'user', 'password', 'dbprefix', 'db']];
+	const DB_GROUP = [
+		'name' => 'db',
+		'options' => [
+			'dbtype',
+			'host',
+			'user',
+			'password',
+			'dbprefix',
+			'db',
+			'dbencryption',
+			'dbsslverifyservercert',
+			'dbsslkey',
+			'dbsslcert',
+			'dbsslca',
+			'dbsslcipher'
+		]
+	];
 
 	/**
 	 * Constant defining the Session option group

From ea2478bcb0cac22672bf2b20d6adccc0aecf5763 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Sun, 12 Apr 2020 20:38:31 +0200
Subject: [PATCH 10/32] help fix

---
 libraries/src/Console/SetConfigurationCommand.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libraries/src/Console/SetConfigurationCommand.php b/libraries/src/Console/SetConfigurationCommand.php
index db0b7543d1aec..bb5eba4c98315 100644
--- a/libraries/src/Console/SetConfigurationCommand.php
+++ b/libraries/src/Console/SetConfigurationCommand.php
@@ -272,7 +272,7 @@ protected function configure(): void
 
 		$help = "The <info>%command.name%</info> 
 				Sets a value for a configuration option
-				\nUsage: <info>php %command.full_name%</info> <option> <value>";
+				\nUsage: <info>php %command.full_name%</info> <option>=<value>";
 
 		$this->setHelp($help);
 	}

From a8a4c200033fa24b04ff53f450019cfa875e826d Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Mon, 13 Apr 2020 12:19:22 +0200
Subject: [PATCH 11/32] full rewrite

---
 .../src/Console/SetConfigurationCommand.php   | 303 ++++++++----------
 1 file changed, 130 insertions(+), 173 deletions(-)

diff --git a/libraries/src/Console/SetConfigurationCommand.php b/libraries/src/Console/SetConfigurationCommand.php
index bb5eba4c98315..c280dbd55acf0 100644
--- a/libraries/src/Console/SetConfigurationCommand.php
+++ b/libraries/src/Console/SetConfigurationCommand.php
@@ -65,25 +65,31 @@ class SetConfigurationCommand extends AbstractCommand
 	 * Return code if configuration is set successfully
 	 * @since 4.0
 	 */
-	const CONFIG_SET_SUCCESSFUL = 0;
+	public const CONFIG_SET_SUCCESSFUL = 0;
 
 	/**
 	 * Return code if configuration set failed
 	 * @since 4.0
 	 */
-	const CONFIG_SET_FAILED = 3;
+	public const CONFIG_SET_FAILED = 1;
 
 	/**
-	 * Return code if database validation failed
+	 * Return code if config validation failed
 	 * @since 4.0
 	 */
-	const DB_VALIDATION_FAILED = 1;
+	public const CONFIG_VALIDATION_FAILED = 2;
 
 	/**
-	 * Return code if config validation failed
+	 * Return code if options are wrong
+	 * @since 4.0
+	 */
+	public const CONFIG_OPTIONS_WRONG = 3;
+
+	/**
+	 * Return code if database validation failed
 	 * @since 4.0
 	 */
-	const CONFIG_VALIDATION_FAILED = 2;
+	public const DB_VALIDATION_FAILED = 4;
 
 	/**
 	 * Configures the IO
@@ -101,21 +107,22 @@ private function configureIO(InputInterface $input, OutputInterface $output)
 		$language = Factory::getLanguage();
 		$language->load('', JPATH_INSTALLATION, null, false, false) ||
 		$language->load('', JPATH_INSTALLATION, null, true);
+		$language->load('com_config', JPATH_ADMINISTRATOR, null, false, false)||
+		$language->load('com_config', JPATH_ADMINISTRATOR, null, true);
 		$this->cliInput = $input;
 		$this->ioStyle = new SymfonyStyle($input, $output);
 	}
 
-
 	/**
 	 * Collects options from user input
 	 *
 	 * @param   array  $options  Options inputed by users
 	 *
-	 * @return array
+	 * @return boolean
 	 *
 	 * @since 4.0
 	 */
-	public function retrieveOptionsFromInput($options)
+	private function retrieveOptionsFromInput($options)
 	{
 		$collected = [];
 
@@ -123,9 +130,9 @@ public function retrieveOptionsFromInput($options)
 		{
 			if (strpos($option, '=') === false)
 			{
-				$this->ioStyle
-					->error('Options and values should be separated by "="');
-				exit;
+				$this->ioStyle->error('Options and values should be separated by "="');
+
+				return false;
 			}
 
 			list($option, $value) = explode('=', $option);
@@ -133,20 +140,19 @@ public function retrieveOptionsFromInput($options)
 			$collected[$option] = $value;
 		}
 
-		return $collected;
-	}
+		$this->options = $collected;
 
+		return true;
+	}
 
 	/**
 	 * Validates the options provided
 	 *
-	 * @param   array  $options  Options Array
-	 *
-	 * @return mixed
+	 * @return boolean
 	 *
 	 * @since 4.0
 	 */
-	public function validateOptions($options)
+	private function validateOptions()
 	{
 		$config = $this->getInitialConfigurationOptions();
 
@@ -154,15 +160,10 @@ public function validateOptions($options)
 
 		$valid = true;
 		array_walk(
-			$options, function ($value, $key) use ($configs, &$valid) {
+			$this->options, function ($value, $key) use ($configs, &$valid) {
 				if (!array_key_exists($key, $configs))
 				{
-					$this->getApplication()
-						->enqueueMessage(
-							"Can't find option *$key* in configuration list",
-							'error'
-						);
-
+					$this->ioStyle->error("Can't find option *$key* in configuration list");
 					$valid = false;
 				}
 			}
@@ -194,11 +195,6 @@ public function setOptions($options)
 	 */
 	public function getOptions()
 	{
-		if ($this->options)
-		{
-			return $this->options;
-		}
-
 		return $this->cliInput->getArgument('options');
 	}
 
@@ -218,39 +214,25 @@ public function getInitialConfigurationOptions(): Registry
 	/**
 	 * Save the configuration file
 	 *
-	 * @param   array  $options  Collected options
-	 *
 	 * @return boolean
 	 *
 	 * @since 4.0
 	 */
-	public function saveConfiguration($options)
+	public function saveConfiguration()
 	{
-		$config = $this->getInitialConfigurationOptions();
-
-		foreach ($options as $key => $value)
-		{
-			$value = $value === 'false' ? false : $value;
-			$value = $value === 'true' ? true : $value;
-
-			$config->set($key, $value);
-		}
-
-		$config->remove('cwd');
-		$config->remove('execution');
-		$buffer = $config->toString(
-			'PHP',
-			array('class' => 'JConfig', 'closingtag' => false)
-		);
+		$app = $this->getApplication();
 
-		$path = JPATH_CONFIGURATION . '/configuration.php';
+		// Check db connection encription properties
+		$model = $app->bootComponent('com_config')->getMVCFactory($app)->createModel('Application', 'Administrator');
 
-		if ($this->writeFile($buffer, $path))
+		if (!$model->save($this->options))
 		{
-			return true;
+			$this->ioStyle->error(Text::_('Failed to save properties'));
+
+			return false;
 		}
 
-		return false;
+		return true;
 	}
 
 	/**
@@ -277,181 +259,157 @@ protected function configure(): void
 		$this->setHelp($help);
 	}
 
-	/**
-	 * Writes a string to a given file path
-	 *
-	 * @param   string  $buffer  The string that will be written to the file
-	 * @param   string  $path    The path to write the file
-	 *
-	 * @return boolean
-	 *
-	 * @since 4.0
-	 */
-	public function writeFile($buffer, $path)
-	{
-		$options = $this->getApplication()->getConfig();
-
-		// Determine if the configuration file path is writable.
-		if (file_exists($path))
-		{
-			$canWrite = is_writable($path);
-		}
-		else
-		{
-			$canWrite = is_writable(JPATH_CONFIGURATION . '/');
-		}
-
-		/*
-		* If the file exists but isn't writable OR if the file doesn't exist and the parent directory
-		* is not writable we need to use FTP.
-		*/
-		$useFTP = false;
-
-		if ((file_exists($path) && !is_writable($path)) || (!file_exists($path) && !is_writable(dirname($path) . '/')))
-		{
-			return false;
-		}
-
-		// Check for safe mode.
-		if (ini_get('safe_mode'))
-		{
-			$useFTP = true;
-		}
-
-		// Enable/Disable override.
-		if (!isset($options->ftpEnable) || ($options->ftpEnable != 1))
-		{
-			$useFTP = false;
-		}
-
-		return $canWrite ? File::write($path, $buffer) : false;
-	}
-
-
 	/**
 	 * Verifies database connection
 	 *
 	 * @param   array  $options  Options array
 	 *
-	 * @return bool|\Joomla\Database\DatabaseInterface
+	 * @return boolean|\Joomla\Database\DatabaseInterface
 	 *
 	 * @since 4.0
 	 * @throws \Exception
 	 */
 	public function checkDb($options)
 	{
-		$options = [
-			'db_type' => $options['dbtype'],
-			'db_host' => $options['host'],
-			'db_prefix' => $options['dbprefix'],
-			'db_name' => $options['db'],
-			'db_pass' => $options['password'],
-			'db_user' => $options['user'],
-		];
-
-
-		// Get the options as an object for easier handling.
-		$options = ArrayHelper::toObject($options);
-
-		// Load the backend language files so that the DB error messages work.
-		$lang = Factory::getLanguage();
-		$currentLang = $lang->getTag();
-
-		// Load the selected language
-		if (LanguageHelper::exists($currentLang, JPATH_ADMINISTRATOR))
-		{
-			$lang->load('joomla', JPATH_ADMINISTRATOR, $currentLang, true);
-		}
-		// Pre-load en-GB in case the chosen language files do not exist.
-		else
+		// Ensure a database type was selected.
+		if (empty($options['dbtype']))
 		{
-			$lang->load('joomla', JPATH_ADMINISTRATOR, 'en-GB', true);
+			$this->ioStyle->error(Text::_('INSTL_DATABASE_INVALID_TYPE'));
+
+			return false;
 		}
 
-		// Ensure a database type was selected.
-		if (empty($options->db_type))
+		// Ensure that a hostname and user name were input.
+		if (empty($options['host']) || empty($options['user']))
 		{
-			$this->getApplication()->enqueueMessage(Text::_('INSTL_DATABASE_INVALID_TYPE'), 'warning');
+			$this->ioStyle->error(Text::_('INSTL_DATABASE_INVALID_DB_DETAILS'));
 
 			return false;
 		}
 
-		// Ensure that a hostname and user name were input.
-		if (empty($options->db_host) || empty($options->db_user))
+		// Validate database table prefix.
+		if (isset($options['dbprefix']) && !preg_match('#^[a-zA-Z]+[a-zA-Z0-9_]*$#', $options['dbprefix']))
 		{
-			$this->getApplication()->enqueueMessage(Text::_('INSTL_DATABASE_INVALID_DB_DETAILS'), 'warning');
+			$this->ioStyle->error(Text::_('INSTL_DATABASE_PREFIX_MSG'));
 
 			return false;
 		}
 
-		// Ensure that a database name was input.
-		if (empty($options->db_name))
+		// Validate length of database table prefix.
+		if (isset($options['dbprefix']) && strlen($options['dbprefix']) > 15)
 		{
-			$this->getApplication()->enqueueMessage(Text::_('INSTL_DATABASE_EMPTY_NAME'), 'warning');
+			$this->ioStyle->error(Text::_('INSTL_DATABASE_FIX_TOO_LONG'), 'warning');
 
 			return false;
 		}
 
-		// Validate database table prefix.
-		if (isset($options->db_prefix) && !preg_match('#^[a-zA-Z]+[a-zA-Z0-9_]*$#', $options->db_prefix))
+		// Validate length of database name.
+		if (strlen($options['db']) > 64)
 		{
-			$this->getApplication()->enqueueMessage(Text::_('INSTL_DATABASE_PREFIX_MSG'), 'warning');
+			$this->ioStyle->error(Text::_('INSTL_DATABASE_NAME_TOO_LONG'));
 
 			return false;
 		}
 
-		// Validate length of database table prefix.
-		if (isset($options->db_prefix) && strlen($options->db_prefix) > 15)
+		// Validate database name.
+		if (in_array($options['dbtype'], ['pgsql', 'postgresql'], true) && !preg_match('#^[a-zA-Z_][0-9a-zA-Z_$]*$#', $options['db']))
 		{
-			$this->getApplication()->enqueueMessage(Text::_('INSTL_DATABASE_FIX_TOO_LONG'), 'warning');
+			$this->ioStyle->error(Text::_('INSTL_DATABASE_NAME_MSG_POSTGRESQL'));
 
 			return false;
 		}
 
-		// Validate length of database name.
-		if (strlen($options->db_name) > 64)
+		if (in_array($options['dbtype'], ['mysql', 'mysqli']) && preg_match('#[\\\\\/\.]#', $options['db']))
 		{
-			$this->getApplication()->enqueueMessage(Text::_('INSTL_DATABASE_NAME_TOO_LONG'), 'warning');
+			$this->ioStyle->error(Text::_('INSTL_DATABASE_NAME_MSG_MYSQL'));
 
 			return false;
 		}
 
 		// Workaround for UPPERCASE table prefix for PostgreSQL
-		if (in_array($options->db_type, ['pgsql', 'postgresql']))
+		if (in_array($options['dbtype'], ['pgsql', 'postgresql']))
 		{
-			if (isset($options->db_prefix) && strtolower($options->db_prefix) !== $options->db_prefix)
+			if (isset($options['dbprefix']) && strtolower($options['dbprefix']) !== $options['dbprefix'])
 			{
-				$this->getApplication()->enqueueMessage(Text::_('INSTL_DATABASE_FIX_LOWERCASE'), 'warning');
+				$this->ioStyle->error(Text::_('INSTL_DATABASE_FIX_LOWERCASE'));
 
 				return false;
 			}
 		}
 
+		$app = $this->getApplication();
+
+		// Check db connection encription properties
+		$model = $app->bootComponent('com_config')->getMVCFactory($app)->createModel('Application', 'Administrator');
+
+		if (!$model->validateDbConnection($options))
+		{
+			$this->ioStyle->error(Text::_('Failed to validate the db connection encription properties'));
+
+			return false;
+		}
+
 		// Build the connection options array.
 		$settings = [
-			'driver'   => $options->db_type,
-			'host'     => $options->db_host,
-			'user'     => $options->db_user,
-			'password' => $options->db_pass,
-			'database' => $options->db_name,
-			'prefix'   => $options->db_prefix,
-			'select'   => isset($options->db_select) ? $options->db_select : false
+			'driver'   => $options['dbtype'],
+			'host'     => $options['host'],
+			'user'     => $options['user'],
+			'password' => $options['password'],
+			'database' => $options['db'],
+			'prefix'   => $options['dbprefix'],
 		];
 
+		if ((int) $options['dbencryption'] !== 0)
+		{
+			$settings['ssl'] = [
+				'enable'             => true,
+				'verify_server_cert' => (bool) $options['dbsslverifyservercert'],
+			];
+
+			foreach (['cipher', 'ca', 'key', 'cert'] as $value)
+			{
+				$confVal = trim($options['dbssl' . $value]);
+
+				if ($confVal !== '')
+				{
+					$settings['ssl'][$value] = $confVal;
+				}
+			}
+		}
+
 		// Get a database object.
 		try
 		{
-			return DatabaseDriver::getInstance($settings)->connect();
+			$db = DatabaseDriver::getInstance($settings);
+			$db->getVersion();
 		}
-		catch (\RuntimeException $e)
+		catch (\Exception $e)
 		{
-			$this->getApplication()->enqueueMessage(
-				Text::sprintf('Cannot connect to database, verify that you specified the correct database details', null),
-				'error'
+			$this->ioStyle->error(
+				Text::sprintf(
+					'Cannot connect to database, verify that you specified the correct database details %s',
+					$e->getMessage()
+				)
 			);
 
 			return false;
 		}
+
+		if ((int) $settings['dbencryption'] !== 0 && empty($db->getConnectionEncryption()))
+		{
+			if ($db->isConnectionEncryptionSupported())
+			{
+				$this->ioStyle->error(Text::_('COM_CONFIG_ERROR_DATABASE_ENCRYPTION_CONN_NOT_ENCRYPT'));
+			}
+			else
+			{
+				$this->ioStyle->error(Text::_('COM_CONFIG_ERROR_DATABASE_ENCRYPTION_SRV_NOT_SUPPORTS'));
+			}
+
+			return false;
+		}
+
+		return true;
 	}
 
 	/**
@@ -471,29 +429,28 @@ protected function doExecute(InputInterface $input, OutputInterface $output): in
 
 		$options = $this->getOptions();
 
-		$options = $this->retrieveOptionsFromInput($options);
-
-		$valid = $this->validateOptions($options);
+		if (!$this->retrieveOptionsFromInput($options))
+		{
+			return self::CONFIG_OPTIONS_WRONG;
+		}
 
-		if (!$valid)
+		if (!$this->validateOptions())
 		{
 			return self::CONFIG_VALIDATION_FAILED;
 		}
 
 		$initialOptions = $this->getInitialConfigurationOptions()->toArray();
 
-		$combinedOptions = array_merge($initialOptions, $options);
-
-		$db = $this->checkDb($combinedOptions);
+		$combinedOptions = array_merge($initialOptions, $this->options);
 
-		if ($db === false)
+		if (!$this->checkDb($combinedOptions))
 		{
 			return self::DB_VALIDATION_FAILED;
 		}
 
-		if ($this->saveConfiguration($options))
+		if ($this->saveConfiguration())
 		{
-			$this->options ?: $this->ioStyle->success('Configuration set');
+			$this->ioStyle->success('Configuration set');
 
 			return self::CONFIG_SET_SUCCESSFUL;
 		}

From e2560cadcb8197b8e4e75ed6c201e34ea679bd33 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Tue, 14 Apr 2020 11:13:44 +0200
Subject: [PATCH 12/32] cleaning a bit

---
 .../src/Console/GetConfigurationCommand.php   | 75 ++++++++++++++-----
 1 file changed, 57 insertions(+), 18 deletions(-)

diff --git a/libraries/src/Console/GetConfigurationCommand.php b/libraries/src/Console/GetConfigurationCommand.php
index c6e99edc88fda..40b3ce07cd344 100644
--- a/libraries/src/Console/GetConfigurationCommand.php
+++ b/libraries/src/Console/GetConfigurationCommand.php
@@ -51,7 +51,7 @@ class GetConfigurationCommand extends AbstractCommand
 	 * @var array
 	 * @since 4.0
 	 */
-	const DB_GROUP = [
+	public const DB_GROUP = [
 		'name' => 'db',
 		'options' => [
 			'dbtype',
@@ -74,23 +74,61 @@ class GetConfigurationCommand extends AbstractCommand
 	 * @var array
 	 * @since 4.0
 	 */
-	const SESSION_GROUP = ['name' => 'session', 'options' => ['session_handler', 'shared_session', 'session_metadata']];
+	public const SESSION_GROUP = [
+		'name' => 'session',
+		'options' => [
+			'session_handler',
+			'shared_session',
+			'session_metadata'
+		]
+	];
 
 	/**
 	 * Constant defining the Mail option group
 	 * @var array
 	 * @since 4.0
 	 */
-	const MAIL_GROUP = [
+	public const MAIL_GROUP = [
 		'name' => 'mail',
 		'options' => [
-			'mailonline', 'mailer', 'mailfrom',
-			'fromname', 'sendmail', 'smtpauth',
-			'smtpuser', 'smtppass', 'smtphost',
-			'smtpsecure', 'smtpport'
+			'mailonline',
+			'mailer',
+			'mailfrom',
+			'fromname',
+			'sendmail',
+			'smtpauth',
+			'smtpuser',
+			'smtppass',
+			'smtphost',
+			'smtpsecure',
+			'smtpport'
 		]
 	];
 
+	/**
+	 * Return code if configuration is get successfully
+	 * @since 4.0
+	 */
+	public const CONFIG_GET_SUCCESSFUL = 0;
+
+	/**
+	 * Return code if configuration group option is not found
+	 * @since 4.0
+	 */
+	public const CONFIG_GET_GROUP_NOT_FOUND = 1;
+
+	/**
+	 * Return code if configuration option is not found
+	 * @since 4.0
+	 */
+	public const CONFIG_GET_OPTION_NOT_FOUND = 2;
+
+	/**
+	 * Return code if the command  has been invoked with wrong options
+	 * @since 4.0
+	 */
+	public const CONFIG_GET_OPTION_FAILED = 3;
+
 	/**
 	 * Configures the IO
 	 *
@@ -118,7 +156,7 @@ private function configureIO(InputInterface $input, OutputInterface $output)
 	 *
 	 * @since 4.0
 	 */
-	public function processGroupOptions($group)
+	public function processGroupOptions($group): int
 	{
 		$configs = $this->getApplication()->getConfig()->toArray();
 		$configs = $this->formatConfig($configs);
@@ -146,10 +184,11 @@ public function processGroupOptions($group)
 		if (!$foundGroup)
 		{
 			$this->ioStyle->error("Group *$group* not found");
-			exit;
+
+			return self::CONFIG_GET_GROUP_NOT_FOUND;
 		}
 
-		return 0;
+		return self::CONFIG_GET_SUCCESSFUL;
 	}
 
 	/**
@@ -177,7 +216,7 @@ public function getGroups()
 	 *
 	 * @since 4.0
 	 */
-	public function formatConfig($configs)
+	public function formatConfig(Array $configs): array
 	{
 		$newConfig = [];
 
@@ -204,7 +243,7 @@ public function formatConfig($configs)
 	 *
 	 * @since 4.0
 	 */
-	public function processSingleOption($option)
+	public function processSingleOption($option): int
 	{
 		$configs = $this->getApplication()->getConfig()->toArray();
 
@@ -212,14 +251,14 @@ public function processSingleOption($option)
 		{
 			$this->ioStyle->error("Can't find option *$option* in configuration list");
 
-			return 1;
+			return self::CONFIG_GET_OPTION_NOT_FOUND;
 		}
 
 		$value = $this->formatConfigValue($this->getApplication()->get($option));
 
 		$this->ioStyle->table(['Option', 'Value'], [[$option, $value]]);
 
-		return 0;
+		return self::CONFIG_GET_SUCCESSFUL;
 	}
 
 	/**
@@ -231,7 +270,7 @@ public function processSingleOption($option)
 	 *
 	 * @since version
 	 */
-	protected function formatConfigValue($value)
+	protected function formatConfigValue($value): string
 	{
 		if ($value === false)
 		{
@@ -299,7 +338,7 @@ protected function doExecute(InputInterface $input, OutputInterface $output): in
 		$configs = $this->formatConfig($this->getApplication()->getConfig()->toArray());
 
 		$option = $this->cliInput->getArgument('option');
-		$group = $this->cliInput->getOption('group');
+		$group  = $this->cliInput->getOption('group');
 
 		if ($group)
 		{
@@ -325,9 +364,9 @@ function ($value, $key) use (&$options) {
 			$this->ioStyle->title("Current options in Configuration");
 			$this->ioStyle->table(['Option', 'Value'], $options);
 
-			return 0;
+			return self::CONFIG_GET_SUCCESSFUL;
 		}
 
-		return 1;
+		return self::CONFIG_GET_FAILED;
 	}
 }

From 979b1adf8c3d6ab0d7e097f141eb78813f2c3e46 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Tue, 14 Apr 2020 11:15:37 +0200
Subject: [PATCH 13/32] cleaning a bit

---
 libraries/src/Console/SetConfigurationCommand.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/libraries/src/Console/SetConfigurationCommand.php b/libraries/src/Console/SetConfigurationCommand.php
index c280dbd55acf0..a3f44a80b1065 100644
--- a/libraries/src/Console/SetConfigurationCommand.php
+++ b/libraries/src/Console/SetConfigurationCommand.php
@@ -122,7 +122,7 @@ private function configureIO(InputInterface $input, OutputInterface $output)
 	 *
 	 * @since 4.0
 	 */
-	private function retrieveOptionsFromInput($options)
+	private function retrieveOptionsFromInput(array $options): bool
 	{
 		$collected = [];
 
@@ -152,7 +152,7 @@ private function retrieveOptionsFromInput($options)
 	 *
 	 * @since 4.0
 	 */
-	private function validateOptions()
+	private function validateOptions(): bool
 	{
 		$config = $this->getInitialConfigurationOptions();
 
@@ -218,7 +218,7 @@ public function getInitialConfigurationOptions(): Registry
 	 *
 	 * @since 4.0
 	 */
-	public function saveConfiguration()
+	public function saveConfiguration(): bool
 	{
 		$app = $this->getApplication();
 
@@ -269,7 +269,7 @@ protected function configure(): void
 	 * @since 4.0
 	 * @throws \Exception
 	 */
-	public function checkDb($options)
+	public function checkDb($options): bool
 	{
 		// Ensure a database type was selected.
 		if (empty($options['dbtype']))

From 801345377a47e2cc67158c8270bb33f722da8caf Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Tue, 14 Apr 2020 11:19:18 +0200
Subject: [PATCH 14/32] cleaning a bit

---
 libraries/src/Console/CheckJoomlaUpdatesCommand.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libraries/src/Console/CheckJoomlaUpdatesCommand.php b/libraries/src/Console/CheckJoomlaUpdatesCommand.php
index 1131d5d866ae6..17c70634f5c4e 100644
--- a/libraries/src/Console/CheckJoomlaUpdatesCommand.php
+++ b/libraries/src/Console/CheckJoomlaUpdatesCommand.php
@@ -99,7 +99,7 @@ public function getUpdateInfo()
 	 *
 	 * @since 4.0
 	 */
-	public function setUpdateInfo($info = null)
+	public function setUpdateInfo($info = null): void
 	{
 		if (!$info)
 		{

From c6e52d7f1f4ce4729b0110e62967fa589ae71e30 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Tue, 14 Apr 2020 11:22:53 +0200
Subject: [PATCH 15/32] cleaning a bit

---
 libraries/src/Console/ExtensionsListCommand.php | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/libraries/src/Console/ExtensionsListCommand.php b/libraries/src/Console/ExtensionsListCommand.php
index 6dc47d5eca68c..abf5c47691ebc 100644
--- a/libraries/src/Console/ExtensionsListCommand.php
+++ b/libraries/src/Console/ExtensionsListCommand.php
@@ -86,7 +86,7 @@ public function __construct(DatabaseInterface $db)
 	 * @since 4.0
 	 *
 	 */
-	private function configureIO(InputInterface $input, OutputInterface $output)
+	private function configureIO(InputInterface $input, OutputInterface $output): void
 	{
 		$this->cliInput = $input;
 		$this->ioStyle = new SymfonyStyle($input, $output);
@@ -143,7 +143,7 @@ public function getExtensions()
 	 *
 	 * @since 4.0
 	 */
-	public function setExtensions($extensions = null)
+	public function setExtensions($extensions = null): void
 	{
 		if (!$extensions)
 		{
@@ -162,7 +162,7 @@ public function setExtensions($extensions = null)
 	 *
 	 * @since 4.0
 	 */
-	private function getAllExtensionsFromDB()
+	private function getAllExtensionsFromDB(): array
 	{
 		$db    = $this->db;
 		$query = $db->getQuery(true);
@@ -183,7 +183,7 @@ private function getAllExtensionsFromDB()
 	 *
 	 * @since 4.0
 	 */
-	private function getExtensionsNameAndId($extensions)
+	private function getExtensionsNameAndId($extensions): array
 	{
 		$extInfo = [];
 
@@ -211,7 +211,7 @@ private function getExtensionsNameAndId($extensions)
 	 *
 	 * @since 4.0
 	 */
-	private function filterExtensionsBasedOn($type)
+	private function filterExtensionsBasedOn($type): array
 	{
 		$extensions = [];
 

From f14694a5b3b95ee62c707fd4a97f39abdd346283 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Tue, 14 Apr 2020 11:23:18 +0200
Subject: [PATCH 16/32] Update
 libraries/src/Console/GetConfigurationCommand.php

Co-Authored-By: Quy <quy@fluxbb.org>
---
 libraries/src/Console/GetConfigurationCommand.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libraries/src/Console/GetConfigurationCommand.php b/libraries/src/Console/GetConfigurationCommand.php
index 40b3ce07cd344..43a8a576163a9 100644
--- a/libraries/src/Console/GetConfigurationCommand.php
+++ b/libraries/src/Console/GetConfigurationCommand.php
@@ -124,7 +124,7 @@ class GetConfigurationCommand extends AbstractCommand
 	public const CONFIG_GET_OPTION_NOT_FOUND = 2;
 
 	/**
-	 * Return code if the command  has been invoked with wrong options
+	 * Return code if the command has been invoked with wrong options
 	 * @since 4.0
 	 */
 	public const CONFIG_GET_OPTION_FAILED = 3;

From 81fc0247f7ab11bfbba0109c7a430ff1cfb85fdb Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Wed, 15 Apr 2020 08:38:42 +0200
Subject: [PATCH 17/32] ExtensionRemoveCommand

---
 .../src/Console/ExtensionRemoveCommand.php    | 207 ++++++++++++++++++
 1 file changed, 207 insertions(+)
 create mode 100644 libraries/src/Console/ExtensionRemoveCommand.php

diff --git a/libraries/src/Console/ExtensionRemoveCommand.php b/libraries/src/Console/ExtensionRemoveCommand.php
new file mode 100644
index 0000000000000..7a283dab0f727
--- /dev/null
+++ b/libraries/src/Console/ExtensionRemoveCommand.php
@@ -0,0 +1,207 @@
+<?php
+/**
+ * Joomla! Content Management System
+ *
+ * @copyright  Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved.
+ * @license    GNU General Public License version 2 or later; see LICENSE.txt
+ */
+
+namespace Joomla\CMS\Console;
+
+defined('JPATH_PLATFORM') or die;
+
+use Joomla\CMS\Factory;
+use Joomla\CMS\Language\LanguageHelper;
+use Joomla\CMS\Language\Text;
+use Joomla\CMS\Installer\Installer;
+use Joomla\CMS\Table\Table;
+use Joomla\Console\Command\AbstractCommand;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Style\SymfonyStyle;
+use Symfony\Component\Console\Input\InputArgument;
+
+
+/**
+ * Console command for removing extensions
+ *
+ * @since  4.0.0
+ */
+class ExtensionRemoveCommand extends AbstractCommand
+{
+	/**
+	 * The default command name
+	 *
+	 * @var    string
+	 * @since  4.0
+	 */
+	protected static $defaultName = 'extension:remove';
+
+	/**
+	 * @var InputInterface
+	 * @since version
+	 */
+	private $cliInput;
+
+	/**
+	 * @var SymfonyStyle
+	 * @since version
+	 */
+	private $ioStyle;
+
+	/**
+	 * Exit Code for extenions remove abort
+	 * @since
+	 */
+	public const REMOVE_ABORT = 3;
+
+	/**
+	 * Exit Code for extenions remove failure
+	 * @since
+	 */
+	public const REMOVE_FAILED = 1;
+
+	/**
+	 * Exit Code for invalid response
+	 * @since
+	 */
+	public const REMOVE_INVALID_RESPONSE = 5;
+
+	/**
+	 * Exit Code for invalid type
+	 * @since
+	 */
+	public const REMOVE_INVALID_TYPE = 6;
+
+	/**
+	 * Exit Code for extenions locked remove failure
+	 * @since
+	 */
+	public const REMOVE_LOCKED = 4;
+
+	/**
+	 * Exit Code for extenions not found
+	 * @since
+	 */
+	public const REMOVE_NOT_FOUND = 2;
+
+	/**
+	 * Exit Code for extenions remove success
+	 * @since
+	 */
+	public const REMOVE_SUCCESSFUL = 0;
+
+	/**
+	 * Configures the IO
+	 *
+	 * @param   InputInterface   $input   Console Input
+	 * @param   OutputInterface  $output  Console Output
+	 *
+	 * @return void
+	 *
+	 * @since 4.0
+	 *
+	 */
+	private function configureIO(InputInterface $input, OutputInterface $output): void
+	{
+		$this->cliInput = $input;
+		$this->ioStyle = new SymfonyStyle($input, $output);
+		$language = Factory::getLanguage();
+		$language->load('', JPATH_ADMINISTRATOR, null, false, false) ||
+		$language->load('', JPATH_ADMINISTRATOR, null, true);
+		$language->load('com_installer', JPATH_ADMINISTRATOR, null, false, false)||
+		$language->load('com_installer', JPATH_ADMINISTRATOR, null, true);
+	}
+
+	/**
+	 * Initialise the command.
+	 *
+	 * @return  void
+	 *
+	 * @since   4.0.0
+	 */
+	protected function configure(): void
+	{
+		$this->addArgument(
+			'extensionId',
+			InputArgument::REQUIRED,
+			'ID of extension to be removed (run extension:list command to check)'
+		);
+		$this->setDescription('Removes an extension');
+
+		$help = <<<'EOF'
+The <info>%command.name%</info> is used to uninstall extensions.  
+The command requires one argument, the ID of the extension to uninstall.  
+You may find this ID by running the <info>extension:list</info> command.
+
+<info>php %command.full_name% <extension_id></info>
+EOF;
+		$this->setHelp($help);
+	}
+
+	/**
+	 * Internal function to execute the command.
+	 *
+	 * @param   InputInterface   $input   The input to inject into the command.
+	 * @param   OutputInterface  $output  The output to inject into the command.
+	 *
+	 * @return  integer  The command exit code
+	 *
+	 * @since   __DEPLOY_VERSION__
+	 */
+	protected function doExecute(InputInterface $input, OutputInterface $output): int
+	{
+		$this->configureIO($input, $output);
+		$extensionId = $this->cliInput->getArgument('extensionId');
+
+		$response = $this->ioStyle->ask('Are you sure you want to remove this extension?', 'yes/no');
+
+		if (strtolower($response) === 'yes')
+		{
+			// Get an installer object for the extension type
+			$installer = Installer::getInstance();
+			$row       = new \Joomla\CMS\Table\Extension(Factory::getDbo());
+
+			if ((int) $extensionId === 0 || !$row->load($extensionId))
+			{
+				$this->ioStyle->error("Extension with ID of $extensionId not found.");
+
+				return self::REMOVE_NOT_FOUND;
+			}
+
+			// Do not allow to uninstall locked extensions.
+			if ((int) $row->locked === 1)
+			{
+				$this->ioStyle->error(Text::_('COM_INSTALLER_UNINSTALL_ERROR_LOCKED_EXTENSION'));
+
+				return self::REMOVE_LOCKED;
+			}
+
+			if ($row->type)
+			{
+				if (!$installer->uninstall($row->type, $extensionId))
+				{
+					$this->ioStyle->error('Extension not removed.');
+
+					return self::REMOVE_FAILED;
+				}
+
+				$this->ioStyle->success('Extension removed!');
+
+				return self::REMOVE_SUCCESSFUL;
+			}
+
+			return self::REMOVE_INVALID_TYPE;
+		}
+		elseif (strtolower($response) === 'no')
+		{
+			$this->ioStyle->note('Extension not removed.');
+
+			return self::REMOVE_ABORT;
+		}
+
+		$this->ioStyle->warning('Invalid response');
+
+		return self::REMOVE_INVALID_RESPONSE;
+	}
+}

From 890bf689bcc7176810f4de10673486a6bd06959f Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Wed, 15 Apr 2020 08:39:39 +0200
Subject: [PATCH 18/32] ExtensionInstallCommand

---
 .../src/Console/ExtensionInstallCommand.php   | 229 ++++++++++++++++++
 1 file changed, 229 insertions(+)
 create mode 100644 libraries/src/Console/ExtensionInstallCommand.php

diff --git a/libraries/src/Console/ExtensionInstallCommand.php b/libraries/src/Console/ExtensionInstallCommand.php
new file mode 100644
index 0000000000000..09f3d680305a4
--- /dev/null
+++ b/libraries/src/Console/ExtensionInstallCommand.php
@@ -0,0 +1,229 @@
+<?php
+/**
+ * Joomla! Content Management System
+ *
+ * @copyright  Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved.
+ * @license    GNU General Public License version 2 or later; see LICENSE.txt
+ */
+
+namespace Joomla\CMS\Console;
+
+defined('JPATH_PLATFORM') or die;
+
+use Joomla\CMS\Installer\Installer;
+use Joomla\CMS\Installer\InstallerHelper;
+use Joomla\Console\Command\AbstractCommand;
+use Symfony\Component\Console\Input\InputArgument;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Input\InputOption;
+use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Style\SymfonyStyle;
+
+/**
+ * Console command for installing extensions
+ *
+ * @since  4.0.0
+ */
+class ExtensionInstallCommand extends AbstractCommand
+{
+	/**
+	 * The default command name
+	 *
+	 * @var    string
+	 * @since  4.0
+	 */
+	protected static $defaultName = 'extension:install';
+
+	/**
+	 * Stores the Input Object
+	 * @var InputInterface
+	 * @since 4.0
+	 */
+	private $cliInput;
+
+	/**
+	 * SymfonyStyle Object
+	 * @var SymfonyStyle
+	 * @since 4.0
+	 */
+	private $ioStyle;
+
+	/**
+	 * Exit Code For installation failure
+	 * @since
+	 */
+	public const INSTALLATION_FAILED = 1;
+
+	/**
+	 * Exit Code For installation Success
+	 * @since
+	 */
+	public const INSTALLATION_SUCCESSFUL = 0;
+
+	/**
+	 * Configures the IO
+	 *
+	 * @param   InputInterface   $input   Console Input
+	 * @param   OutputInterface  $output  Console Output
+	 *
+	 * @return void
+	 *
+	 * @since 4.0
+	 *
+	 */
+	private function configureIO(InputInterface $input, OutputInterface $output): void
+	{
+		$this->cliInput = $input;
+		$this->ioStyle = new SymfonyStyle($input, $output);
+	}
+
+	/**
+	 * Initialise the command.
+	 *
+	 * @return  void
+	 *
+	 * @since   4.0.0
+	 */
+	protected function configure(): void
+	{
+		$this->addOption('path', null, InputOption::VALUE_REQUIRED, 'The path to the extension');
+		$this->addOption('url', null, InputOption::VALUE_REQUIRED, 'The url to the extension');
+
+		$this->setDescription('Installs an extension from a URL or from a Path.');
+
+		$help = <<<'EOF'
+The <info>%command.name%</info> is used to install extensions
+
+  <info>php %command.full_name%</info>
+
+You must provide one of the following options to the command:
+
+  --path: The path on your local filesystem to the install package
+  --url: The URL from where the install package should be downloaded
+
+  <info>php %command.full_name% --path=<path_to_file></info>
+  <info>php %command.full_name% --url=<url_to_file></info>
+EOF;
+		$this->setHelp($help);
+	}
+
+	/**
+	 * Used for installing extension from a path
+	 *
+	 * @param   string  $path  Path to the extension zip file
+	 *
+	 * @return boolean
+	 *
+	 * @since 4.0
+	 *
+	 * @throws \Exception
+	 */
+	public function processPathInstallation($path): bool
+	{
+		if (!file_exists($path))
+		{
+			$this->ioStyle->warning('The file path specified does not exist.');
+
+			return false;
+		}
+
+		$tmpPath = $this->getApplication()->get('tmp_path');
+		$tmpPath = $tmpPath . '/' . basename($path);
+		$package  = InstallerHelper::unpack($path, true);
+
+		if ($package['type'] === false)
+		{
+			return false;
+		}
+
+		$jInstaller = Installer::getInstance();
+		$result     = $jInstaller->install($package['extractdir']);
+		InstallerHelper::cleanupInstall($tmpPath, $package['extractdir']);
+
+		return $result;
+	}
+
+
+	/**
+	 * Used for installing extension from a URL
+	 *
+	 * @param   string  $url  URL to the extension zip file
+	 *
+	 * @return boolean
+	 *
+	 * @since 4.0
+	 *
+	 * @throws \Exception
+	 */
+	public function processUrlInstallation($url): bool
+	{
+		$filename = InstallerHelper::downloadPackage($url);
+
+		$tmpPath = $this->getApplication()->get('tmp_path');
+
+		$path     = $tmpPath . '/' . basename($filename);
+		$package  = InstallerHelper::unpack($path, true);
+
+		if ($package['type'] === false)
+		{
+			return false;
+		}
+
+		$jInstaller = new Installer;
+		$result     = $jInstaller->install($package['extractdir']);
+		InstallerHelper::cleanupInstall($path, $package['extractdir']);
+
+		return $result;
+	}
+
+	/**
+	 * Internal function to execute the command.
+	 *
+	 * @param   InputInterface   $input   The input to inject into the command.
+	 * @param   OutputInterface  $output  The output to inject into the command.
+	 *
+	 * @return  integer  The command exit code
+	 *
+	 * @throws \Exception
+	 * @since   __DEPLOY_VERSION__
+	 */
+	protected function doExecute(InputInterface $input, OutputInterface $output): int
+	{
+		$this->configureIO($input, $output);
+
+		if ($path = $this->cliInput->getOption('path'))
+		{
+			$result = $this->processPathInstallation($path);
+
+			if (!$result)
+			{
+				$this->ioStyle->error('Unable to install extension');
+
+				return self::INSTALLATION_FAILED;
+			}
+
+			$this->ioStyle->success('Extension installed successfully.');
+
+			return self::INSTALLATION_SUCCESSFUL;
+		}
+		elseif ($url = $this->cliInput->getOption('url'))
+		{
+			$result = $this->processUrlInstallation($url);
+
+			if (!$result)
+			{
+				$this->ioStyle->error('Unable to install extension');
+
+				return self::INSTALLATION_FAILED;
+			}
+
+			$this->ioStyle->success('Extension installed successfully.');
+
+			return self::INSTALLATION_SUCCESSFUL;
+		}
+
+		$this->ioStyle->error('Invalid argument supplied for command.');
+
+		return self::INSTALLATION_FAILED;
+	}
+}

From 3cc971573f65b13e683a82d3d74992f009987962 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Wed, 15 Apr 2020 08:42:10 +0200
Subject: [PATCH 19/32] version for flush assets

---
 libraries/src/Application/ConsoleApplication.php | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/libraries/src/Application/ConsoleApplication.php b/libraries/src/Application/ConsoleApplication.php
index a4ea32c06abf6..7008fcf6fa441 100644
--- a/libraries/src/Application/ConsoleApplication.php
+++ b/libraries/src/Application/ConsoleApplication.php
@@ -15,6 +15,7 @@
 use Joomla\CMS\Factory;
 use Joomla\CMS\Language\Language;
 use Joomla\CMS\Plugin\PluginHelper;
+use Joomla\CMS\Version;
 use Joomla\Console\Application;
 use Joomla\DI\Container;
 use Joomla\DI\ContainerAwareTrait;
@@ -387,4 +388,16 @@ public function setSession(SessionInterface $session): self
 
 		return $this;
 	}
+
+	/**
+	 * Flush the media version to refresh versionable assets
+	 *
+	 * @return  void
+	 *
+	 * @since   4.0.0
+	 */
+	public function flushAssets()
+	{
+		(new Version)->refreshMediaVersion();
+	}
 }

From a0225c3d43cf8b0c53abea61b6ca3b812b2ddb0b Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Wed, 15 Apr 2020 08:44:14 +0200
Subject: [PATCH 20/32] add extension commands

---
 libraries/src/Service/Provider/Application.php | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libraries/src/Service/Provider/Application.php b/libraries/src/Service/Provider/Application.php
index fd6c05dbd6525..90cb813d39b19 100644
--- a/libraries/src/Service/Provider/Application.php
+++ b/libraries/src/Service/Provider/Application.php
@@ -18,7 +18,9 @@
 use Joomla\CMS\Console\Loader\WritableContainerLoader;
 use Joomla\CMS\Console\Loader\WritableLoaderInterface;
 use Joomla\CMS\Console\CheckJoomlaUpdatesCommand;
+use Joomla\CMS\Console\ExtensionInstallCommand;
 use Joomla\CMS\Console\ExtensionsListCommand;
+use Joomla\CMS\Console\ExtensionRemoveCommand;
 use Joomla\CMS\Console\GetConfigurationCommand;
 use Joomla\CMS\Console\SessionGcCommand;
 use Joomla\CMS\Console\SessionMetadataGcCommand;
@@ -151,6 +153,8 @@ function (Container $container)
 						GetConfigurationCommand::getDefaultName()   => GetConfigurationCommand::class,
 						ExtensionsListCommand::getDefaultName()     => ExtensionsListCommand::class,
 						CheckJoomlaUpdatesCommand::getDefaultName() => CheckJoomlaUpdatesCommand::class,
+						ExtensionRemoveCommand::getDefaultName()    => ExtensionRemoveCommand::class,
+						ExtensionInstallCommand::getDefaultName()   => ExtensionInstallCommand::class,
 					];
 
 					return new WritableContainerLoader($container, $mapping);

From 57e8fad70dde11b481348e4d353da62d2f0ad3a3 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Wed, 15 Apr 2020 08:45:52 +0200
Subject: [PATCH 21/32] add extension commands

---
 libraries/src/Service/Provider/Console.php | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/libraries/src/Service/Provider/Console.php b/libraries/src/Service/Provider/Console.php
index 0ab2e58909a0b..3586aff78b757 100644
--- a/libraries/src/Service/Provider/Console.php
+++ b/libraries/src/Service/Provider/Console.php
@@ -11,7 +11,9 @@
 
 \defined('JPATH_PLATFORM') or die;
 use Joomla\CMS\Console\CheckJoomlaUpdatesCommand;
+use Joomla\CMS\Console\ExtensionInstallCommand;
 use Joomla\CMS\Console\ExtensionsListCommand;
+use Joomla\CMS\Console\ExtensionRemoveCommand;
 use Joomla\CMS\Console\GetConfigurationCommand;
 use Joomla\CMS\Console\SessionGcCommand;
 use Joomla\CMS\Console\SessionMetadataGcCommand;
@@ -137,6 +139,24 @@ function (Container $container)
 				return new CheckJoomlaUpdatesCommand;
 			},
 			true
+		);
+
+				$container->share(
+			ExtensionRemoveCommand::class,
+			function (Container $container)
+			{
+				return new ExtensionRemoveCommand;
+			},
+			true
+		);
+
+		$container->share(
+			ExtensionInstallCommand::class,
+			function (Container $container)
+			{
+				return new ExtensionInstallCommand;
+			},
+			true
 		);
 	}
 }

From f650771f884b0ed1ca034a4f9a72db229155084d Mon Sep 17 00:00:00 2001
From: Richard Fath <richard67@users.noreply.github.com>
Date: Wed, 15 Apr 2020 09:23:24 +0200
Subject: [PATCH 22/32] PHPCS

---
 libraries/src/Service/Provider/Console.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libraries/src/Service/Provider/Console.php b/libraries/src/Service/Provider/Console.php
index 3586aff78b757..021f39b24984d 100644
--- a/libraries/src/Service/Provider/Console.php
+++ b/libraries/src/Service/Provider/Console.php
@@ -141,7 +141,7 @@ function (Container $container)
 			true
 		);
 
-				$container->share(
+		$container->share(
 			ExtensionRemoveCommand::class,
 			function (Container $container)
 			{

From 57e59c435381344f28f30dc8b9652d12c194d0d9 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Thu, 16 Apr 2020 09:52:30 +0200
Subject: [PATCH 23/32] move check-updates to core group commands

Co-authored-by: bosunski <bosunski@gmail.com>
---
 libraries/src/Console/CheckJoomlaUpdatesCommand.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libraries/src/Console/CheckJoomlaUpdatesCommand.php b/libraries/src/Console/CheckJoomlaUpdatesCommand.php
index 17c70634f5c4e..8d457da430b34 100644
--- a/libraries/src/Console/CheckJoomlaUpdatesCommand.php
+++ b/libraries/src/Console/CheckJoomlaUpdatesCommand.php
@@ -29,7 +29,7 @@ class CheckJoomlaUpdatesCommand extends AbstractCommand
 	 * @var    string
 	 * @since  4.0
 	 */
-	protected static $defaultName = 'check-updates';
+	protected static $defaultName = 'core:check-updates';
 
 	/**
 	 * Stores the Update Information

From 7ad60dd7358f82da76bc99cb056b2afda730cd16 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Thu, 16 Apr 2020 10:12:34 +0200
Subject: [PATCH 24/32] UpdateCoreCommand

Co-authored-by: bosunski <bosunski@gmail.com>
---
 libraries/src/Console/UpdateCoreCommand.php | 391 ++++++++++++++++++++
 1 file changed, 391 insertions(+)
 create mode 100644 libraries/src/Console/UpdateCoreCommand.php

diff --git a/libraries/src/Console/UpdateCoreCommand.php b/libraries/src/Console/UpdateCoreCommand.php
new file mode 100644
index 0000000000000..8e34c46a0dfdd
--- /dev/null
+++ b/libraries/src/Console/UpdateCoreCommand.php
@@ -0,0 +1,391 @@
+<?php
+/**
+ * Joomla! Content Management System
+ *
+ * @copyright  Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved.
+ * @license    GNU General Public License version 2 or later; see LICENSE.txt
+ */
+
+namespace Joomla\CMS\Console;
+
+defined('JPATH_PLATFORM') or die;
+
+use Joomla\Application\Cli\CliInput;
+use Joomla\CMS\Factory;
+use Joomla\CMS\Filesystem\File;
+use Joomla\CMS\Filesystem\Folder;
+use Joomla\CMS\Installer\InstallerHelper;
+use Joomla\Console\Command\AbstractCommand;
+use Joomla\Database\DatabaseInterface;
+use Symfony\Component\Console\Helper\ProgressBar;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Style\SymfonyStyle;
+
+/**
+ * Console command for updating Joomla! core
+ *
+ * @since  4.0.0
+ */
+class UpdateCoreCommand extends AbstractCommand
+{
+	/**
+	 * The default command name
+	 *
+	 * @var    string
+	 * @since  4.0
+	 */
+	protected static $defaultName = 'core:update';
+
+	/**
+	 * Stores the Input Object
+	 * @var CliInput
+	 * @since 4.0
+	 */
+	private $cliInput;
+
+	/**
+	 * SymfonyStyle Object
+	 * @var SymfonyStyle
+	 * @since 4.0
+	 */
+	private $ioStyle;
+
+	/**
+	 * Update Information
+	 * @var array
+	 * @since 4.0
+	 */
+	public $updateInfo;
+
+	/**
+	 * Update Model
+	 * @var array
+	 * @since 4.0
+	 */
+	public $updateModel;
+
+	/**
+	 * Progress Bar object
+	 * @var ProgressBar
+	 * @since 4.0
+	 */
+	public $progressBar;
+
+	/**
+	 * Return code for successful update
+	 * @since 4.0
+	 */
+	public const UPDATE_SUCCESSFUL = 0;
+
+	/**
+	 * Return code for failed update
+	 * @since 4.0
+	 */
+	public const ERR_UPDATE_FAILED = 2;
+
+	/**
+	 * Return code for failed checks
+	 * @since 4.0
+	 */
+	public const ERR_CHECKS_FAILED = 1;
+
+	/**
+	 * @var DatabaseInterface
+	 * @since 4.0
+	 */
+	private $db;
+
+	/**
+	 * UpdateCoreCommand constructor.
+	 *
+	 * @param   DatabaseInterface  $db  Database Instance
+	 *
+	 * @since 4.0
+	 */
+	public function __construct(DatabaseInterface $db)
+	{
+		$this->db = $db;
+		parent::__construct();
+	}
+
+	/**
+	 * Configures the IO
+	 *
+	 * @param   InputInterface   $input   Console Input
+	 * @param   OutputInterface  $output  Console Output
+	 *
+	 * @return void
+	 *
+	 * @since 4.0
+	 *
+	 */
+	private function configureIO(InputInterface $input, OutputInterface $output)
+	{
+		ProgressBar::setFormatDefinition('custom', ' %current%/%max% -- %message%');
+		$this->progressBar = new ProgressBar($output, 8);
+		$this->progressBar->setFormat('custom');
+
+		$this->cliInput = $input;
+		$this->ioStyle = new SymfonyStyle($input, $output);
+	}
+
+	/**
+	 * Internal function to execute the command.
+	 *
+	 * @param   InputInterface   $input   The input to inject into the command.
+	 * @param   OutputInterface  $output  The output to inject into the command.
+	 *
+	 * @return  integer  The command exit code
+	 *
+	 * @since   __DEPLOY_VERSION__
+	 * @throws \Exception
+	 */
+	public function doExecute(InputInterface $input, OutputInterface $output): int
+	{
+		$this->configureIO($input, $output);
+
+		$this->progressBar->setMessage("Starting up ...");
+		$this->progressBar->start();
+
+		$model = $this->getUpdateModel();
+
+		$this->setUpdateInfo($model->getUpdateInformation());
+
+		$this->progressBar->advance();
+		$this->progressBar->setMessage('Running checks ...');
+
+		if (!$this->updateInfo['hasUpdate'])
+		{
+			$this->progressBar->finish();
+			$this->ioStyle->note('You already have the latest Joomla! version. ' . $this->updateInfo['latest']);
+
+			return self::ERR_CHECKS_FAILED;
+		}
+
+		$this->progressBar->advance();
+		$this->progressBar->setMessage('Starting Joomla! update ...');
+
+		if ($this->updateJoomlaCore($model))
+		{
+			$this->progressBar->finish();
+			$this->ioStyle->success('Joomla core updated successfully!');
+
+			return self::UPDATE_SUCCESSFUL;
+		}
+
+		$this->progressBar->finish();
+
+		$this->ioStyle->error('Update cannot be performed.');
+
+		return self::ERR_UPDATE_FAILED;
+	}
+
+	/**
+	 * Initialise the command.
+	 *
+	 * @return  void
+	 *
+	 * @since   4.0.0
+	 */
+	protected function configure(): void
+	{
+		$this->setDescription('Updates joomla core');
+
+		$help = <<<'EOF'
+The <info>%command.name%</info> is used to update Joomla.
+
+  <info>php %command.full_name%</info>
+EOF;
+		$this->setHelp($help);
+	}
+
+	/**
+	 * Update Core Joomla
+	 *
+	 * @param   mixed  $updatemodel  Update Model
+	 *
+	 * @return  boolean  success
+	 *
+	 * @since 4.0
+	 */
+	private function updateJoomlaCore($updatemodel): bool
+	{
+		$updateInformation = $this->updateInfo;
+
+		if (!empty($updateInformation['hasUpdate']))
+		{
+			$this->progressBar->advance();
+			$this->progressBar->setMessage("Processing update package ...");
+			$package = $this->processUpdatePackage($updateInformation);
+
+			$this->progressBar->advance();
+			$this->progressBar->setMessage("Finalizing update ...");
+			$result = $updatemodel->finaliseUpgrade();
+
+			if ($result)
+			{
+				$this->progressBar->advance();
+				$this->progressBar->setMessage("Cleaning up ...");
+
+				// Remove the xml
+				if (file_exists(JPATH_BASE . '/joomla.xml'))
+				{
+					File::delete(JPATH_BASE . '/joomla.xml');
+				}
+
+				InstallerHelper::cleanupInstall($package['file'], $package['extractdir']);
+
+				$updatemodel->purge();
+
+				return true;
+			}
+		}
+
+		return false;
+	}
+
+	/**
+	 * Sets the update Information
+	 *
+	 * @param   array  $data  Stores the update information
+	 *
+	 * @since 4.0
+	 *
+	 * @return void
+	 */
+	public function setUpdateInfo($data): void
+	{
+		$this->updateInfo = $data;
+	}
+
+	/**
+	 * Retrieves the Update model from com_joomlaupdate
+	 *
+	 * @return mixed
+	 *
+	 * @since 4.0
+	 *
+	 * @throws \Exception
+	 */
+	public function getUpdateModel()
+	{
+		if (!isset($this->updateModel))
+		{
+			$this->setUpdateModel();
+		}
+
+		return $this->updateModel;
+	}
+
+	/**
+	 * Sets the Update Model
+	 *
+	 * @return void
+	 *
+	 * @since 4.0
+	 */
+	public function setUpdateModel(): void
+	{
+		$app = $this->getApplication();
+		$updatemodel = $app->bootComponent('com_joomlaupdate')->getMVCFactory($app)->createModel('Update', 'Administrator');
+
+		if (is_bool($updatemodel))
+		{
+			$this->updateModel = $updatemodel;
+
+			return;
+		}
+
+		$updatemodel->purge();
+		$updatemodel->refreshUpdates(true);
+
+		$this->updateModel = $updatemodel;
+	}
+
+	/**
+	 * Downloads and extracts the update Package
+	 *
+	 * @param   array  $updateInformation  Stores the update information
+	 *
+	 * @return array | boolean
+	 *
+	 * @since 4.0
+	 */
+	public function processUpdatePackage($updateInformation)
+	{
+		if (!$updateInformation['object'])
+		{
+			return false;
+		}
+
+		$this->progressBar->advance();
+		$this->progressBar->setMessage("Downloading update package ...");
+		$file = $this->downloadFile($updateInformation['object']->downloadurl->_data);
+
+		$tmpPath    = $this->getApplication()->get('tmp_path');
+		$updatePackage = $tmpPath . '/' . $file;
+
+		$this->progressBar->advance();
+		$this->progressBar->setMessage("Extracting update package ...");
+		$package = $this->extractFile($updatePackage);
+
+		$this->progressBar->advance();
+		$this->progressBar->setMessage("Copying files ...");
+		$this->copyFileTo($package['extractdir'], JPATH_BASE);
+
+		return ['file' => $updatePackage, 'extractdir' => $package['extractdir']];
+	}
+
+	/**
+	 * Downloads the Update file
+	 *
+	 * @param   string  $url  URL to update file
+	 *
+	 * @return boolean | string
+	 *
+	 * @since 4.0
+	 */
+	public function downloadFile($url)
+	{
+		$file = InstallerHelper::downloadPackage($url);
+
+		if (!$file)
+		{
+			return false;
+		}
+
+		return $file;
+	}
+
+	/**
+	 * Extracts Update file
+	 *
+	 * @param   string  $file  Full path to file location
+	 *
+	 * @return array | boolean
+	 *
+	 * @since 4.0
+	 */
+	public function extractFile($file)
+	{
+		$package = InstallerHelper::unpack($file, true);
+
+		return $package;
+	}
+
+	/**
+	 * Copy a file to a destination directory
+	 *
+	 * @param   string  $file  Full path to file
+	 * @param   string  $dir   Destination directory
+	 *
+	 * @return void
+	 *
+	 * @since 4.0
+	 */
+	public function copyFileTo($file, $dir): void
+	{
+		Folder::copy($file, $dir, '', true);
+	}
+}

From 7c9643d52df2f3e0a93995f03bb1b7fd86fa52e3 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Thu, 16 Apr 2020 10:14:37 +0200
Subject: [PATCH 25/32] add  update  core command

Co-authored-by: bosunski <bosunski@gmail.com>
---
 libraries/src/Service/Provider/Application.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libraries/src/Service/Provider/Application.php b/libraries/src/Service/Provider/Application.php
index 90cb813d39b19..977b86c8b6090 100644
--- a/libraries/src/Service/Provider/Application.php
+++ b/libraries/src/Service/Provider/Application.php
@@ -27,6 +27,7 @@
 use Joomla\CMS\Console\SetConfigurationCommand;
 use Joomla\CMS\Console\SiteDownCommand;
 use Joomla\CMS\Console\SiteUpCommand;
+use Joomla\CMS\Console\UpdateCoreCommand;
 use Joomla\CMS\Factory;
 use Joomla\CMS\Language\LanguageFactoryInterface;
 use Joomla\CMS\User\UserFactoryInterface;
@@ -155,6 +156,7 @@ function (Container $container)
 						CheckJoomlaUpdatesCommand::getDefaultName() => CheckJoomlaUpdatesCommand::class,
 						ExtensionRemoveCommand::getDefaultName()    => ExtensionRemoveCommand::class,
 						ExtensionInstallCommand::getDefaultName()   => ExtensionInstallCommand::class,
+						UpdateCoreCommand::getDefaultName()         => UpdateCoreCommand::class,
 					];
 
 					return new WritableContainerLoader($container, $mapping);

From cb139e0a30b8a0dba0614b97d6ae18167f47ae07 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Thu, 16 Apr 2020 10:16:47 +0200
Subject: [PATCH 26/32] UpdateCoreCommand

Co-authored-by: bosunski <bosunski@gmail.com>
---
 libraries/src/Service/Provider/Console.php | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/libraries/src/Service/Provider/Console.php b/libraries/src/Service/Provider/Console.php
index 021f39b24984d..6bc41a72dcbb7 100644
--- a/libraries/src/Service/Provider/Console.php
+++ b/libraries/src/Service/Provider/Console.php
@@ -20,6 +20,7 @@
 use Joomla\CMS\Console\SetConfigurationCommand;
 use Joomla\CMS\Console\SiteDownCommand;
 use Joomla\CMS\Console\SiteUpCommand;
+use Joomla\CMS\Console\UpdateCoreCommand;
 use Joomla\CMS\Session\MetadataManager;
 use Joomla\Database\Command\ExportCommand;
 use Joomla\Database\Command\ImportCommand;
@@ -158,5 +159,14 @@ function (Container $container)
 			},
 			true
 		);
+
+		$container->share(
+			UpdateCoreCommand::class,
+			function (Container $container)
+			{
+				return new UpdateCoreCommand($container->get('db'));
+			},
+			true
+		);
 	}
 }

From 97d446e1074e45486a98e7c3a94aa18b85534a8f Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Fri, 17 Apr 2020 12:40:10 +0200
Subject: [PATCH 27/32] fix Notice

Co-authored-by: bosunski <bosunski@gmail.com>
---
 libraries/src/Console/SetConfigurationCommand.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libraries/src/Console/SetConfigurationCommand.php b/libraries/src/Console/SetConfigurationCommand.php
index a3f44a80b1065..e5d88e102ea76 100644
--- a/libraries/src/Console/SetConfigurationCommand.php
+++ b/libraries/src/Console/SetConfigurationCommand.php
@@ -395,7 +395,7 @@ public function checkDb($options): bool
 			return false;
 		}
 
-		if ((int) $settings['dbencryption'] !== 0 && empty($db->getConnectionEncryption()))
+		if ((int) $options['dbencryption'] !== 0 && empty($db->getConnectionEncryption()))
 		{
 			if ($db->isConnectionEncryptionSupported())
 			{

From 5913b9beb7fb072aed9d01808d818e15ceebd9bf Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Sun, 19 Apr 2020 08:39:46 +0200
Subject: [PATCH 28/32] force_ssl missed

---
 installation/src/Model/ConfigurationModel.php | 1 +
 1 file changed, 1 insertion(+)

diff --git a/installation/src/Model/ConfigurationModel.php b/installation/src/Model/ConfigurationModel.php
index bc95874789d15..4bc25f5a5d92d 100644
--- a/installation/src/Model/ConfigurationModel.php
+++ b/installation/src/Model/ConfigurationModel.php
@@ -425,6 +425,7 @@ public function createConfiguration($options)
 		$registry->set('dbsslcipher', $options->db_sslcipher);
 
 		// Server settings.
+		$registry->set('force_ssl', 0);
 		$registry->set('live_site', '');
 		$registry->set('secret', UserHelper::genRandomPassword(16));
 		$registry->set('gzip', false);

From 953c70fe103c2ad3de7e5f35c86f74fccdab706b Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Sun, 19 Apr 2020 08:43:37 +0200
Subject: [PATCH 29/32] fixed notices when site:down site:up

Co-authored-by: bosunski <bosunski@gmail.com>
---
 libraries/src/Console/SetConfigurationCommand.php | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/libraries/src/Console/SetConfigurationCommand.php b/libraries/src/Console/SetConfigurationCommand.php
index e5d88e102ea76..7353cf0494e55 100644
--- a/libraries/src/Console/SetConfigurationCommand.php
+++ b/libraries/src/Console/SetConfigurationCommand.php
@@ -214,18 +214,20 @@ public function getInitialConfigurationOptions(): Registry
 	/**
 	 * Save the configuration file
 	 *
+	 * @param   array  $options  Options array
+	 *
 	 * @return boolean
 	 *
 	 * @since 4.0
 	 */
-	public function saveConfiguration(): bool
+	public function saveConfiguration($options): bool
 	{
 		$app = $this->getApplication();
 
 		// Check db connection encription properties
 		$model = $app->bootComponent('com_config')->getMVCFactory($app)->createModel('Application', 'Administrator');
 
-		if (!$model->save($this->options))
+		if (!$model->save($options))
 		{
 			$this->ioStyle->error(Text::_('Failed to save properties'));
 
@@ -448,7 +450,7 @@ protected function doExecute(InputInterface $input, OutputInterface $output): in
 			return self::DB_VALIDATION_FAILED;
 		}
 
-		if ($this->saveConfiguration())
+		if ($this->saveConfiguration($combinedOptions))
 		{
 			$this->ioStyle->success('Configuration set');
 

From 61e5202df3bac18d8b3367ff145b706e9b0d76a5 Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Sun, 19 Apr 2020 10:39:48 +0200
Subject: [PATCH 30/32] prevent merge for old session data

actual data will win
---
 .../components/com_config/src/Model/ApplicationModel.php        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/administrator/components/com_config/src/Model/ApplicationModel.php b/administrator/components/com_config/src/Model/ApplicationModel.php
index 3aaa6ce171569..2029a903c3876 100644
--- a/administrator/components/com_config/src/Model/ApplicationModel.php
+++ b/administrator/components/com_config/src/Model/ApplicationModel.php
@@ -107,7 +107,7 @@ public function getData()
 		// Merge in the session data.
 		if (!empty($temp))
 		{
-			$data = array_merge($data, $temp);
+			$data = array_merge($temp, $data);
 		}
 
 		// Correct error_reporting value, since we removed "development", the "maximum" should be set instead

From 500d5c21b28732ccc89102ba6bd1231152ecf5ef Mon Sep 17 00:00:00 2001
From: Nicola Galgano <optimus4joomla@gmail.com>
Date: Sun, 19 Apr 2020 10:42:12 +0200
Subject: [PATCH 31/32] sanitize boolean

---
 .../src/Console/SetConfigurationCommand.php   | 24 ++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/libraries/src/Console/SetConfigurationCommand.php b/libraries/src/Console/SetConfigurationCommand.php
index 7353cf0494e55..202480e860ea0 100644
--- a/libraries/src/Console/SetConfigurationCommand.php
+++ b/libraries/src/Console/SetConfigurationCommand.php
@@ -443,7 +443,7 @@ protected function doExecute(InputInterface $input, OutputInterface $output): in
 
 		$initialOptions = $this->getInitialConfigurationOptions()->toArray();
 
-		$combinedOptions = array_merge($initialOptions, $this->options);
+		$combinedOptions = $this->sanitizeOptions(array_merge($initialOptions, $this->options));
 
 		if (!$this->checkDb($combinedOptions))
 		{
@@ -459,4 +459,26 @@ protected function doExecute(InputInterface $input, OutputInterface $output): in
 
 		return self::CONFIG_SET_FAILED;
 	}
+
+	/**
+	 * Sanitize the options array for boolean
+	 *
+	 * @param   array  $options  Options array
+	 *
+	 * @return array
+	 *
+	 * @since 4.0
+	 */
+	public function sanitizeOptions(Array $options): array
+	{
+		foreach ($options as $key => $value)
+		{
+			$value = $value === 'false' ? false : $value;
+			$value = $value === 'true' ? true : $value;
+
+			$options[$key] = $value;
+		}
+
+		return $options;
+	}
 }

From dda1b9cb9e44cbbc772e6cd0493ad768e1433cce Mon Sep 17 00:00:00 2001
From: Richard Fath <richard67@users.noreply.github.com>
Date: Sun, 19 Apr 2020 14:13:36 +0200
Subject: [PATCH 32/32] Fix help text of GetConfigurationCommand

---
 libraries/src/Console/GetConfigurationCommand.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libraries/src/Console/GetConfigurationCommand.php b/libraries/src/Console/GetConfigurationCommand.php
index 43a8a576163a9..4c0d1d56c5f80 100644
--- a/libraries/src/Console/GetConfigurationCommand.php
+++ b/libraries/src/Console/GetConfigurationCommand.php
@@ -315,7 +315,7 @@ protected function configure(): void
 
 		$help = "The <info>%command.name%</info> Displays the current value of a configuration option
 				\nUsage: <info>php %command.full_name%</info> <option>
-				\nGroup usage: <info>php %command.full_name%</info> --group=<groupname>
+				\nGroup usage: <info>php %command.full_name%</info> --group <groupname>
 				\nAvailable group names: $groupNames";
 
 		$this->setHelp($help);