Skip to content

Conversation

@ReLater
Copy link
Contributor

@ReLater ReLater commented Feb 22, 2020

Pull Request for Issue #27358
and additional find with tagged com_banners.category

Testing Instructions

  • Create a tag TagA.

  • Add this tag to some articles.

  • Add intro images to these articles.

  • Go to Banners: Categories

  • Add tag TagA to a category.

  • Create a menu item of type "Tagged Items":
    22-02-_2020_00-45-42

  • Leave Content Type empty.

  • Tabulator Tag Options > Set "Item Image" to "Show"

  • Go to https://search.google.com/structured-data/testing-tool
    and test the new menu item/front-end link.

Expected result

  • No errors

Actual result

2 errors:

  • Error 1 (com_banners.category item): A value for the url field is required.
    Not solvable because a com_banners.category item never has a link/url.
    That's the reason why I removed the (here anyway needless(!)) markup completely instead of solving just error 2.

22-02-_2020_00-22-27

  • Error 2:
    "Duplicate values for itemListElement.url are not allowed."

Reason: Two links inside ItemList marked as "url" (1 around headline, 1 around images).

22-02-_2020_01-08-41

@ChristineWk
Copy link

I have tested this item ✅ successfully on 9ace9e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28010.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Feb 26, 2020

I have tested this item ✅ successfully on 9ace9e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28010.

@Quy Quy removed the PR-staging label Feb 26, 2020
@Quy
Copy link
Contributor

Quy commented Feb 26, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28010.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 26, 2020
@Quy Quy added the PR-staging label Feb 26, 2020
@HLeithner HLeithner merged commit 01c3dd3 into joomla:staging Mar 4, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 4, 2020
@HLeithner
Copy link
Member

Thanks, if this is needed by a site owner a better override should be possible.

@HLeithner HLeithner added this to the Joomla! 3.9.16 milestone Mar 4, 2020
@ReLater ReLater deleted the patch-2 branch March 4, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants