Skip to content

Conversation

@brianteeman
Copy link
Contributor

If you want to search in the list of fields to find a specific field then there is more that you can do that simply search in the title. But there is no way to know this without reading the code.

This PR adds the full information for searching for a field or field group as a tooltip. This is in exactly the same format as in other components.

This PR also alpha sorts the language file

image

image

If you want to check the search code you can find it

// Filter by search in title
$search = $this->getState('filter.search');
if (! empty($search))
{
if (stripos($search, 'id:') === 0)
{
$query->where('a.id = ' . (int) substr($search, 3));
}
elseif (stripos($search, 'author:') === 0)
{
$search = $db->quote('%' . $db->escape(substr($search, 7), true) . '%');
$query->where('(ua.name LIKE ' . $search . ' OR ua.username LIKE ' . $search . ')');
}
else
{
$search = $db->quote('%' . str_replace(' ', '%', $db->escape(trim($search), true) . '%'));
$query->where('(a.title LIKE ' . $search . ' OR a.name LIKE ' . $search . ' OR a.note LIKE ' . $search . ')');
}
}

// Filter by search in title
$search = $this->getState('filter.search');
if (!empty($search))
{
if (stripos($search, 'id:') === 0)
{
$query->where('a.id = ' . (int) substr($search, 3));
}
else
{
$search = $db->quote('%' . str_replace(' ', '%', $db->escape(trim($search), true) . '%'));
$query->where('a.title LIKE ' . $search);

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Oct 20, 2019
@brianteeman
Copy link
Contributor Author

@zero-24 @SniperSister please can you look at the rips error

@SniperSister
Copy link
Contributor

@brianteeman the drone.yml in your branch is outdated and incompatible to the new RIPS version that we are using. Updating the yaml (or updating the branch in general) will solve the issue.

@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman
Copy link
Contributor Author

grrh - now it fails on some javascript that is unrelated to anything in this pr

@infograf768
Copy link
Member

relaunched drone

@brianteeman brianteeman closed this Dec 6, 2019
@brianteeman brianteeman deleted the fields branch December 6, 2019 23:07
@brianteeman brianteeman restored the fields branch December 6, 2019 23:09
@brianteeman brianteeman reopened this Dec 6, 2019
@Quy
Copy link
Contributor

Quy commented Dec 7, 2019

I have tested this item ✅ successfully on f9e90d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26747.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on f9e90d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26747.

@Quy
Copy link
Contributor

Quy commented Dec 7, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26747.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 7, 2019
@HLeithner HLeithner merged commit 011fe67 into joomla:staging Dec 9, 2019
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 9, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.14 milestone Dec 9, 2019
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the fields branch December 9, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants