Skip to content

[4.0][Cassiopeia] Remove IE11 support from module layout classes#26238

Closed
ciar4n wants to merge 1 commit intojoomla:4.0-devfrom
ciar4n:grid-layout-ie
Closed

[4.0][Cassiopeia] Remove IE11 support from module layout classes#26238
ciar4n wants to merge 1 commit intojoomla:4.0-devfrom
ciar4n:grid-layout-ie

Conversation

@ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Sep 9, 2019

Pull Request for Issue #.

Summary of Changes

Removes IE11 support from the module grid layout classes added in #18516

Testing Instructions

Apply this patch and run node build.js --compile-css for updating the changed SCSS. Alternatively, you can run npm i.

Check that #18516 still functions correctly

@brianteeman
Copy link
Contributor

@wilsonge i thought you said we should keep ie11 stuff for the frontend

@ciar4n ciar4n changed the title Remove IE11 support from module layout classes [4.0][Cassiopeia] Remove IE11 support from module layout classes Sep 9, 2019
@N6REJ
Copy link
Contributor

N6REJ commented Sep 9, 2019

we now have several pr's for the same issue(s) lol
#26242 #26230 #26231

@ciar4n
Copy link
Contributor Author

ciar4n commented Sep 9, 2019

That is why we ask for descriptive titles 😉

@ciar4n ciar4n closed this Sep 9, 2019
@wilsonge
Copy link
Contributor

IE11 stuff is fine to remove in this context. We want to make it easy for frontend templates to add support for html5 so I said keep the es5 files bundled with core. So a template doesn’t have to regenerate them all per release for all extensions.

@brianteeman
Copy link
Contributor

Thanks for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments