[4.0][Cassiopeia] Remove IE11 support from module layout classes#26238
Closed
ciar4n wants to merge 1 commit intojoomla:4.0-devfrom
Closed
[4.0][Cassiopeia] Remove IE11 support from module layout classes#26238ciar4n wants to merge 1 commit intojoomla:4.0-devfrom
ciar4n wants to merge 1 commit intojoomla:4.0-devfrom
Conversation
Contributor
|
@wilsonge i thought you said we should keep ie11 stuff for the frontend |
This was referenced Sep 9, 2019
Contributor
Contributor
Author
|
That is why we ask for descriptive titles 😉 |
Contributor
|
IE11 stuff is fine to remove in this context. We want to make it easy for frontend templates to add support for html5 so I said keep the es5 files bundled with core. So a template doesn’t have to regenerate them all per release for all extensions. |
Contributor
|
Thanks for the clarification |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #.
Summary of Changes
Removes IE11 support from the module grid layout classes added in #18516
Testing Instructions
Apply this patch and run
node build.js --compile-cssfor updating the changed SCSS. Alternatively, you can runnpm i.Check that #18516 still functions correctly