[3.0] Tree sorting in templates file tree #25792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a weird one and I cant say I fully understand it but this resolves the problem described below. If you have a large number of files in a folder then when you look at the list of files in the tree you will see that they are not in alphabetical order. They are in alphabetical order "in groups" which is why you need more than usual files to see it. To test copy a folder with a lot files to `templates\protostar\html` I used this folder as a source `administrator\components\com_templates\views\template\tmpl` Now when you view the file tree in the template component you will see the sirting is wrong as per screenshot Apply this PR and retest and the sirting is as expected.
Contributor
Author
|
NOTE: The same issue exists on J4 but as the fix is identical I assume there is no need for a seperate PR and this will get merged upstream eventually |
Contributor
|
Can you add back weblinks please :P |
Contributor
Author
|
Done ;) |
Contributor
|
I have tested this item ✅ successfully on e7b3b8b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25792. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on e7b3b8b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25792. |
|
Status "Ready To Commit". |
Contributor
Author
|
Thanks - this has been bugging me for ages |
Member
|
Thank you for the time you invest in Joomla! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a weird one and I cant say I fully understand it but this resolves the problem described below.
If you have a large number of files in a folder then when you look at the list of files in the tree you will see that they are not in alphabetical order. They are in alphabetical order "in groups" which is why you need more than usual files to see it.
To test copy a folder with a lot files to
templates\protostar\htmlI used this folder as a source
administrator\components\com_templates\views\template\tmplNow when you view the file tree in the template component you will see the sorting is wrong as per screenshot from the middle of the list
Apply this PR and retest and the sorting is as expected as seen in this screenshot from the end of the list