Skip to content

Conversation

@infograf768
Copy link
Member

@infograf768 infograf768 commented Jul 17, 2019

Summary of Changes

Postinstall component uses the admin mod_feed to display the Release News from the Joomla Project.
But it does not take into account a RTL language.
Alignment and direction of date are set by default to LTR
This PR corrects that by:

  1. Settting the module rssrtl to RTL if lang is RTL for the envelopping <div> in postinstall default.php
  2. Adding a specific style to the <ul to force the feed texts to be aligned left as these are in English in mod_feed.

Testing Instructions

Install Persian language and switch admin to Persian.
Load index.php?option=com_postinstall&eid=700

Before patch

The date in the left column is not displayed as RTL and is aligned left
Screen Shot 2019-07-17 at 11 30 41

After patch

The date is now RTL and alignment is right
Screen Shot 2019-07-17 at 11 29 38

Note

For 4.0 the modified code for mod_feed will be slightly different as we have no more
<?php echo $params->get('moduleclass_sfx'); ?>
and the class for the feed texts is now newsfeed list-group

@ghost ghost changed the title [staging] Correcting RTL in Postinstall Correcting RTL in Postinstall Jul 20, 2019
@ghost
Copy link

ghost commented Jul 20, 2019

I have tested this item 🔴 unsuccessfully on 0e91a57

without PR: Bullet is on Start of Title

ohne-pr

with PR: Bullet is on right End of Title (as Date).

mit-pr


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604.

@infograf768
Copy link
Member Author

infograf768 commented Jul 20, 2019

I see other errors with the feed text which should be ltr. Looking at this now.
Also, the padding was in error before patch.

@infograf768
Copy link
Member Author

@Quy @franz-wohlkoenig
Should be OK now.

Screen Shot 2019-07-20 at 11 39 22

@ghost
Copy link

ghost commented Jul 21, 2019

I have tested this item 🔴 unsuccessfully on ce28993

All Paragraphs are <strong>.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604.

@infograf768
Copy link
Member Author

@franz-wohlkoenig

This is not due to this patch but an error in the Persian ini file: a <strong> not closed properly:
(</ strong>)

COM_PRIVACY_POSTINSTALL_BODY="<p>با معرفی GDPR برای شهروندان اتحادیه اروپا و مقررات مشابه در سایر نقاط جهان، ممکن است لازم باشد قبل از ذخیره هر <strong>اطلاعات شخصی</ strong> از کاربر رضایت بخواهید.</p><p>جوملا 3.9 قابلیت های جدیدی را برای کمک به شما در ایجاد سیاست های حفظ حریم خصوصی سایت و جمع آوری رضایت کاربر معرفی می کند. علاوه بر این، یک گردش کار برای کمک به مدیریت درخواستهای اطلاعات کاربر مانند درخواست حذف اطلاعات شخصی خود از سایت شما در دسترس است.</p><p>برای اطلاعات بیشتر در مورد این ویژگی جدید لینک <a href='https://docs.joomla.org/J3.x:Privacy' target='_new'>مستندات حریم خصوصی</a> را مطالعه کنید.</p>"

once corrected to

COM_PRIVACY_POSTINSTALL_BODY="<p>با معرفی GDPR برای شهروندان اتحادیه اروپا و مقررات مشابه در سایر نقاط جهان، ممکن است لازم باشد قبل از ذخیره هر <strong>اطلاعات شخصی</strong> از کاربر رضایت بخواهید.</p><p>جوملا 3.9 قابلیت های جدیدی را برای کمک به شما در ایجاد سیاست های حفظ حریم خصوصی سایت و جمع آوری رضایت کاربر معرفی می کند. علاوه بر این، یک گردش کار برای کمک به مدیریت درخواستهای اطلاعات کاربر مانند درخواست حذف اطلاعات شخصی خود از سایت شما در دسترس است.</p><p>برای اطلاعات بیشتر در مورد این ویژگی جدید لینک <a href='https://docs.joomla.org/J3.x:Privacy' target='_new'>مستندات حریم خصوصی</a> را مطالعه کنید.</p>"

all is fine:

Screen Shot 2019-07-23 at 11 55 00

@ghost
Copy link

ghost commented Jul 23, 2019

I have tested this item ✅ successfully on 5346788


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604.

@infograf768
Copy link
Member Author

@Quy
Please confirm so that we get this in in next release.

@infograf768
Copy link
Member Author

Modified as requested.
@franz-wohlkoenig No need to test again.

@Quy
Copy link
Contributor

Quy commented Jul 25, 2019

I have tested this item ✅ successfully on 0317860


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604.

@Quy
Copy link
Contributor

Quy commented Jul 25, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 25, 2019
@infograf768
Copy link
Member Author

@HLeithner
Please merge.

@HLeithner HLeithner merged commit c901964 into joomla:staging Jul 31, 2019
@HLeithner
Copy link
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 31, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.11 milestone Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants