-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Correcting RTL in Postinstall #25604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have tested this item 🔴 unsuccessfully on 0e91a57 without PR: Bullet is on Start of Titlewith PR: Bullet is on right End of Title (as Date).This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604. |
|
I see other errors with the feed text which should be ltr. Looking at this now. |
|
@Quy @franz-wohlkoenig |
|
I have tested this item 🔴 unsuccessfully on ce28993 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604. |
|
@franz-wohlkoenig This is not due to this patch but an error in the Persian ini file: a once corrected to all is fine: |
|
I have tested this item ✅ successfully on 5346788 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604. |
|
@Quy |
administrator/components/com_postinstall/views/messages/tmpl/default.php
Outdated
Show resolved
Hide resolved
…efault.php Co-Authored-By: Quy <[email protected]>
|
Modified as requested. |
|
I have tested this item ✅ successfully on 0317860 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25604. |
|
@HLeithner |
|
thx |




Summary of Changes
Postinstall component uses the admin
mod_feedto display the Release News from the Joomla Project.But it does not take into account a RTL language.
Alignment and direction of date are set by default to LTR
This PR corrects that by:
rssrtlto RTL if lang is RTL for the envelopping<div>in postinstall default.php<ulto force the feed texts to be aligned left as these are in English in mod_feed.Testing Instructions
Install Persian language and switch admin to Persian.
Load
index.php?option=com_postinstall&eid=700Before patch
The date in the left column is not displayed as RTL and is aligned left

After patch
The date is now RTL and alignment is right

Note
For 4.0 the modified code for mod_feed will be slightly different as we have no more
<?php echo $params->get('moduleclass_sfx'); ?>and the class for the feed texts is now
newsfeed list-group