[com_templates] Add prefix to class name in menu assignment #25454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
changed the title
Member
|
I have tested this item ✅ successfully on 06acd66 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25454. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 06acd66 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25454. |
Contributor
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25454. |
ghost
added
the
Member
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #24605.
Summary of Changes
Add prefix to class name to prevent conflicting with existing classes.
Testing Instructions
Create a new Menu named Hidden and set the menutype to "hidden".
Add a menu item to that menu.
Open a template style and check the Menu Assignment tab.
Expected result
A visible checkbox to associate the template style with the created menu item.
Actual result
No checkbox visible. Reason for that is the menu alias will be added to the Input tag as a class - without any prefix. So it becomes input[type=checkbox].hidden which is a class used by bootstrap to hide stuff.