Update j/input,j/session,phar-stream-wrapper. Pinned sodium_compat #25406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinned sodium_compat because of file case change, atm this could not be handled by the Joomla! updater.
wilsonge
reviewed
Jul 3, 2019
Contributor
|
I looks good to me too, I didn only a code review. Sorry don't have time for a real test |
Member
Author
|
thx |
Contributor
|
Did a real test just now. Nothing was obviously broken doing a quick browse around the frontend/backend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinned sodium_compat because of file case change, atm this could
not be handled by the Joomla! updater.
Replace PR #25279
Pull Request for Issue #25277
Maybe @jurihahn and @LoRexxar can test the phar-stream-wrapper update?.
Sodium_compat is now pinned to version 1.9.1 till we have a solution for the filename with the wrong case.
@mbabker can you check this PR?