Skip to content

Conversation

@BaleshSrle
Copy link

@BaleshSrle BaleshSrle commented Jun 5, 2019

Revision for Pull Request #20212 .

Summary of Changes

By revisiting my pull request and using site w3schools.com as guide, I made a solution to merge HTML4 and HTML5 elements by leaving Width and Height in HTML4, but scrolling and frameborder are transitioned to HTML5

Testing Instructions

You can use Joomla's current settings for width & height, but you need to modify your settings for borders and scrollbars.

Expected result

To work flawlessly.

Documentation Changes Required

Need to modify 6 files to work without any problems or hiccups:

  • modules/mod_wrapper/mod_wrapper.xml

  • modules/mod_wrapper/mod_wrapper.php

  • modules/mod_wrapper/Helper/WrapperHelper.php

  • modules/mod_wrapper/tmpl/default.php

  • components/com_wrapper/tmpl/wrapper/default.xml

  • components/com_wrapper/tmpl/wrapper/default.php

@brianteeman
Copy link
Contributor

For future reference - never use w3schools as a source - it is rarely complete or accurate. Much better to use https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe

<option value="0">JNO</option>
<option value="1">JYES</option>
<option value="none">JNO</option>
<option value="thin solid #D3D3D3">JYES</option>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option should not be hardcoded CSS. Define it with a variable and compile it in the layout file. Like that the admin has the option to change it in a template override. Gold solution would be to define a class in the template file instead of hardcoded CSS and style it in a CSS file. Like that it is even easier to override by CSS only.

Copy link
Author

@BaleshSrle BaleshSrle Jun 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you know how to do it - be my guest, because I don't.

And by the way, this code works because I'm using my site .::STUDENTI LOGISTIKE@ Saobracajni fakultet Doboj as proving ground for this code (site is created in Joomla! 3.9.6 with modified wrapper module and component by yours truly).

The beauty of this code is that I'm not adding something new (like you are suggesting), I'm modifying the module and component of wrapper (or iframe) element to be compatible with HTML5 standard.

@BaleshSrle
Copy link
Author

For future reference - never use w3schools as a source - it is rarely complete or accurate. Much better to use https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe

Sorry, but I prefer using https://www.w3schools.com/html/html_iframe.asp & https://www.w3schools.com/tags/tag_iframe.asp

@BaleshSrle BaleshSrle closed this Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants