Skip to content

Conversation

@wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Jan 12, 2019

See #23517 for test instructions. Note you must test with an extension that hasn't been namespaced and uses core MVC

@PhocaCz
Copy link
Contributor

PhocaCz commented Jan 13, 2019

I have tested this item ✅ successfully on efbeebb

Tested on Joomla! 4.0.0-alpha7-dev


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23525.

@wilsonge wilsonge changed the title Fix Legacy Model loading. Fixes #23517 [4.0] Fix Legacy Model loading. Fixes #23517 Jan 13, 2019
@ChristineWk
Copy link

I have tested this item ✅ successfully on efbeebb

Tested on alpha-7 with new installation of extension Phocadownload.
But: I did'nt get the failure as shown in #23525. Phocadownload > Files, I got:
An error has occurred.

0 Call to a member function get() on null 

After using the Patch, above message has gone.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23525.

@Quy
Copy link
Contributor

Quy commented Jan 13, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23525.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 13, 2019
@ChristineWk
Copy link

Checked again, because first test was only with "Files" but now, all: (present status):
Files / Categories / Licenses / Downloads / Uploads / File Rating / Styles
0 Call to a member function get() on null

Layout
Call to a member function getTable() on boolean and:
Warning: Invalid argument supplied for foreach() in /.../administrator/components/com_phocadownload/views/phocadownloadstat/view.html.php on line 28 Warning: count(): Parameter must be an array or an object that implements Countable in .../administrator/components/com_phocadownload/views/phocadownloadstat/view.html.php on line 36

after Patch; both messages has gone


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23525.

@wilsonge wilsonge merged commit c9e15d6 into joomla:4.0-dev Jan 13, 2019
@wilsonge wilsonge deleted the legacy-loading branch January 13, 2019 19:14
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 13, 2019
@wilsonge
Copy link
Contributor Author

Thanks guys :)

@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 13, 2019
@wilsonge wilsonge mentioned this pull request Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants