-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.0] Adding a mail templating system #22126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 51 commits
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
c5083be
Adding a mail templating system
Hackwar 05d3b14
Further work on the mail templating system
Hackwar ed2ca3e
Changes from @brianteeman review
Hackwar 3e6d514
Merge branch '4.0-dev' into j4mailtemplates
Hackwar 32c5e2f
Codestyle
Hackwar 114c5a9
Merge branch 'j4mailtemplates' of github.com:Hackwar/joomla-cms into …
Hackwar 92a5552
Further work on mail templates
Hackwar acde9b6
Further work on Mail Templates
Hackwar ae73644
Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into j…
Hackwar d6bc7c2
Further work on Mail Templates
Hackwar 3987764
Codestyle
Hackwar b8b0519
Adding test mail as example for a mail template
Hackwar 4002f73
Merge branch '4.0-dev' into j4mailtemplates
Hackwar 2045ee7
Code cleanup
wilsonge 8b9da11
Merge branch '4.0-dev' into j4mailtemplates
Hackwar 9da9fe1
Merge branch '4.0-dev' into j4mailtemplates
Hackwar d649824
Merge branch '4.0-dev' into j4mailtemplates
laoneo a85f9c8
Merge branch '4.0-dev' into j4mailtemplates
laoneo 9557887
Merge branch '4.0-dev' into j4mailtemplates
Hackwar 8ae30c1
Adding filters
Hackwar ea19a49
Codestyle
Hackwar d484293
Merge branch '4.0-dev' into j4mailtemplates
Hackwar eb07c09
Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into j…
Hackwar 1b864af
Merge branch 'j4mailtemplates' of github.com:Hackwar/joomla-cms into …
Hackwar 0c1b3c8
Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into j…
Hackwar f83efbd
Adding mail templating system
Hackwar f52956a
Codestyle and language fix
Hackwar 786421a
EmailTemplateEdit js
Fedik 140b08d
Show/hide tags section. Do not allow to add tag in to disabled input
Fedik e892aa3
Merge pull request #26 from Fedik/pull22126
Hackwar d79dc5c
Merge branch '4.0-dev' into j4mailtemplates
Hackwar c74d621
Merge branch '4.0-dev' into j4mailtemplates
Hackwar 6efe92f
Merge branch '4.0-dev' into j4mailtemplates
Hackwar 0d47f77
Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into j…
Hackwar e43d7d8
Merge branch 'j4mailtemplates' of github.com:Hackwar/joomla-cms into …
Hackwar 9c773a7
JS Codestyle
Hackwar 7eaf6c3
JS Codestyle
Hackwar 0a83161
Fixing SQL install files
Hackwar 2515708
Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into j…
Hackwar f083f96
Fixing SQL
Hackwar 8e556d6
Merge branch '4.0-dev' into j4mailtemplates
Hackwar 9f66708
Merge branch '4.0-dev' into j4mailtemplates
Hackwar df7c6cd
Codestyle and cleanup of com_mails
Hackwar 882b5e3
Merge branch '4.0-dev' into j4mailtemplates
wilsonge 380e20d
Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into j…
Hackwar b65709e
Fixing merge conflicts
Hackwar f42b052
Merge branch 'j4mailtemplates' of github.com:Hackwar/joomla-cms into …
Hackwar cfbeaeb
Fix javascript to remove switcher references
wilsonge 5f322e4
Remove console log
wilsonge c28abf6
Fix javascript to remove switcher references (#30)
Hackwar 927a6c2
Fixing readonly for textarea
Hackwar cf2d1a7
Several fixes
Hackwar b75f060
Removing accidental label
Hackwar 8c4088e
Adding labels, fixing docblocks
Hackwar 2cff8b4
Merge branch 'j4mailtemplates' of github.com:Hackwar/joomla-cms into …
Hackwar 3767972
Clarifying language strings used
Hackwar 99561a2
Merge branch '4.0-dev' into j4mailtemplates
Hackwar 8e2e954
Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into j…
Hackwar 077eee3
Merge branch '4.0-dev' into j4mailtemplates
wilsonge aa4a9ae
Update administrator/components/com_admin/sql/updates/postgresql/4.0.…
Hackwar a3efef9
Remove obsolete columns from SQL statements
roland-d 30e5d67
Merge pull request #33 from roland-d/code-fixes-j4
Hackwar e398dcb
Removing false static
Hackwar 28924d2
Merge branch '4.0-dev' into j4mailtemplates
Hackwar fb29369
Fix tags not showing in html mode
wilsonge 45176dc
Cleanup template model doc block
wilsonge 0c4b3bb
Start work on disabled function
wilsonge e2f353a
If textarea has readonly attribute start tinymce in readonly mode
wilsonge 1f2b62c
Add function to codemirro
wilsonge ac21fe6
Simplify editor none
wilsonge e5cd50a
Editor disabled (#35)
Hackwar 4c11029
Merge branch '4.0-dev' into j4mailtemplates
Hackwar 7cb22eb
Merge branch '4.0-dev' into j4mailtemplates
wilsonge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
administrator/components/com_admin/sql/updates/mysql/4.0.0-2019-01-16.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| INSERT INTO `#__extensions` (`name`, `type`, `element`, `folder`, `client_id`, `enabled`, `access`, `protected`, `manifest_cache`, `params`, `custom_data`, `system_data`, `checked_out`, `checked_out_time`, `ordering`, `state`) VALUES | ||
| ('com_mails', 'component', 'com_mails', '', 1, 1, 1, 1, '{"name":"com_mails","type":"component","creationDate":"January 2019","author":"Joomla! Project","copyright":"(C) 2005 - 2018 Open Source Matters. All rights reserved.","authorEmail":"[email protected]","authorUrl":"www.joomla.org","version":"4.0.0","description":"COM_MAILS_XML_DESCRIPTION","group":""}', '{}', '', '', 0, '0000-00-00 00:00:00', 0, 0); | ||
|
|
||
| CREATE TABLE IF NOT EXISTS `#__mail_templates` ( | ||
| `template_id` VARCHAR(127) NOT NULL DEFAULT '', | ||
| `language` char(7) NOT NULL DEFAULT '', | ||
| `subject` VARCHAR(255) NOT NULL DEFAULT '', | ||
| `body` TEXT NOT NULL, | ||
| `htmlbody` TEXT NOT NULL, | ||
| `attachments` TEXT NOT NULL, | ||
| `params` TEXT NOT NULL, | ||
| PRIMARY KEY (`template_id`, `language`) | ||
| ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 DEFAULT COLLATE=utf8mb4_unicode_ci; | ||
|
|
||
| INSERT INTO `#__mail_templates` (`template_id`, `language`, `subject`, `body`, `htmlbody`, `attachments`, `params`) VALUES ('com_config.test_mail', '', 'COM_CONFIG_SENDMAIL_SUBJECT', 'COM_CONFIG_SENDMAIL_BODY', '', '', '{"tags":["sitename","method"]}'); |
17 changes: 17 additions & 0 deletions
17
administrator/components/com_admin/sql/updates/postgresql/4.0.0-2019-01-16.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| INSERT INTO "#__extensions" ("name", "type", "element", "folder", "client_id", "enabled", "access", "protected", "manifest_cache", "params", "custom_data", "system_data", "checked_out", "checked_out_time", "ordering", "state") VALUES | ||
| ('com_mails', 'component', 'com_mails', '', 1, 1, 1, 1, '{"name":"com_mails","type":"component","creationDate":"January 2019","author":"Joomla! Project","copyright":"(C) 2005 - 2018 Open Source Matters. All rights reserved.","authorEmail":"[email protected]","authorUrl":"www.joomla.org","version":"4.0.0","description":"COM_MAILS_XML_DESCRIPTION","group":""}', '{}', '', '', 0, '0000-00-00 00:00:00', 0, 0); | ||
|
|
||
| CREATE TABLE IF NOT EXISTS "#__mail_templates" ( | ||
| "template_id" varchar(127) NOT NULL DEFAULT '', | ||
| "language" char(7) NOT NULL DEFAULT '', | ||
| "subject" varchar(255) NOT NULL DEFAULT '', | ||
| "body" TEXT NOT NULL, | ||
| "htmlbody" TEXT NOT NULL, | ||
| "attachments" TEXT NOT NULL, | ||
| "params" TEXT NOT NULL, | ||
| CONSTRAINT "#__mail_templates_idx_template_id_language" UNIQUE ("template_id", "language") | ||
| ); | ||
| CREATE INDEX "#__mail_templates_idx_template_id" ON "#__mail_templates" ("template_id"); | ||
| CREATE INDEX "#__mail_templates_idx_language" ON "#__mail_templates" ("language"); | ||
|
|
||
| INSERT INTO "#__mail_templates" ("template_id", "language", "subject", "body", "htmlbody", "attachments", "params") VALUES ('com_config.test_mail', '', 'COM_CONFIG_SENDMAIL_SUBJECT', 'COM_CONFIG_SENDMAIL_BODY', '', '', '{"tags":["sitename","method"]}'); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
administrator/components/com_mails/Controller/DisplayController.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <?php | ||
| /** | ||
| * @package Joomla.Administrator | ||
| * @subpackage com_mails | ||
| * | ||
| * @copyright Copyright (C) 2005 - 2018 Open Source Matters, Inc. All rights reserved. | ||
| * @license GNU General Public License version 2 or later; see LICENSE.txt | ||
| */ | ||
|
|
||
| namespace Joomla\Component\Mails\Administrator\Controller; | ||
|
|
||
| defined('_JEXEC') or die; | ||
|
|
||
| use Joomla\CMS\MVC\Controller\BaseController as BaseController; | ||
|
|
||
| /** | ||
| * Controller for global configuration | ||
| * | ||
| * @since 1.5 | ||
Hackwar marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| */ | ||
| class DisplayController extends BaseController | ||
| { | ||
| /** | ||
| * The default view. | ||
| * | ||
| * @var string | ||
| * @since 1.6 | ||
| */ | ||
| protected $default_view = 'templates'; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.